You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/11 08:49:15 UTC
[GitHub] [beam] bullet03 opened a new pull request, #24115: [Website] update go-dependencies.md java-dependencies.md links
bullet03 opened a new pull request, #24115:
URL: https://github.com/apache/beam/pull/24115
Resolves #24084
- change structure of links, make them `a` tag
- wrap links on https://beam.apache.org/documentation/sdks/go-dependencies/index.html and https://beam.apache.org/documentation/sdks/java-dependencies/ in `p` tag with word-break rule, so they don't stretch the page
- add `target="_blank"` attribute to `a` tag so links would open in separate tab in case of a click
------------------------
before:
after:
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #24115: [Website] update go-dependencies.md java-dependencies.md links
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #24115:
URL: https://github.com/apache/beam/pull/24115#issuecomment-1313749312
@bullet03
> Just wondering - why only these urls? What's about the other long ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #24115: [Website] update go-dependencies.md java-dependencies.md links
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #24115:
URL: https://github.com/apache/beam/pull/24115#issuecomment-1313319738
@aromanenko-dev, could you, please help with review of current PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #24115: [Website] update go-dependencies.md java-dependencies.md links
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #24115:
URL: https://github.com/apache/beam/pull/24115#issuecomment-1313417125
> Thanks, LGTM
>
> Just wondering - why only these urls? What's about the other long ones?
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #24115: [Website] update go-dependencies.md java-dependencies.md links
Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #24115:
URL: https://github.com/apache/beam/pull/24115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #24115: [Website] update go-dependencies.md java-dependencies.md links
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #24115:
URL: https://github.com/apache/beam/pull/24115#issuecomment-1314893053
> @bullet03
>
> > Just wondering - why only these urls? What's about the other long ones?
Thank you!
Found this by the moment. Still looking throught the whole site to find more, will batch them in one PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AlyaBoiko commented on pull request #24115: [Website] update go-dependencies.md java-dependencies.md links
Posted by GitBox <gi...@apache.org>.
AlyaBoiko commented on PR #24115:
URL: https://github.com/apache/beam/pull/24115#issuecomment-1311775093
Verified, works as expected. Reviewed and tested by QA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org