You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "schaefa (via GitHub)" <gi...@apache.org> on 2023/02/28 00:11:33 UTC
[GitHub] [sling-org-apache-sling-graphql-core] schaefa opened a new pull request, #34: SLING-10900 - Upgrade graphql-java to 19.3
schaefa opened a new pull request, #34:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/34
Adjusted the Selection Set and Selected Field Wrapers as well as its tests. Added antlr runtime to the maven dependencies and fix a test due to changes in graphql-java.
Unit and Integration tests in AEM's sites-graphql are all passing as well as manual testing is successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] schaefa closed pull request #34: SLING-10900 - Upgrade graphql-java to 19.3
Posted by "schaefa (via GitHub)" <gi...@apache.org>.
schaefa closed pull request #34: SLING-10900 - Upgrade graphql-java to 19.3
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] schaefa commented on pull request #34: SLING-10900 - Upgrade graphql-java to 19.3
Posted by "schaefa (via GitHub)" <gi...@apache.org>.
schaefa commented on PR #34:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/34#issuecomment-1451025244
Due to issue with graphql-java a release of the next 19.x with fixes to the JAR file is not likely. So it is probably better to go with 20.x as a new release is likely in April 2023.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] schaefa commented on pull request #34: SLING-10900 - Upgrade graphql-java to 19.3
Posted by "schaefa (via GitHub)" <gi...@apache.org>.
schaefa commented on PR #34:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/34#issuecomment-1448661378
Due to issues with graphql-java with all patched versions (17.4, 18.3, 19.3 and 20.0) any tests where graphql-java is loaded into Feature Model system fails.
That said fixing graphql-java is pretty easy and already accepted by graphql-java for 20.x which unfortunately fails with a nasty class loading issue.
As this module is not used in Sling we could release it with a Warning about requiring a patched release for graphql-java.
Not sure who using Sling Graphql Core beside AEM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org