You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by an...@apache.org on 2018/03/01 00:04:02 UTC
[1/6] mesos git commit: Added Sachin Paryani to the contributors list.
Repository: mesos
Updated Branches:
refs/heads/master a15eb712a -> e0552d83e
Added Sachin Paryani to the contributors list.
Review: https://reviews.apache.org/r/65797/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/ec8f549c
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/ec8f549c
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/ec8f549c
Branch: refs/heads/master
Commit: ec8f549c032d146061ce29928be338ab06591daa
Parents: a15eb71
Author: Sachin Paryani <sa...@gmail.com>
Authored: Wed Feb 28 11:12:27 2018 -0800
Committer: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Committed: Wed Feb 28 11:24:17 2018 -0800
----------------------------------------------------------------------
docs/contributors.yaml | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/ec8f549c/docs/contributors.yaml
----------------------------------------------------------------------
diff --git a/docs/contributors.yaml b/docs/contributors.yaml
index 73f4d08..aea2fcc 100644
--- a/docs/contributors.yaml
+++ b/docs/contributors.yaml
@@ -668,6 +668,12 @@
jira_user: okuryu
reviewboard_user: okuryu
+- name: Sachin Paryani
+ emails:
+ - sachin.paryani@gmail.com
+ jira_user: sachinparyani
+ reviewboard_user: sachinparyani
+
- name: Stephen Hankinson
affiliations:
- {organization: Affinio Inc.}
[5/6] mesos git commit: Windows: Ported `mesos-execute`.
Posted by an...@apache.org.
Windows: Ported `mesos-execute`.
This patch ports the `mesos-execute` CLI framework to Windows.
The change was to print an appropriate error message without the
calling `getuid` API, which doesn't exist on Windows.
Review: https://reviews.apache.org/r/65798/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/97321588
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/97321588
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/97321588
Branch: refs/heads/master
Commit: 9732158894eaea56b60d71fc8ef039e5695bc834
Parents: 3dc7f84
Author: Sachin Paryani <sa...@gmail.com>
Authored: Wed Feb 28 11:12:34 2018 -0800
Committer: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Committed: Wed Feb 28 16:02:57 2018 -0800
----------------------------------------------------------------------
src/cli/CMakeLists.txt | 13 +++++--------
src/cli/execute.cpp | 5 +++++
2 files changed, 10 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/97321588/src/cli/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/src/cli/CMakeLists.txt b/src/cli/CMakeLists.txt
index 06d9e62..7b2abf2 100644
--- a/src/cli/CMakeLists.txt
+++ b/src/cli/CMakeLists.txt
@@ -14,11 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# TODO(josephw): Enable this on Windows after sorting out the dependencies.
-if (NOT WIN32)
- # THE MESOS EXECUTE.
- # Utility used to schedule and run a command in a mesos cluster.
- ################################################################
- add_executable(mesos-execute execute.cpp)
- target_link_libraries(mesos-execute PRIVATE mesos)
-endif ()
+# THE MESOS EXECUTE.
+# Utility used to schedule and run a command in a mesos cluster.
+################################################################
+add_executable(mesos-execute execute.cpp)
+target_link_libraries(mesos-execute PRIVATE mesos)
http://git-wip-us.apache.org/repos/asf/mesos/blob/97321588/src/cli/execute.cpp
----------------------------------------------------------------------
diff --git a/src/cli/execute.cpp b/src/cli/execute.cpp
index 221d65f..89e5130 100644
--- a/src/cli/execute.cpp
+++ b/src/cli/execute.cpp
@@ -976,7 +976,12 @@ int main(int argc, char** argv)
if (user.isError()) {
EXIT(EXIT_FAILURE) << "Failed to get username: " << user.error();
} else {
+#ifndef __WINDOWS__
EXIT(EXIT_FAILURE) << "No username for uid " << ::getuid();
+#else
+ // NOTE: The `::getuid()` function does not exist on Windows.
+ EXIT(EXIT_FAILURE) << "No username for current user";
+#endif // __WINDOWS__
}
}
[4/6] mesos git commit: Added warning to `apply-reviews.py` for
submitted patches.
Posted by an...@apache.org.
Added warning to `apply-reviews.py` for submitted patches.
This commit emits a warning when a chain skips submitted patches so
that the user is aware they were ignored.
Review: https://reviews.apache.org/r/65795/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/3dc7f849
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/3dc7f849
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/3dc7f849
Branch: refs/heads/master
Commit: 3dc7f849205cc76206b00b41bf768cce96740fde
Parents: 6450205
Author: Shubham Kumar <sh...@umail.iu.edu>
Authored: Wed Feb 28 11:11:15 2018 -0800
Committer: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Committed: Wed Feb 28 15:07:04 2018 -0800
----------------------------------------------------------------------
support/apply-reviews.py | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/3dc7f849/support/apply-reviews.py
----------------------------------------------------------------------
diff --git a/support/apply-reviews.py b/support/apply-reviews.py
index 9fc1579..b6801b9 100755
--- a/support/apply-reviews.py
+++ b/support/apply-reviews.py
@@ -110,6 +110,8 @@ def review_chain(review_id):
# Stop as soon as we stumble upon a submitted request.
status = json_obj.get('review_request').get('status')
if status == "submitted":
+ sys.stderr.write('Warning: Review {review} has already'
+ ' been applied\n'.format(review=review_id))
return []
# Verify that the review has exactly one parent.
[6/6] mesos git commit: Windows: Ported `mesos-master` for testing.
Posted by an...@apache.org.
Windows: Ported `mesos-master` for testing.
This patch ports the `mesos-master` executable to Windows. Note that
this is only for testing, as we still lack support for a persistent
registry through `leveldb`, the master can only be run with
`--registry=in_memory` on Windows. However, this with the CLI is
enough to test the whole Mesos stack on a single Windows node.
The change was to temporarily remove support for the
`--ip_discovery_command` flag on Windows, since it uses a deleted
function, `os::shell`, instead emit an appropriate error message. When
`os::shell` is implemented on Windows, we will add support for
`--ip_discovery_command` back to the agent and master.
Review: https://reviews.apache.org/r/65799/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e0552d83
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e0552d83
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e0552d83
Branch: refs/heads/master
Commit: e0552d83e5ec8f17f9116a08a666662734992eea
Parents: 9732158
Author: Sachin Paryani <sa...@gmail.com>
Authored: Wed Feb 28 11:13:31 2018 -0800
Committer: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Committed: Wed Feb 28 16:03:26 2018 -0800
----------------------------------------------------------------------
src/master/CMakeLists.txt | 11 ++++-------
src/master/main.cpp | 6 ++++++
src/slave/main.cpp | 2 ++
3 files changed, 12 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/e0552d83/src/master/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/src/master/CMakeLists.txt b/src/master/CMakeLists.txt
index ec55211..b8953bd 100644
--- a/src/master/CMakeLists.txt
+++ b/src/master/CMakeLists.txt
@@ -14,10 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# TODO(josephw): Enable this on Windows after sorting out the dependencies.
-if (NOT WIN32)
- # THE MASTER EXECUTABLE.
- ########################
- add_executable(mesos-master main.cpp)
- target_link_libraries(mesos-master PRIVATE mesos)
-endif ()
+# THE MASTER EXECUTABLE.
+########################
+add_executable(mesos-master main.cpp)
+target_link_libraries(mesos-master PRIVATE mesos)
http://git-wip-us.apache.org/repos/asf/mesos/blob/e0552d83/src/master/main.cpp
----------------------------------------------------------------------
diff --git a/src/master/main.cpp b/src/master/main.cpp
index 8cb52d0..3d93fd4 100644
--- a/src/master/main.cpp
+++ b/src/master/main.cpp
@@ -199,6 +199,7 @@ int main(int argc, char** argv)
}
if (flags.ip_discovery_command.isSome()) {
+#ifndef __WINDOWS__
Try<string> ipAddress = os::shell(flags.ip_discovery_command.get());
if (ipAddress.isError()) {
@@ -206,6 +207,11 @@ int main(int argc, char** argv)
}
os::setenv("LIBPROCESS_IP", strings::trim(ipAddress.get()));
+#else
+ // TODO(andschwa): Support this when `os::shell` is enabled.
+ EXIT(EXIT_FAILURE)
+ << "The `--ip.discovery_command` is not yet supported on Windows";
+#endif // __WINDOWS__
} else if (flags.ip.isSome()) {
os::setenv("LIBPROCESS_IP", flags.ip.get());
}
http://git-wip-us.apache.org/repos/asf/mesos/blob/e0552d83/src/slave/main.cpp
----------------------------------------------------------------------
diff --git a/src/slave/main.cpp b/src/slave/main.cpp
index b95bb25..6743727 100644
--- a/src/slave/main.cpp
+++ b/src/slave/main.cpp
@@ -328,6 +328,7 @@ int main(int argc, char** argv)
os::setenv("LIBPROCESS_IP", strings::trim(ipAddress.get()));
#else
+ // TODO(andschwa): Support this when `os::shell` is enabled.
EXIT(EXIT_FAILURE)
<< "The `--ip_discovery_command` is not yet supported on Windows";
#endif // __WINDOWS__
@@ -344,6 +345,7 @@ int main(int argc, char** argv)
os::setenv("LIBPROCESS_IP6", strings::trim(ip6Address.get()));
#else
+ // TODO(andschwa): Support this when `os::shell` is enabled.
EXIT(EXIT_FAILURE)
<< "The `--ip6_discovery_command` is not yet supported on Windows";
#endif // __WINDOWS__
[2/6] mesos git commit: Added Anurag Bihani to the contributors list.
Posted by an...@apache.org.
Added Anurag Bihani to the contributors list.
Review: https://reviews.apache.org/r/65800/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/64502057
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/64502057
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/64502057
Branch: refs/heads/master
Commit: 64502057afb23c2eacc2681b2eb5e4cee14ea98b
Parents: 12c226a
Author: Sachin Paryani <sa...@gmail.com>
Authored: Wed Feb 28 11:16:38 2018 -0800
Committer: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Committed: Wed Feb 28 11:24:21 2018 -0800
----------------------------------------------------------------------
docs/contributors.yaml | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/64502057/docs/contributors.yaml
----------------------------------------------------------------------
diff --git a/docs/contributors.yaml b/docs/contributors.yaml
index 32deac4..c68d3aa 100644
--- a/docs/contributors.yaml
+++ b/docs/contributors.yaml
@@ -108,6 +108,12 @@
jira_user: anindya.sinha
reviewboard_user: anisinha
+- name: Anurag Bihani
+ emails:
+ - anuragbihani@gmail.com
+ jira_user: anuragbihani
+ reviewboard_user: anuragbihani
+
- name: Armand Grillet
affiliations:
- {organization: Mesosphere}
[3/6] mesos git commit: Added Shubham Kumar to the contributors list.
Posted by an...@apache.org.
Added Shubham Kumar to the contributors list.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/12c226ae
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/12c226ae
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/12c226ae
Branch: refs/heads/master
Commit: 12c226ae9b798bed7fa54783b28656a8b1f1961c
Parents: ec8f549
Author: Shubham Kumar <sh...@umail.iu.edu>
Authored: Wed Feb 28 11:22:42 2018 -0800
Committer: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Committed: Wed Feb 28 11:24:21 2018 -0800
----------------------------------------------------------------------
docs/contributors.yaml | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/12c226ae/docs/contributors.yaml
----------------------------------------------------------------------
diff --git a/docs/contributors.yaml b/docs/contributors.yaml
index aea2fcc..32deac4 100644
--- a/docs/contributors.yaml
+++ b/docs/contributors.yaml
@@ -674,6 +674,12 @@
jira_user: sachinparyani
reviewboard_user: sachinparyani
+- name: Shubham Kumar
+ emails:
+ - shukumar@umail.iu.edu
+ jira_user: shukumar
+ reviewboard_user: shukumar
+
- name: Stephen Hankinson
affiliations:
- {organization: Affinio Inc.}