You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "moiseenkov (via GitHub)" <gi...@apache.org> on 2024/03/04 16:38:12 UTC

[PR] the resource example file `example_upload.txt` has been moved to `air… [airflow]

moiseenkov opened a new pull request, #37883:
URL: https://github.com/apache/airflow/pull/37883

   - slightly refactored GCS system tests.
   - source file "example_upload.txt" was moved from local file system to the publicly available GCS bucket.
   - two system tests `example_s3_to_gcs.py` and `example_s3_to_gcs_async.py` have been merged into a single system test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactored GCS system tests [airflow]

Posted by "dirrao (via GitHub)" <gi...@apache.org>.
dirrao commented on code in PR #37883:
URL: https://github.com/apache/airflow/pull/37883#discussion_r1512076468


##########
tests/system/providers/google/cloud/gcs/example_gcs_upload_download.py:
##########
@@ -57,11 +57,13 @@
     # [END howto_operator_gcs_create_bucket]
 
     # [START howto_operator_local_filesystem_to_gcs]
-    upload_file = LocalFilesystemToGCSOperator(

Review Comment:
   Needs to update the comments as well.
   `howto_operator_local_filesystem_to_gcs`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactored GCS system tests [airflow]

Posted by "moiseenkov (via GitHub)" <gi...@apache.org>.
moiseenkov commented on code in PR #37883:
URL: https://github.com/apache/airflow/pull/37883#discussion_r1512670916


##########
tests/system/providers/google/cloud/gcs/example_gcs_upload_download.py:
##########
@@ -57,11 +57,13 @@
     # [END howto_operator_gcs_create_bucket]
 
     # [START howto_operator_local_filesystem_to_gcs]
-    upload_file = LocalFilesystemToGCSOperator(

Review Comment:
   I think I understood your point. That test was modified without any necessity by mistake. I rolled back those changes. Thank you for noticing. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactored GCS system tests [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #37883:
URL: https://github.com/apache/airflow/pull/37883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactored GCS system tests [airflow]

Posted by "moiseenkov (via GitHub)" <gi...@apache.org>.
moiseenkov commented on code in PR #37883:
URL: https://github.com/apache/airflow/pull/37883#discussion_r1512338784


##########
tests/system/providers/google/cloud/gcs/example_gcs_upload_download.py:
##########
@@ -57,11 +57,13 @@
     # [END howto_operator_gcs_create_bucket]
 
     # [START howto_operator_local_filesystem_to_gcs]
-    upload_file = LocalFilesystemToGCSOperator(

Review Comment:
   Could you please express in more detail what exactly is expected to be fixed? As far as I know, this format of comments is used for referencing to the source code examples in the automatically generated [documentation](https://github.com/VladaZakharova/airflow/blob/410d0c0f86aaec71e2c0050f5adbc53fb7b441e7/docs/apache-airflow-providers-google/operators/transfer/local_to_gcs.rst). This convention is followed in all system tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org