You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/10/23 15:17:07 UTC
[PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
pitrou opened a new pull request, #38403:
URL: https://github.com/apache/arrow/pull/38403
### Rationale for this change
It is currently cumbersome to run integration tests from an other repository, as each tested implementation must be built explicitly.
See explanatory comment at https://github.com/apache/arrow-rs/pull/4957#issuecomment-1771707301
### What changes are included in this PR?
Provide a wrapper script to automate building the implementations being tested.
Allow usage of environment variables such as `ARROW_INTEGRATION_CPP`, etc. to selectively disable implementations.
### Are these changes tested?
Yes, by construction.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #38403:
URL: https://github.com/apache/arrow/pull/38403#issuecomment-1777097612
@kou Could you review this again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #38403:
URL: https://github.com/apache/arrow/pull/38403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38403:
URL: https://github.com/apache/arrow/pull/38403#issuecomment-1780811235
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 99f893f41fa21da2a9d13240ec5f8301e0881dae.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/18076861097) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #38403:
URL: https://github.com/apache/arrow/pull/38403#issuecomment-1775440423
@kou @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38403:
URL: https://github.com/apache/arrow/pull/38403#issuecomment-1778380698
@tustvold Could you try this in apache/arrow-rs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38403:
URL: https://github.com/apache/arrow/pull/38403#discussion_r1369261579
##########
ci/scripts/integration_arrow.sh:
##########
@@ -20,11 +20,25 @@
set -ex
arrow_dir=${1}
+build_dir=${2}
Review Comment:
It seems that this isn't used. Do we need this?
##########
ci/scripts/integration_arrow_build.sh:
##########
@@ -0,0 +1,55 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -ex
+
+arrow_dir=${1}
+build_dir=${2}
+
+: ${ARROW_INTEGRATION_CPP:=ON}
+: ${ARROW_INTEGRATION_CSHARP:=ON}
+: ${ARROW_INTEGRATION_GO:=ON}
+: ${ARROW_INTEGRATION_JAVA:=ON}
+: ${ARROW_INTEGRATION_JS:=ON}
+
+${arrow_dir}/ci/scripts/rust_build.sh /arrow /build
Review Comment:
```suggestion
${arrow_dir}/ci/scripts/rust_build.sh ${arrow_dir} ${build_dir}
```
And other `/arrow` and `/build` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #38403:
URL: https://github.com/apache/arrow/pull/38403#discussion_r1371282813
##########
ci/scripts/integration_arrow.sh:
##########
@@ -34,11 +48,11 @@ time archery integration \
--run-c-data \
--run-ipc \
--run-flight \
- --with-cpp=1 \
- --with-csharp=1 \
- --with-java=1 \
- --with-js=1 \
- --with-go=1 \
+ --with-cpp=$([ "$ARROW_INTEGRATION_CPP" == "ON" ] && echo "1" || echo "0") \
+ --with-csharp=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" || echo "0") \
+ --with-go=$([ "$ARROW_INTEGRATION_GO" == "ON" ] && echo "1" || echo "0") \
+ --with-java=$([ "$ARROW_INTEGRATION_JAVA" == "ON" ] && echo "1" || echo "0") \
+ --with-js=$([ "$ARROW_INTEGRATION_JS" == "ON" ] && echo "1" || echo "0") \
Review Comment:
There's no with-rust currently. The `ARCHERY_INTEGRATION_WITH_RUST` environment variable is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #38403:
URL: https://github.com/apache/arrow/pull/38403#discussion_r1371289806
##########
ci/scripts/integration_arrow.sh:
##########
@@ -34,11 +48,11 @@ time archery integration \
--run-c-data \
--run-ipc \
--run-flight \
- --with-cpp=1 \
- --with-csharp=1 \
- --with-java=1 \
- --with-js=1 \
- --with-go=1 \
+ --with-cpp=$([ "$ARROW_INTEGRATION_CPP" == "ON" ] && echo "1" || echo "0") \
+ --with-csharp=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" || echo "0") \
+ --with-go=$([ "$ARROW_INTEGRATION_GO" == "ON" ] && echo "1" || echo "0") \
+ --with-java=$([ "$ARROW_INTEGRATION_JAVA" == "ON" ] && echo "1" || echo "0") \
+ --with-js=$([ "$ARROW_INTEGRATION_JS" == "ON" ] && echo "1" || echo "0") \
Review Comment:
Ahah... I don't know why we have both then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #38403:
URL: https://github.com/apache/arrow/pull/38403#discussion_r1371281630
##########
ci/scripts/integration_arrow.sh:
##########
@@ -34,11 +48,11 @@ time archery integration \
--run-c-data \
--run-ipc \
--run-flight \
- --with-cpp=1 \
- --with-csharp=1 \
- --with-java=1 \
- --with-js=1 \
- --with-go=1 \
+ --with-cpp=$([ "$ARROW_INTEGRATION_CPP" == "ON" ] && echo "1" || echo "0") \
+ --with-csharp=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" || echo "0") \
+ --with-go=$([ "$ARROW_INTEGRATION_GO" == "ON" ] && echo "1" || echo "0") \
+ --with-java=$([ "$ARROW_INTEGRATION_JAVA" == "ON" ] && echo "1" || echo "0") \
+ --with-js=$([ "$ARROW_INTEGRATION_JS" == "ON" ] && echo "1" || echo "0") \
Review Comment:
I think we need a with-rust here in order to use this in arrow-rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #38403:
URL: https://github.com/apache/arrow/pull/38403#discussion_r1371284227
##########
ci/scripts/integration_arrow.sh:
##########
@@ -34,11 +48,11 @@ time archery integration \
--run-c-data \
--run-ipc \
--run-flight \
- --with-cpp=1 \
- --with-csharp=1 \
- --with-java=1 \
- --with-js=1 \
- --with-go=1 \
+ --with-cpp=$([ "$ARROW_INTEGRATION_CPP" == "ON" ] && echo "1" || echo "0") \
+ --with-csharp=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" || echo "0") \
+ --with-go=$([ "$ARROW_INTEGRATION_GO" == "ON" ] && echo "1" || echo "0") \
+ --with-java=$([ "$ARROW_INTEGRATION_JAVA" == "ON" ] && echo "1" || echo "0") \
+ --with-js=$([ "$ARROW_INTEGRATION_JS" == "ON" ] && echo "1" || echo "0") \
Review Comment:
We're currently using it - https://github.com/apache/arrow-rs/blob/master/.github/workflows/integration.yml#L121
I'll give the env variable a go as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38402: [CI][Integration] Provide wrapper scripts for integration testing [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38403:
URL: https://github.com/apache/arrow/pull/38403#discussion_r1369263862
##########
ci/scripts/integration_arrow.sh:
##########
@@ -20,11 +20,25 @@
set -ex
arrow_dir=${1}
+build_dir=${2}
Review Comment:
Ah, existing callers pass this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org