You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/03/03 05:28:18 UTC
[kudu-CR] subprocess: plumb Java metrics into C++
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15344
Change subject: subprocess: plumb Java metrics into C++
......................................................................
subprocess: plumb Java metrics into C++
This plumbs metrics from the Java subprocess into C++ and encapsulates
common code used to interact with a SubprocessServer bits (including the
metrics parsing) into the new SubprossProxy template class.
This template is specialized for Echo{Request,Response}PB messages as
the new EchoSubprocess.
Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
---
M src/kudu/subprocess/CMakeLists.txt
A src/kudu/subprocess/echo_subprocess.h
A src/kudu/subprocess/subprocess_proxy-test.cc
A src/kudu/subprocess/subprocess_proxy.h
4 files changed, 291 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/15344/1
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15344
to look at the new patch set (#2).
Change subject: subprocess: plumb Java metrics into C++
......................................................................
subprocess: plumb Java metrics into C++
This plumbs metrics from the Java subprocess into C++ and encapsulates
common code used to interact with a SubprocessServer bits (including the
metrics parsing) into the new SubprossProxy template class.
This template is specialized for Echo{Request,Response}PB messages as
the new test-only EchoSubprocess, and adds echo-specific histogram
metrics based on those returned by the Echo Java subprocess.
Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
---
M src/kudu/subprocess/CMakeLists.txt
A src/kudu/subprocess/subprocess_proxy-test.cc
A src/kudu/subprocess/subprocess_proxy.h
3 files changed, 269 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/15344/2
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15344 )
Change subject: subprocess: plumb Java metrics into C++
......................................................................
subprocess: plumb Java metrics into C++
This plumbs metrics from the Java subprocess into C++ and encapsulates
common code used to interact with a SubprocessServer bits (including the
metrics parsing) into the new SubprocessProxy template class.
This template is specialized for Echo{Request,Response}PB messages as
the new test-only EchoSubprocess, and adds echo-specific histogram
metrics based on those returned by the Echo Java subprocess.
Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Reviewed-on: http://gerrit.cloudera.org:8080/15344
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/subprocess/CMakeLists.txt
A src/kudu/subprocess/subprocess_proxy-test.cc
A src/kudu/subprocess/subprocess_proxy.h
3 files changed, 270 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Hao Hao: Looks good to me, approved
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15344 )
Change subject: subprocess: plumb Java metrics into C++
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Thanks for the patch! Just some nits. And the IWYU error needs to be addressed.
http://gerrit.cloudera.org:8080/#/c/15344/3/src/kudu/subprocess/subprocess_proxy.h
File src/kudu/subprocess/subprocess_proxy.h:
http://gerrit.cloudera.org:8080/#/c/15344/3/src/kudu/subprocess/subprocess_proxy.h@45
PS3, Line 45: class SubprocessProxy
nit: Can you add a description for this class?
http://gerrit.cloudera.org:8080/#/c/15344/3/src/kudu/subprocess/subprocess_proxy.h@66
PS3, Line 66: (""
We don't need to add any information about this error here?
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 03 Mar 2020 21:12:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15344
to look at the new patch set (#5).
Change subject: subprocess: plumb Java metrics into C++
......................................................................
subprocess: plumb Java metrics into C++
This plumbs metrics from the Java subprocess into C++ and encapsulates
common code used to interact with a SubprocessServer bits (including the
metrics parsing) into the new SubprocessProxy template class.
This template is specialized for Echo{Request,Response}PB messages as
the new test-only EchoSubprocess, and adds echo-specific histogram
metrics based on those returned by the Echo Java subprocess.
Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
---
M src/kudu/subprocess/CMakeLists.txt
A src/kudu/subprocess/subprocess_proxy-test.cc
A src/kudu/subprocess/subprocess_proxy.h
3 files changed, 270 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/15344/5
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15344 )
Change subject: subprocess: plumb Java metrics into C++
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 04 Mar 2020 05:30:28 +0000
Gerrit-HasComments: No
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15344 )
Change subject: subprocess: plumb Java metrics into C++
......................................................................
Patch Set 4: Code-Review+1
+1 in case others want to take a look.
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 03 Mar 2020 21:31:26 +0000
Gerrit-HasComments: No
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15344 )
Change subject: subprocess: plumb Java metrics into C++
......................................................................
Patch Set 5: Code-Review+2
> Patch Set 4: Code-Review+1
>
> +1 in case others want to take a look.
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 03 Mar 2020 23:17:28 +0000
Gerrit-HasComments: No
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15344
to look at the new patch set (#4).
Change subject: subprocess: plumb Java metrics into C++
......................................................................
subprocess: plumb Java metrics into C++
This plumbs metrics from the Java subprocess into C++ and encapsulates
common code used to interact with a SubprocessServer bits (including the
metrics parsing) into the new SubprocessProxy template class.
This template is specialized for Echo{Request,Response}PB messages as
the new test-only EchoSubprocess, and adds echo-specific histogram
metrics based on those returned by the Echo Java subprocess.
Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
---
M src/kudu/subprocess/CMakeLists.txt
A src/kudu/subprocess/subprocess_proxy-test.cc
A src/kudu/subprocess/subprocess_proxy.h
3 files changed, 273 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/15344/4
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15344
to look at the new patch set (#3).
Change subject: subprocess: plumb Java metrics into C++
......................................................................
subprocess: plumb Java metrics into C++
This plumbs metrics from the Java subprocess into C++ and encapsulates
common code used to interact with a SubprocessServer bits (including the
metrics parsing) into the new SubprocessProxy template class.
This template is specialized for Echo{Request,Response}PB messages as
the new test-only EchoSubprocess, and adds echo-specific histogram
metrics based on those returned by the Echo Java subprocess.
Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
---
M src/kudu/subprocess/CMakeLists.txt
A src/kudu/subprocess/subprocess_proxy-test.cc
A src/kudu/subprocess/subprocess_proxy.h
3 files changed, 269 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/15344/3
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15344 )
Change subject: subprocess: plumb Java metrics into C++
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15344/3/src/kudu/subprocess/subprocess_proxy.h
File src/kudu/subprocess/subprocess_proxy.h:
http://gerrit.cloudera.org:8080/#/c/15344/3/src/kudu/subprocess/subprocess_proxy.h@45
PS3, Line 45: class SubprocessProxy
> nit: Can you add a description for this class?
Done
http://gerrit.cloudera.org:8080/#/c/15344/3/src/kudu/subprocess/subprocess_proxy.h@66
PS3, Line 66: (""
> We don't need to add any information about this error here?
Done
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 03 Mar 2020 21:23:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15344 )
Change subject: subprocess: plumb Java metrics into C++
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/15344/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15344/1//COMMIT_MSG@11
PS1, Line 11: SubprossProxy
> SubprocessProxy?
Done
http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/echo_subprocess.h
File src/kudu/subprocess/echo_subprocess.h:
PS1:
> Agreed with Tidy Bot: if this file is all metric definitions, why is it a h
Done
http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/echo_subprocess.h@58
PS1, Line 58:
:
> Don't want to use histograms for these?
Ah, yeah at first my rationale was that I thought gauges were more useful for understanding the state of the queue over time. But you're right that histograms track it at a more fine-grained level, especially when requests come in at a high rate.
http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/subprocess_proxy.h
File src/kudu/subprocess/subprocess_proxy.h:
http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/subprocess_proxy.h@60
PS1, Line 60: sreq.mutable_request()->PackFrom(req);
: SubprocessResponsePB sresp;
: RETURN_NOT_OK(server_.Execute(&sreq, &sresp));
> Could you do this instead?
Done
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 03 Mar 2020 20:32:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] subprocess: plumb Java metrics into C++
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15344 )
Change subject: subprocess: plumb Java metrics into C++
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/15344/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15344/1//COMMIT_MSG@11
PS1, Line 11: SubprossProxy
SubprocessProxy?
http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/echo_subprocess.h
File src/kudu/subprocess/echo_subprocess.h:
PS1:
Agreed with Tidy Bot: if this file is all metric definitions, why is it a header?
http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/echo_subprocess.h@58
PS1, Line 58: GINIT(inbound_queue_length, echo_subprocess_inbound_queue_length);
: GINIT(outbound_queue_length, echo_subprocess_outbound_queue_length);
Don't want to use histograms for these?
http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/subprocess_proxy.h
File src/kudu/subprocess/subprocess_proxy.h:
http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/subprocess_proxy.h@60
PS1, Line 60: std::unique_ptr<google::protobuf::Any> packed_req(new google::protobuf::Any);
: packed_req->PackFrom(req);
: sreq.set_allocated_request(packed_req.release());
Could you do this instead?
sreq.mutable_request()->PackFrom(req);
--
To view, visit http://gerrit.cloudera.org:8080/15344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2
Gerrit-Change-Number: 15344
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 03 Mar 2020 06:48:46 +0000
Gerrit-HasComments: Yes