You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Leif Hedstrom <zw...@apache.org> on 2013/05/11 16:38:19 UTC

Re: [2/2] git commit: TS-1889: refactor remap plugin request URL handling

On 5/10/13 11:40 PM, jpeach@apache.org wrote:
> TS-1889: refactor remap plugin request URL handling
>
> For (apparantly) historical reasons, the remap plugin support
> duplicated the request URL rewriting code. There's really no need for
> this, and it's actually harmful since we don't want the behavior
> to diverge due to the presence of a remap plugin.

This also changes the behavior of the chaining of plugins, as we 
discussed, right? I think it's worthwhile to add a note to the "Upgrade 
to v3.4" section on the wiki here, and also send something to users@ and 
dev@ ? The changes are good, but could potentially break some chaining 
of remap plugins if they depend on the old behavior of always applying 
the "ToUrl" between invocation of remap plugins when the previous one 
did not modify the request URL.

Cheers,

-- Leif


Re: [2/2] git commit: TS-1889: refactor remap plugin request URL handling

Posted by Leif Hedstrom <zw...@apache.org>.
On 5/11/13 1:24 PM, James Peach wrote:
> On May 11, 2013, at 7:38 AM, Leif Hedstrom <zw...@apache.org> wrote:
>
>> On 5/10/13 11:40 PM, jpeach@apache.org wrote:
>>> TS-1889: refactor remap plugin request URL handling
>>>
>>> For (apparantly) historical reasons, the remap plugin support
>>>
>>> to diverge due to the presence of a remap plugin.
>> This also changes the behavior of the chaining of plugins, as we discussed, right?
> No, I fixed that bug before committing. There should be no change on behaviour.

Ack.

>
>> I think it's worthwhile to add a note to the "Upgrade to v3.4" section on the wiki here, and also send something to users@ and dev@ ? The changes are good, but could potentially break some chaining of remap plugins if they depend on the old behavior of always applying the "ToUrl" between invocation of remap plugins when the previous one did not modify the request URL.
> I'd like to make this change in a separate commit. The new behaviour would be to not apply the ToUrl until after all plugins have been invoked. If a plugin rewrites the request URL, then the default rewrite would never take place.

+1.

-- Leif

Re: [2/2] git commit: TS-1889: refactor remap plugin request URL handling

Posted by James Peach <jp...@apache.org>.
On May 11, 2013, at 7:38 AM, Leif Hedstrom <zw...@apache.org> wrote:

> On 5/10/13 11:40 PM, jpeach@apache.org wrote:
>> TS-1889: refactor remap plugin request URL handling
>> 
>> For (apparantly) historical reasons, the remap plugin support
>> duplicated the request URL rewriting code. There's really no need for
>> this, and it's actually harmful since we don't want the behavior
>> to diverge due to the presence of a remap plugin.
> 
> This also changes the behavior of the chaining of plugins, as we discussed, right?

No, I fixed that bug before committing. There should be no change on behaviour.

> I think it's worthwhile to add a note to the "Upgrade to v3.4" section on the wiki here, and also send something to users@ and dev@ ? The changes are good, but could potentially break some chaining of remap plugins if they depend on the old behavior of always applying the "ToUrl" between invocation of remap plugins when the previous one did not modify the request URL.

I'd like to make this change in a separate commit. The new behaviour would be to not apply the ToUrl until after all plugins have been invoked. If a plugin rewrites the request URL, then the default rewrite would never take place.

> 
> Cheers,
> 
> -- Leif
>