You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/10 18:38:18 UTC
[GitHub] [incubator-superset] willbarrett opened a new pull request #9505:
(Reopened PR): Fix broken MultiLine chart
willbarrett opened a new pull request #9505: (Reopened PR): Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9505
### CATEGORY
Choose one
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
See https://github.com/apache/incubator-superset/pull/9497
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@villebro @dpgaspar @craig-rueda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull
request #9505: (Reopened PR): Fix broken MultiLine chart
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9505: (Reopened PR): Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9505#discussion_r407777757
##########
File path: superset/viz.py
##########
@@ -484,8 +485,8 @@ def get_df_payload(self, query_obj=None, **kwargs):
"form_data": self.form_data,
"is_cached": self._any_cache_key is not None,
"query": self.query,
- "from_dttm": self.from_dttm,
- "to_dttm": self.to_dttm,
+ "from_dttm": self.from_dttm if hasattr(self, "from_dttm") else None,
Review comment:
NIT: I think it may be better to init `self.from_dttm = None` in the constructor of `BaseViz`, initializing all the attrs that may get assigned in the lifecycle of the object there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett closed pull request #9505:
(Reopened PR): Fix broken MultiLine chart
Posted by GitBox <gi...@apache.org>.
willbarrett closed pull request #9505: (Reopened PR): Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9505:
(Reopened PR): Fix broken MultiLine chart
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9505: (Reopened PR): Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9505#issuecomment-613195925
Closing as Travis failing to report status is unrecoverable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull
request #9505: (Reopened PR): Fix broken MultiLine chart
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9505: (Reopened PR): Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9505#discussion_r407830904
##########
File path: superset/viz.py
##########
@@ -484,8 +485,8 @@ def get_df_payload(self, query_obj=None, **kwargs):
"form_data": self.form_data,
"is_cached": self._any_cache_key is not None,
"query": self.query,
- "from_dttm": self.from_dttm,
- "to_dttm": self.to_dttm,
+ "from_dttm": self.from_dttm if hasattr(self, "from_dttm") else None,
Review comment:
Nit accepted. I need to close + reopen this PR again anyway because Travis won't play nice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9505: (Reopened
PR): Fix broken MultiLine chart
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9505: (Reopened PR): Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9505#issuecomment-613063722
@willbarrett seems like this one also died. Let's try to reopen a third time, and if that doesn't work we'll just have to wait until we have the new CI workflow in place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org