[GitHub] [arrow-datafusion] izveigor commented on a diff in pull request #5884: feat: hyperbolic functions

["izveigor (via GitHub)" <gi...@apache.org>]

izveigor commented on code in PR #5884:
URL: https://github.com/apache/arrow-datafusion/pull/5884#discussion_r1160815930


##########
datafusion/core/tests/sql/expr.rs:
##########
@@ -683,6 +683,12 @@ async fn test_mathematical_expressions_with_null() -> Result<()> {
     test_expression!("asin(NULL)", "NULL");
     test_expression!("acos(NULL)", "NULL");
     test_expression!("atan(NULL)", "NULL");
+    test_expression!("sinh(NULL)", "NULL");

Review Comment:
   Yes, I didn’t test them, because there are not certain tests(or I miss them) for scalar mathematical functions. I think we should merge the changes and “Pi” implementation(for trigonometric functions) and after that finish PR #5887 with all scalar functions. What do you think, @alamb?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org