[jira] [Commented] (PHOENIX-3608) KeyRange interset should return EMPTY_RANGE when one of it is NULL_RANGE

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829297#comment-15829297 ] 

Hadoop QA commented on PHOENIX-3608:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12848212/PHOENIX-3608.patch
  against master branch at commit a675211909415ca376e432d25f8a8822aadf5712.
  ATTACHMENT ID: 12848212

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 43 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tx.TransactionIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/734//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/734//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/734//console

This message is automatically generated.

> KeyRange interset should return EMPTY_RANGE when one of it is NULL_RANGE
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-3608
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3608
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 4.10.0, 4.8.2
>
>         Attachments: PHOENIX-3608.patch
>
>
> Currently KeyRange.intersect(KeyRange range) returning EMPTY_RANGE only when the left side key range is null and right side is not null but we should return EMPTY_RANGE when any of the key range is null.
> {noformat}
>         if (this == IS_NULL_RANGE) {
>             if (range == IS_NULL_RANGE) {
>                  return IS_NULL_RANGE;
>             }
>              return EMPTY_RANGE;
>          }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)