You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/28 18:37:09 UTC
[GitHub] [arrow] lidavidm commented on pull request #13027: ARROW-16408: [C++] MINOR Adding support for DATE type in SQLite FlightSQL example
lidavidm commented on PR #13027:
URL: https://github.com/apache/arrow/pull/13027#issuecomment-1112537189
Thanks! Looks like clang-format wants some changes:
```diff
--- /arrow/cpp/src/arrow/flight/sql/example/sqlite_server.cc
+++ /arrow/cpp/src/arrow/flight/sql/example/sqlite_server.cc (after clang format)
@@ -206,8 +206,7 @@
return float64();
} else if (boost::iequals(sqlite_type, "BLOB")) {
return binary();
- } else if (boost::iequals(sqlite_type, "TEXT") ||
- boost::iequals(sqlite_type, "DATE") ||
+ } else if (boost::iequals(sqlite_type, "TEXT") || boost::iequals(sqlite_type, "DATE") ||
boost::istarts_with(sqlite_type, "char") ||
boost::istarts_with(sqlite_type, "varchar")) {
return utf8();
@@ -228,8 +227,7 @@
return SQLITE_FLOAT;
} else if (boost::iequals(sqlite_type, "BLOB")) {
return SQLITE_BLOB;
- } else if (boost::iequals(sqlite_type, "TEXT") ||
- boost::iequals(sqlite_type, "DATE") ||
+ } else if (boost::iequals(sqlite_type, "TEXT") || boost::iequals(sqlite_type, "DATE") ||
boost::istarts_with(sqlite_type, "char") ||
boost::istarts_with(sqlite_type, "varchar")) {
return SQLITE_TEXT;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org