You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/05/24 23:46:30 UTC

Re: Review Request 59186: Additional linux/capabilities isolator documentation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59186/
-----------------------------------------------------------

(Updated May 24, 2017, 11:46 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Bugs: MESOS-7477
    https://issues.apache.org/jira/browse/MESOS-7477


Repository: mesos


Description (updated)
-------

Linux capabilities are somewhat involved, so add some additional
exposition of how the linux/capabilites isolator handles them.


Diffs (updated)
-----

  docs/linux_capabilities.md b588aff6842a14bbf7ff5c35931cac61f9019805 


Diff: https://reviews.apache.org/r/59186/diff/3/

Changes: https://reviews.apache.org/r/59186/diff/2-3/


Testing
-------

None.


Thanks,

James Peach


Re: Review Request 59186: Additional linux/capabilities isolator documentation.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59186/#review177106
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59547, 59548, 59549, 59550, 59551, 59552, 59185, 59553, 59554, 59806, 59186]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 5, 2017, 5:29 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59186/
> -----------------------------------------------------------
> 
> (Updated June 5, 2017, 5:29 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7477
>     https://issues.apache.org/jira/browse/MESOS-7477
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Linux capabilities are somewhat involved, so add some additional
> exposition of how the linux/capabilites isolator handles them.
> 
> 
> Diffs
> -----
> 
>   docs/linux_capabilities.md b588aff6842a14bbf7ff5c35931cac61f9019805 
> 
> 
> Diff: https://reviews.apache.org/r/59186/diff/4/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Re: Review Request 59186: Additional linux/capabilities isolator documentation.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59186/#review176933
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59547, 59548, 59549, 59550, 59551, 59552, 59185, 59553, 59554, 59806, 59186]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On June 5, 2017, 5:29 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59186/
> -----------------------------------------------------------
> 
> (Updated June 5, 2017, 5:29 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7477
>     https://issues.apache.org/jira/browse/MESOS-7477
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Linux capabilities are somewhat involved, so add some additional
> exposition of how the linux/capabilites isolator handles them.
> 
> 
> Diffs
> -----
> 
>   docs/linux_capabilities.md b588aff6842a14bbf7ff5c35931cac61f9019805 
> 
> 
> Diff: https://reviews.apache.org/r/59186/diff/4/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Re: Review Request 59186: Additional linux/capabilities isolator documentation.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59186/#review177578
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On June 5, 2017, 5:29 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59186/
> -----------------------------------------------------------
> 
> (Updated June 5, 2017, 5:29 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7477
>     https://issues.apache.org/jira/browse/MESOS-7477
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Linux capabilities are somewhat involved, so add some additional
> exposition of how the linux/capabilites isolator handles them.
> 
> 
> Diffs
> -----
> 
>   docs/linux_capabilities.md b588aff6842a14bbf7ff5c35931cac61f9019805 
> 
> 
> Diff: https://reviews.apache.org/r/59186/diff/5/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Re: Review Request 59186: Additional linux/capabilities isolator documentation.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59186/#review177875
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59547, 59548, 59549, 59550, 59551, 59552, 59185, 59553, 59554, 59806, 59186]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 5, 2017, 10:29 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59186/
> -----------------------------------------------------------
> 
> (Updated June 5, 2017, 10:29 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7477
>     https://issues.apache.org/jira/browse/MESOS-7477
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Linux capabilities are somewhat involved, so add some additional
> exposition of how the linux/capabilites isolator handles them.
> 
> 
> Diffs
> -----
> 
>   docs/linux_capabilities.md b588aff6842a14bbf7ff5c35931cac61f9019805 
> 
> 
> Diff: https://reviews.apache.org/r/59186/diff/6/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Re: Review Request 59186: Additional linux/capabilities isolator documentation.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59186/#review177558
-----------------------------------------------------------



Bad review!

Reviews applied: [59186, 59806, 59554]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot Windows


On June 5, 2017, 5:29 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59186/
> -----------------------------------------------------------
> 
> (Updated June 5, 2017, 5:29 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7477
>     https://issues.apache.org/jira/browse/MESOS-7477
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Linux capabilities are somewhat involved, so add some additional
> exposition of how the linux/capabilites isolator handles them.
> 
> 
> Diffs
> -----
> 
>   docs/linux_capabilities.md b588aff6842a14bbf7ff5c35931cac61f9019805 
> 
> 
> Diff: https://reviews.apache.org/r/59186/diff/5/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Re: Review Request 59186: Additional linux/capabilities isolator documentation.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59186/
-----------------------------------------------------------

(Updated June 5, 2017, 5:29 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
-------

Rebased.


Bugs: MESOS-7477
    https://issues.apache.org/jira/browse/MESOS-7477


Repository: mesos


Description
-------

Linux capabilities are somewhat involved, so add some additional
exposition of how the linux/capabilites isolator handles them.


Diffs (updated)
-----

  docs/linux_capabilities.md b588aff6842a14bbf7ff5c35931cac61f9019805 


Diff: https://reviews.apache.org/r/59186/diff/4/

Changes: https://reviews.apache.org/r/59186/diff/3-4/


Testing
-------

None.


Thanks,

James Peach


Re: Review Request 59186: Additional linux/capabilities isolator documentation.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59186/#review176145
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59547, 59548, 59549, 59550, 59551, 59552, 59185, 59553, 59554, 59186]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On May 24, 2017, 4:46 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59186/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 4:46 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7477
>     https://issues.apache.org/jira/browse/MESOS-7477
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Linux capabilities are somewhat involved, so add some additional
> exposition of how the linux/capabilites isolator handles them.
> 
> 
> Diffs
> -----
> 
>   docs/linux_capabilities.md b588aff6842a14bbf7ff5c35931cac61f9019805 
> 
> 
> Diff: https://reviews.apache.org/r/59186/diff/3/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>