You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by dp...@apache.org on 2019/04/18 16:36:40 UTC
[ignite-teamcity-bot] branch master updated: Version update and
code format
This is an automated email from the ASF dual-hosted git repository.
dpavlov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite-teamcity-bot.git
The following commit(s) were added to refs/heads/master by this push:
new 79d73fc Version update and code format
79d73fc is described below
commit 79d73fc7488030767ea72e135c703aacc7ad99fd
Author: Dmitriy Pavlov <dp...@apache.org>
AuthorDate: Thu Apr 18 19:36:33 2019 +0300
Version update and code format
---
.../ci/web/model/CompactContributionKey.java | 3 +-
.../apache/ignite/ci/web/model/CompactVisa.java | 3 +-
.../ignite/ci/web/model/CompactVisaRequest.java | 3 +-
.../apache/ignite/ci/web/model/TcHelperUserUi.java | 5 +-
.../org/apache/ignite/ci/web/model/Version.java | 2 +-
.../java/org/apache/ignite/ci/web/model/Visa.java | 5 +-
.../apache/ignite/ci/web/model/VisaRequest.java | 9 ++--
.../web/model/current/BuildStatisticsSummary.java | 13 +++--
.../model/current/ChainAtServerCurrentStatus.java | 28 ++++++----
.../ci/web/model/current/SuiteCurrentStatus.java | 33 ++++++------
.../ignite/ci/web/model/current/TestFailure.java | 16 +++---
.../ignite/ci/web/model/current/UpdateInfo.java | 4 +-
.../ignite/ci/web/model/hist/BuildsHistory.java | 59 +++++++++++-----------
.../ci/web/model/hist/VisasHistoryStorage.java | 9 ++--
14 files changed, 97 insertions(+), 95 deletions(-)
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactContributionKey.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactContributionKey.java
index 3cc8814..c838c52 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactContributionKey.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactContributionKey.java
@@ -21,8 +21,7 @@ import java.util.Objects;
import org.apache.ignite.ci.teamcity.ignited.IStringCompactor;
/**
- * Representation of {@link ContributionKey} with compacted properties for more
- * effective cache storing.
+ * Representation of {@link ContributionKey} with compacted properties for more effective cache storing.
*/
public class CompactContributionKey {
/** */
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactVisa.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactVisa.java
index 98dac46..9b2c957 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactVisa.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactVisa.java
@@ -21,8 +21,7 @@ import org.apache.ignite.ci.teamcity.ignited.IStringCompactor;
import org.jetbrains.annotations.Nullable;
/**
- * Representation of {@link Visa} with compacted properties for more
- * effective cache storing.
+ * Representation of {@link Visa} with compacted properties for more effective cache storing.
*/
public class CompactVisa {
/** */
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactVisaRequest.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactVisaRequest.java
index bf5b896..5c85e76 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactVisaRequest.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/CompactVisaRequest.java
@@ -21,8 +21,7 @@ import org.apache.ignite.ci.observer.CompactBuildsInfo;
import org.apache.ignite.ci.teamcity.ignited.IStringCompactor;
/**
- * Representation of {@link CompactVisaRequest} with compacted properties for more
- * effective cache storing.
+ * Representation of {@link CompactVisaRequest} with compacted properties for more effective cache storing.
*/
public class CompactVisaRequest {
/** */
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/TcHelperUserUi.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/TcHelperUserUi.java
index d236e6c..ccd341e 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/TcHelperUserUi.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/TcHelperUserUi.java
@@ -17,13 +17,12 @@
package org.apache.ignite.ci.web.model;
+import java.util.ArrayList;
+import java.util.List;
import java.util.Map;
import java.util.TreeMap;
import org.apache.ignite.ci.user.TcHelperUser;
-import java.util.ArrayList;
-import java.util.List;
-
@SuppressWarnings("weakerAccess")
public class TcHelperUserUi {
public final String login;
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/Version.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/Version.java
index e0e6a24..4662879 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/Version.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/Version.java
@@ -28,7 +28,7 @@ package org.apache.ignite.ci.web.model;
public static final String GITHUB_REF = "https://github.com/apache/ignite-teamcity-bot";
/** TC Bot Version. */
- public static final String VERSION = "20190413";
+ public static final String VERSION = "20190418";
/** Java version, where Web App is running. */
public String javaVer;
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/Visa.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/Visa.java
index 201db9b..43f3efb 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/Visa.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/Visa.java
@@ -20,9 +20,8 @@ package org.apache.ignite.ci.web.model;
import org.jetbrains.annotations.Nullable;
/**
- * Representation of TC Bot visa - comment in apache Jira ticket conversation
- * which shows a list of tests which probably failed because of committed
- * changes(blockers) based on TC Run-All results.
+ * Representation of TC Bot visa - comment in apache Jira ticket conversation which shows a list of tests which probably
+ * failed because of committed changes(blockers) based on TC Run-All results.
*/
public class Visa {
/** Determines Visa with no results and info. */
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/VisaRequest.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/VisaRequest.java
index 7dffdc6..03ba00a 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/VisaRequest.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/VisaRequest.java
@@ -21,9 +21,8 @@ import org.apache.ignite.ci.observer.BuildsInfo;
import org.jetbrains.annotations.Nullable;
/**
- * Representation of visa request from TC Bot. Visa request can be with
- * additional builds to rerun and without them. So it is used for tracking
- * rerunned builds status and storing resulting visa.
+ * Representation of visa request from TC Bot. Visa request can be with additional builds to rerun and without them. So
+ * it is used for tracking rerunned builds status and storing resulting visa.
*/
public class VisaRequest {
/** Common information to determine visa request */
@@ -33,8 +32,8 @@ public class VisaRequest {
private Visa visa;
/**
- * Flag which is used to show that some outer services monitor the status
- * of rerunned builds which are not finished yet.
+ * Flag which is used to show that some outer services monitor the status of rerunned builds which are not finished
+ * yet.
*/
private boolean isObserving;
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/BuildStatisticsSummary.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/BuildStatisticsSummary.java
index 1ab8cf9..965cc36 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/BuildStatisticsSummary.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/BuildStatisticsSummary.java
@@ -38,7 +38,10 @@ import org.apache.ignite.ci.teamcity.ignited.fatbuild.FatBuildCompacted;
import org.apache.ignite.ci.teamcity.ignited.fatbuild.ProblemCompacted;
import org.apache.ignite.internal.util.typedef.T2;
-import static org.apache.ignite.ci.tcmodel.result.problems.ProblemOccurrence.*;
+import static org.apache.ignite.ci.tcmodel.result.problems.ProblemOccurrence.TC_EXECUTION_TIMEOUT;
+import static org.apache.ignite.ci.tcmodel.result.problems.ProblemOccurrence.TC_EXIT_CODE;
+import static org.apache.ignite.ci.tcmodel.result.problems.ProblemOccurrence.TC_JVM_CRASH;
+import static org.apache.ignite.ci.tcmodel.result.problems.ProblemOccurrence.TC_OOME;
/**
* Summary of build statistics.
@@ -84,8 +87,10 @@ public class BuildStatisticsSummary {
/** Is fake stub. */
public boolean isFakeStub;
- /** Failed tests: Map from build type string ID ->
- * Map of test name (full) string ID -> (test refrenence, to count of failures). */
+ /**
+ * Failed tests: Map from build type string ID -> Map of test name (full) string ID -> (test refrenence, to count of
+ * failures).
+ */
private Map<Integer, Map<Integer, T2<Long, Integer>>> failedTests = new HashMap<>();
/** Is valid. */
@@ -176,6 +181,7 @@ public class BuildStatisticsSummary {
return snapshotDependencies;
}
+
/**
* Builds without status "Success".
*/
@@ -187,6 +193,7 @@ public class BuildStatisticsSummary {
/**
* BuildType problems count (EXECUTION TIMEOUT, JVM CRASH, OOMe, EXIT CODE, TOTAL PROBLEMS COUNT).
+ *
* @param problems
*/
public Map<String, Long> getBuildTypeProblemsCount(
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/ChainAtServerCurrentStatus.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/ChainAtServerCurrentStatus.java
index 46bcc95..2267444 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/ChainAtServerCurrentStatus.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/ChainAtServerCurrentStatus.java
@@ -18,6 +18,13 @@
package org.apache.ignite.ci.web.model.current;
import com.google.common.base.Strings;
+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.stream.Stream;
+import javax.annotation.Nullable;
import org.apache.ignite.ci.analysis.FullChainRunCtx;
import org.apache.ignite.ci.analysis.IMultTestOccurrence;
import org.apache.ignite.ci.analysis.MultBuildRunCtx;
@@ -31,12 +38,10 @@ import org.apache.ignite.ci.teamcity.ignited.ITeamcityIgnited;
import org.apache.ignite.ci.util.CollectionUtil;
import org.apache.ignite.internal.util.typedef.T2;
-import javax.annotation.Nullable;
-import java.util.*;
-import java.util.stream.Stream;
-
import static org.apache.ignite.ci.util.UrlUtil.escape;
-import static org.apache.ignite.ci.web.model.current.SuiteCurrentStatus.*;
+import static org.apache.ignite.ci.web.model.current.SuiteCurrentStatus.branchForLink;
+import static org.apache.ignite.ci.web.model.current.SuiteCurrentStatus.createOccurForLogConsumer;
+import static org.apache.ignite.ci.web.model.current.SuiteCurrentStatus.createOrrucForLongRun;
/**
* Represent Run All chain results/ or RunAll+latest re-runs.
@@ -118,16 +123,17 @@ public class ChainAtServerCurrentStatus {
/** */
public void initJiraAndGitInfo(BranchTicketMatcher ticketMatcher,
- IJiraIgnited jiraIntegration,
- IGitHubConnIgnited gitHubConnIgnited) {
+ IJiraIgnited jiraIntegration,
+ IGitHubConnIgnited gitHubConnIgnited) {
String ticketFullName = null;
try {
ticketFullName = ticketMatcher
- .resolveTicketFromBranch(jiraIntegration.config().getCode(),
- null,
- branchName);
- } catch (BranchTicketMatcher.TicketNotFoundException ignore) {
+ .resolveTicketFromBranch(jiraIntegration.config().getCode(),
+ null,
+ branchName);
+ }
+ catch (BranchTicketMatcher.TicketNotFoundException ignore) {
}
Integer prNum = IGitHubConnection.convertBranchToPrId(branchName);
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/SuiteCurrentStatus.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/SuiteCurrentStatus.java
index 530c7d6..19b87c4 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/SuiteCurrentStatus.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/SuiteCurrentStatus.java
@@ -28,7 +28,6 @@ import java.util.function.Function;
import java.util.stream.Collectors;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
-
import org.apache.ignite.ci.ITeamcity;
import org.apache.ignite.ci.analysis.IMultTestOccurrence;
import org.apache.ignite.ci.analysis.MultBuildRunCtx;
@@ -57,7 +56,7 @@ import static org.apache.ignite.ci.util.UrlUtil.escape;
/** Suite Run Result (filled if failed): Summary of build problems, count of tests, etc. */
public String result;
- /** Has critical problem: Timeout, JMV Crash, Compilation Error or Failure on Metric*/
+ /** Has critical problem: Timeout, JMV Crash, Compilation Error or Failure on Metric */
@Nullable public Boolean hasCriticalProblem;
/** Web Href. to suite runs history */
@@ -112,7 +111,6 @@ import static org.apache.ignite.ci.util.UrlUtil.escape;
/** Timed out builds average time. */
public String lostInTimeouts;
-
/**
* Advisory mark there is problem in this suite.
*/
@@ -122,8 +120,8 @@ import static org.apache.ignite.ci.util.UrlUtil.escape;
public Boolean possibleBlocker;
public void initFromContext(ITeamcityIgnited tcIgnited,
- @Nonnull final MultBuildRunCtx suite,
- @Nullable final String baseBranch) {
+ @Nonnull final MultBuildRunCtx suite,
+ @Nullable final String baseBranch) {
name = suite.suiteName();
@@ -143,7 +141,7 @@ import static org.apache.ignite.ci.util.UrlUtil.escape;
hasCriticalProblem = suite.hasCriticalProblem();
failedTests = suite.failedTests();
durationPrintable = millisToDurationPrintable(suite.getBuildDuration());
- testsDurationPrintable = millisToDurationPrintable(suite.getAvgTestsDuration());
+ testsDurationPrintable = millisToDurationPrintable(suite.getAvgTestsDuration());
webToHist = buildWebLink(tcIgnited, suite);
webToHistBaseBranch = buildWebLink(tcIgnited, suite, baseBranch);
webToBuild = buildWebLinkToBuild(tcIgnited, suite);
@@ -169,7 +167,7 @@ import static org.apache.ignite.ci.util.UrlUtil.escape;
suite.getTopLongRunning().forEach(occurrence -> {
final TestFailure failure = createOrrucForLongRun(tcIgnited, suite,
- occurrence, baseBranch);
+ occurrence, baseBranch);
topLongRunning.add(failure);
});
@@ -213,10 +211,10 @@ import static org.apache.ignite.ci.util.UrlUtil.escape;
}
private void initSuiteStat(ITeamcityIgnited tcIgnited,
- String failRateNormalizedBranch,
- String curBranchNormalized,
- String suiteId) {
- if (Strings.isNullOrEmpty(suiteId) )
+ String failRateNormalizedBranch,
+ String curBranchNormalized,
+ String suiteId) {
+ if (Strings.isNullOrEmpty(suiteId))
return;
SuiteInBranch key = new SuiteInBranch(suiteId, failRateNormalizedBranch);
@@ -247,7 +245,8 @@ import static org.apache.ignite.ci.util.UrlUtil.escape;
latestRunsSrc = statForStripe;
latestRuns = statForStripe != null ? statForStripe.getLatestRunResults() : null;
- } else
+ }
+ else
latestRunsSrc = stat;
if (latestRunsSrc != null) {
@@ -268,16 +267,16 @@ import static org.apache.ignite.ci.util.UrlUtil.escape;
}
@NotNull public static TestFailure createOrrucForLongRun(ITeamcityIgnited tcIgnited,
- @Nonnull MultBuildRunCtx suite,
- final IMultTestOccurrence occurrence,
- @Nullable final String failRateBranch) {
+ @Nonnull MultBuildRunCtx suite,
+ final IMultTestOccurrence occurrence,
+ @Nullable final String failRateBranch) {
final TestFailure failure = new TestFailure();
failure.initFromOccurrence(occurrence, tcIgnited, suite.projectId(), suite.branchName(), failRateBranch);
failure.initStat(tcIgnited,
- normalizeBranch(failRateBranch),
- normalizeBranch(suite.branchName()));
+ normalizeBranch(failRateBranch),
+ normalizeBranch(suite.branchName()));
return failure;
}
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
index a99deb4..ba3a025 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
@@ -54,8 +54,8 @@ import static org.apache.ignite.ci.web.model.current.SuiteCurrentStatus.branchFo
@Nullable public String testName;
/**
- * Current filtered failures count, Usually 1 for get current (latest),
- * may indicate several failures for history (merged recent runs).
+ * Current filtered failures count, Usually 1 for get current (latest), may indicate several failures for history
+ * (merged recent runs).
*/
public Integer curFailures;
@@ -85,7 +85,6 @@ import static org.apache.ignite.ci.web.model.current.SuiteCurrentStatus.branchFo
*/
@NotNull public TestHistory histBaseBranch = new TestHistory();
-
/** Link to test history for current branch. */
@Nullable public String webUrlBaseBranch;
@@ -192,8 +191,8 @@ import static org.apache.ignite.ci.web.model.current.SuiteCurrentStatus.branchFo
* @param curBranchNormalized Cur branch normalized.
*/
public void initStat(ITeamcityIgnited tcIgnited,
- String failRateNormalizedBranch,
- String curBranchNormalized) {
+ String failRateNormalizedBranch,
+ String curBranchNormalized) {
TestInBranch testInBranch = new TestInBranch(name, failRateNormalizedBranch);
@@ -208,12 +207,13 @@ import static org.apache.ignite.ci.web.model.current.SuiteCurrentStatus.branchFo
statForProblemsDetection = tcIgnited.getTestRunHist(testInBranchS);
- if(statForProblemsDetection!=null) {
+ if (statForProblemsDetection != null) {
histCurBranch = new TestHistory();
histCurBranch.init(statForProblemsDetection);
}
- } else
+ }
+ else
statForProblemsDetection = stat;
if (statForProblemsDetection != null) {
@@ -276,6 +276,6 @@ import static org.apache.ignite.ci.web.model.current.SuiteCurrentStatus.branchFo
/** {@inheritDoc} */
@Override public String toString() {
- return "\t" + name + "\n";
+ return "\t" + name + "\n";
}
}
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/UpdateInfo.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/UpdateInfo.java
index 036fc87..2df1fd1 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/UpdateInfo.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/UpdateInfo.java
@@ -57,8 +57,8 @@ import org.apache.ignite.ci.jira.ignited.IJiraIgnited;
* @param jiraIntegration JIRA Integration
*/
public void setJavaFlags(IAnalyticsEnabledTeamcity teamcity,
- IGitHubConnIgnited gitHubConn,
- IJiraIgnited jiraIntegration) {
+ IGitHubConnIgnited gitHubConn,
+ IJiraIgnited jiraIntegration) {
if (teamcity.isTeamCityTokenAvailable())
javaFlags |= TEAMCITY_FLAG;
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/BuildsHistory.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/BuildsHistory.java
index 4c8b4e8..3534f8d 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/BuildsHistory.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/BuildsHistory.java
@@ -20,35 +20,38 @@ package org.apache.ignite.ci.web.model.hist;
import com.google.common.collect.Lists;
import com.google.inject.Inject;
import com.google.inject.Injector;
-import org.apache.ignite.ci.tcbot.trends.MasterTrendsService;
-import org.apache.ignite.ci.teamcity.ignited.BuildRefCompacted;
-import org.apache.ignite.ci.teamcity.ignited.IStringCompactor;
-import org.apache.ignite.ci.teamcity.ignited.ITeamcityIgnited;
-import org.apache.ignite.ci.teamcity.ignited.ITeamcityIgnitedProvider;
-import org.apache.ignite.ci.user.ICredentialsProv;
-import org.apache.ignite.ci.web.model.current.BuildStatisticsSummary;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
import java.io.UncheckedIOException;
import java.text.DateFormat;
import java.text.ParseException;
import java.text.SimpleDateFormat;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future;
import java.util.stream.Collectors;
+import org.apache.ignite.ci.tcbot.trends.MasterTrendsService;
+import org.apache.ignite.ci.teamcity.ignited.BuildRefCompacted;
+import org.apache.ignite.ci.teamcity.ignited.IStringCompactor;
+import org.apache.ignite.ci.teamcity.ignited.ITeamcityIgnited;
+import org.apache.ignite.ci.teamcity.ignited.ITeamcityIgnitedProvider;
+import org.apache.ignite.ci.user.ICredentialsProv;
+import org.apache.ignite.ci.web.model.current.BuildStatisticsSummary;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import static com.google.common.base.Strings.isNullOrEmpty;
/**
- * Presents statistic for all valid builds and merged failed unmuted tests in
- * specified time interval. Statistics and tests are stored in
- * {@link #buildsStatistics} and {@link #mergedTestsBySuites} properties
- * respectively. Builder pattern is used for instance creation.
- * Default values: <br>skipTests = false,<br>projectId="IgniteTests24Java8",
+ * Presents statistic for all valid builds and merged failed unmuted tests in specified time interval. Statistics and
+ * tests are stored in {@link #buildsStatistics} and {@link #mergedTestsBySuites} properties respectively. Builder
+ * pattern is used for instance creation. Default values: <br>skipTests = false,<br>projectId="IgniteTests24Java8",
* <br>srvId="apache", <br>buildTypeId="IgniteTests24Java8_RunAll",
* <br>branchName="refs/heads/master".
*/
@@ -91,10 +94,9 @@ public class BuildsHistory {
@Inject private IStringCompactor compactor;
-
/**
- * Initialize {@link #mergedTestsBySuites} and {@link #buildsStatistics}
- * properties using builds which satisfy properties setted by Builder.
+ * Initialize {@link #mergedTestsBySuites} and {@link #buildsStatistics} properties using builds which satisfy
+ * properties setted by Builder.
*
* @param prov Credentials.
*/
@@ -109,7 +111,7 @@ public class BuildsHistory {
.collect(Collectors.toList());
Map<Integer, Boolean> buildIdsWithConditions = finishedBuildsIds.stream()
- .collect(Collectors.toMap(v -> v, ignitedTeamcity::buildIsValid, (e1, e2) -> e1, LinkedHashMap::new));
+ .collect(Collectors.toMap(v -> v, ignitedTeamcity::buildIsValid, (e1, e2) -> e1, LinkedHashMap::new));
initStatistics(ignitedTeamcity, buildIdsWithConditions);
@@ -126,8 +128,8 @@ public class BuildsHistory {
}
/**
- * Initialize {@link #buildsStatistics} property with list of {@link BuildStatisticsSummary}
- * produced for each valid build.
+ * Initialize {@link #buildsStatistics} property with list of {@link BuildStatisticsSummary} produced for each valid
+ * build.
*
* @param ignited {@link ITeamcityIgnited} instance.
* @param buildIdsWithConditions Build ID -> build validation flag.
@@ -171,8 +173,8 @@ public class BuildsHistory {
}
/**
- * Initialize {@link #mergedTestsBySuites} property by unique failed tests
- * which occured in specified date interval.
+ * Initialize {@link #mergedTestsBySuites} property by unique failed tests which occured in specified date
+ * interval.
*
* @param buildIds list of valid builds.
* @param buildIdsWithConditions Build ID -> build validation flag.
@@ -182,7 +184,7 @@ public class BuildsHistory {
for (BuildStatisticsSummary buildStat : buildsStatistics) {
Boolean valid = buildIdsWithConditions.get(buildStat.buildId);
- if(!Boolean.TRUE.equals(valid))
+ if (!Boolean.TRUE.equals(valid))
continue;
buildStat.failedTests().forEach((btId, map) -> {
@@ -286,8 +288,7 @@ public class BuildsHistory {
}
/**
- * @param sinceDate left border of date interval form which builds
- * will be presented.
+ * @param sinceDate left border of date interval form which builds will be presented.
*/
public Builder sinceDate(String sinceDate) throws ParseException {
if (!isNullOrEmpty(sinceDate))
@@ -297,8 +298,7 @@ public class BuildsHistory {
}
/**
- * @param untilDate right border of date interval form which builds
- * will be presented.
+ * @param untilDate right border of date interval form which builds will be presented.
*/
public Builder untilDate(String untilDate) throws ParseException {
if (!isNullOrEmpty(untilDate))
@@ -314,7 +314,6 @@ public class BuildsHistory {
return this;
}
-
/**
* @param injector Guice instance for dependency injection.
*/
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/VisasHistoryStorage.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/VisasHistoryStorage.java
index ab864e5..46a0ef2 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/VisasHistoryStorage.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/VisasHistoryStorage.java
@@ -35,8 +35,8 @@ import org.apache.ignite.ci.web.model.ContributionKey;
import org.apache.ignite.ci.web.model.VisaRequest;
/**
- * Storage which contains {@link VisaRequest} identified by
- * {@link CompactContributionKey}, and stored in order of addition.
+ * Storage which contains {@link VisaRequest} identified by {@link CompactContributionKey}, and stored in order of
+ * addition.
*/
public class VisasHistoryStorage {
/** Cache name. */
@@ -86,7 +86,6 @@ public class VisasHistoryStorage {
/**
* @param key {@link ContributionKey} instance.
- *
* @return list of all {@link VisaRequest} for specified key.
*/
public List<VisaRequest> getVisaRequests(ContributionKey key) {
@@ -102,7 +101,6 @@ public class VisasHistoryStorage {
/**
* @param key {@link ContributionKey} instance.
- *
* @return Last added {@link VisaRequest} for specified key.
*/
public VisaRequest getLastVisaRequest(ContributionKey key) {
@@ -117,7 +115,6 @@ public class VisasHistoryStorage {
/**
* @param key {@link ContributionKey} instance.
* @param updater {@link Consumer<VisaRequest>} which will be applied to last Visa request for specified key.
- *
* @return <code>True</code> if specified key exists.
*/
public boolean updateLastVisaRequest(ContributionKey key, Consumer<VisaRequest> updater) {
@@ -161,7 +158,7 @@ public class VisasHistoryStorage {
}
/**
- * @return Collection of all {@link VisaRequest} for every stored key.
+ * @return Collection of all {@link VisaRequest} for every stored key.
*/
public Collection<VisaRequest> getVisas() {
List<VisaRequest> res = new ArrayList<>();