You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/08 16:52:17 UTC

[GitHub] [kafka] 0x1991babe opened a new pull request #10998: MINOR: fix quoted boolean in FetchRequest.json

0x1991babe opened a new pull request #10998:
URL: https://github.com/apache/kafka/pull/10998


   Hi, I'm working on maintaining an implementation of the protocol written in Rust: https://github.com/0x1991babe/kafka-protocol-rs. A recent change in 2b8aff58b5 breaks my deserialization logic for the `ignorable` field. I could work around this, but hope this minor change is acceptable. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on pull request #10998: MINOR: fix quoted boolean in FetchRequest.json

Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #10998:
URL: https://github.com/apache/kafka/pull/10998#issuecomment-877267730


   I think the test failures are unrelated. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac merged pull request #10998: MINOR: fix quoted boolean in FetchRequest.json

Posted by GitBox <gi...@apache.org>.
dajac merged pull request #10998:
URL: https://github.com/apache/kafka/pull/10998


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10998: MINOR: fix quoted boolean in FetchRequest.json

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10998:
URL: https://github.com/apache/kafka/pull/10998#issuecomment-877411273


   Indeed, failures are not related. I am going to merge it. @0x1991babe Thanks for the patch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] 0x1991babe commented on pull request #10998: MINOR: fix quoted boolean in FetchRequest.json

Posted by GitBox <gi...@apache.org>.
0x1991babe commented on pull request #10998:
URL: https://github.com/apache/kafka/pull/10998#issuecomment-877224007


   Thanks so much! Appreciate y'all. Test failures that nee to be remediated or just CI flakiness?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on pull request #10998: MINOR: fix quoted boolean in FetchRequest.json

Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #10998:
URL: https://github.com/apache/kafka/pull/10998#issuecomment-876625362


   Ah this should be fine. I don't think I should have put that in quotes in the first place. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org