You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "aparna0522 (via GitHub)" <gi...@apache.org> on 2025/10/29 17:29:52 UTC
Re: [PR] CEP-45: Unlogged batch support [cassandra]
aparna0522 commented on code in PR #4449:
URL: https://github.com/apache/cassandra/pull/4449#discussion_r2474347714
##########
src/java/org/apache/cassandra/service/StorageProxy.java:
##########
@@ -1555,15 +1585,15 @@ public static void mutateAtomically(List<Mutation> mutations,
else
writeMetrics.remoteRequests.mark();
- WriteResponseHandlerWrapper wrapper = wrapBatchResponseHandler(normalMutation,
+ WriteResponseHandlerWrapper wrapper = wrapBatchResponseHandler(untrackedMutation,
dataReplicaPlan,
batchConsistencyLevel,
WriteType.BATCH,
cleanup,
requestTime);
wrappers.add(wrapper);
};
- splitMutationsIntoAccordAndNormal(cm, mutations, splitConsumer);
+ ConsensusMigrationMutationHelper.splitMutations(cm, mutations, splitConsumer);
attributeNonAccordLatency = !wrappers.isEmpty();
cleanup.setMutationsWaitingFor(wrappers.size() + (accordMutations.isEmpty() ? 0 : 1));
Tracing.trace("Split batch into Accord {} and normal {}", accordMutations, wrappers);
Review Comment:
I was wondering if this should be `Tracing.trace("Split batch into Accord {} and untracked {}", accordMutations, wrappers);`
nit: Additionally we could rename wrappers as untrackedWrappers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org