You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by stepio <gi...@git.apache.org> on 2016/07/01 16:15:36 UTC

[GitHub] kafka pull request #1579: KAFKA-3923: Use Metric interface instead of final ...

GitHub user stepio opened a pull request:

    https://github.com/apache/kafka/pull/1579

    KAFKA-3923: Use Metric interface instead of final KafkaMetric in MetricsReporter and its implementations

    This is a patch for the previously highlighted issue:
    https://issues.apache.org/jira/browse/KAFKA-3923
    
    I'm minimised the scope of changes, so that now Metrics class is not affected and generics are introduced on the method level instead of class level.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stepio/kafka metrics_reporter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1579.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1579
    
----
commit 06841765707f40d553ab9c7ae635bfc67b7bb05d
Author: Igor Stepanov <st...@gmail.com>
Date:   2016-07-01T16:10:55Z

    KAFKA-3923: Use Metric interface instead of final KafkaMetric in MetricsReporter and its implementations
     - simplifies mocking of metrics for unit tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---