[GitHub] [sling-org-apache-sling-scripting-bundle-tracker-it] raducotescu commented on a change in pull request #5: SLING-11155: add a test to make sure we bind proxy resource type registrations by full path only

[GitBox <gi...@apache.org>]

raducotescu commented on a change in pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/pull/5#discussion_r824732078



##########
File path: it/src/test/java/org/apache/sling/scripting/bundle/tracker/it/ExampleBundleTeleportedIT.java
##########
@@ -28,6 +28,7 @@
 import org.apache.sling.api.resource.ResourceResolverFactory;
 import org.junit.Test;
 
+import static junit.framework.TestCase.assertFalse;

Review comment:
       Let's not mix JUnit versions.

##########
File path: it/src/test/java/org/apache/sling/scripting/bundle/tracker/it/ExampleBundleTeleportedIT.java
##########
@@ -114,4 +115,18 @@ public void testAppsHello() throws LoginException {
             }
         }
     }
+
+    @Test
+    public void testRt() throws LoginException {

Review comment:
       Shouldn't this test be in a different Test Suite? Either a new one or https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/blob/master/it/src/test/java/org/apache/sling/scripting/bundle/tracker/it/ExampleBundlePrecompiledIT.java?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org