You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Kristian Koehler (JIRA)" <ji...@apache.org> on 2007/10/02 18:06:24 UTC
[jira] Created: (SM-1082) Inconsistent exception handling in
ClientFactory
Inconsistent exception handling in ClientFactory
------------------------------------------------
Key: SM-1082
URL: https://issues.apache.org/activemq/browse/SM-1082
Project: ServiceMix
Issue Type: Bug
Components: servicemix-core
Reporter: Kristian Koehler
Attachments: servicemix-core.patch
Hi
the org/apache/servicemix/jbi/framework/ClientFactory includes exception handling code which is IMO not consistent. Within the start() method the factory tries to bind itself to a jndi context. If this fails an warning is logged.
Within the stop() the factory tries to unbind itself from jndi without checking if its registered properly.
I attached a patch where it is checked if the bind was successful. If not the stop method skips the unbind call.
Kristian
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1082) Inconsistent exception handling in
ClientFactory
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40253 ]
Guillaume Nodet commented on SM-1082:
-------------------------------------
Kristian, I don't see where the isFactoryJNDIregistered flag is set to true in this patch ...
> Inconsistent exception handling in ClientFactory
> ------------------------------------------------
>
> Key: SM-1082
> URL: https://issues.apache.org/activemq/browse/SM-1082
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-core
> Reporter: Kristian Koehler
> Fix For: 3.1.3, 3.2
>
> Attachments: servicemix-core.patch
>
>
> Hi
> the org/apache/servicemix/jbi/framework/ClientFactory includes exception handling code which is IMO not consistent. Within the start() method the factory tries to bind itself to a jndi context. If this fails an warning is logged.
> Within the stop() the factory tries to unbind itself from jndi without checking if its registered properly.
> I attached a patch where it is checked if the bind was successful. If not the stop method skips the unbind call.
> Kristian
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1082) Inconsistent exception handling in
ClientFactory
Posted by "Kristian Koehler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Koehler updated SM-1082:
---------------------------------
Attachment: servicemix-core.patch
Hi Guillaume
sorry for that. The attached patch includes the missing line...
Kristian
> Inconsistent exception handling in ClientFactory
> ------------------------------------------------
>
> Key: SM-1082
> URL: https://issues.apache.org/activemq/browse/SM-1082
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-core
> Reporter: Kristian Koehler
> Fix For: 3.1.3, 3.2
>
> Attachments: servicemix-core.patch, servicemix-core.patch
>
>
> Hi
> the org/apache/servicemix/jbi/framework/ClientFactory includes exception handling code which is IMO not consistent. Within the start() method the factory tries to bind itself to a jndi context. If this fails an warning is logged.
> Within the stop() the factory tries to unbind itself from jndi without checking if its registered properly.
> I attached a patch where it is checked if the bind was successful. If not the stop method skips the unbind call.
> Kristian
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1082) Inconsistent exception handling in
ClientFactory
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated SM-1082:
--------------------------------
Fix Version/s: 3.2
3.1.3
> Inconsistent exception handling in ClientFactory
> ------------------------------------------------
>
> Key: SM-1082
> URL: https://issues.apache.org/activemq/browse/SM-1082
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-core
> Reporter: Kristian Koehler
> Fix For: 3.1.3, 3.2
>
> Attachments: servicemix-core.patch
>
>
> Hi
> the org/apache/servicemix/jbi/framework/ClientFactory includes exception handling code which is IMO not consistent. Within the start() method the factory tries to bind itself to a jndi context. If this fails an warning is logged.
> Within the stop() the factory tries to unbind itself from jndi without checking if its registered properly.
> I attached a patch where it is checked if the bind was successful. If not the stop method skips the unbind call.
> Kristian
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SM-1082) Inconsistent exception handling in
ClientFactory
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved SM-1082.
---------------------------------
Resolution: Fixed
Assignee: Guillaume Nodet
Sending servicemix-core/src/main/java/org/apache/servicemix/jbi/framework/ClientFactory.java
Transmitting file data .
Committed revision 581827.
Sending servicemix-core/src/main/java/org/apache/servicemix/jbi/framework/ClientFactory.java
Transmitting file data .
Committed revision 581830.
> Inconsistent exception handling in ClientFactory
> ------------------------------------------------
>
> Key: SM-1082
> URL: https://issues.apache.org/activemq/browse/SM-1082
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-core
> Reporter: Kristian Koehler
> Assignee: Guillaume Nodet
> Fix For: 3.1.3, 3.2
>
> Attachments: servicemix-core.patch, servicemix-core.patch
>
>
> Hi
> the org/apache/servicemix/jbi/framework/ClientFactory includes exception handling code which is IMO not consistent. Within the start() method the factory tries to bind itself to a jndi context. If this fails an warning is logged.
> Within the stop() the factory tries to unbind itself from jndi without checking if its registered properly.
> I attached a patch where it is checked if the bind was successful. If not the stop method skips the unbind call.
> Kristian
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.