You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/20 04:30:52 UTC
[GitHub] [dolphinscheduler] guoshupei opened a new issue, #10506: [Improvement][Server] Refactor HeartBeatTask and HeartBeat
guoshupei opened a new issue, #10506:
URL: https://github.com/apache/dolphinscheduler/issues/10506
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
- Add parameter of `workerWaitingTaskCount` to constractor of `HeartBeat`
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #10506: [Improvement][Server] Refactor HeartBeatTask and HeartBeat
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #10506:
URL: https://github.com/apache/dolphinscheduler/issues/10506#issuecomment-1160009307
@ruanwenjun the dev branch, `workerWaitingTaskCount` of `HeartBeatTask` cannot be changed, it is a bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #10506: [Improvement][Server] Refactor HeartBeatTask and HeartBeat
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #10506:
URL: https://github.com/apache/dolphinscheduler/issues/10506#issuecomment-1160005582
>
> I hope we can split the `HeartBeatTask` into `MasterHeartBeatTask` and `WorkerHeartBeatTask`, we may have more heart beat info will be added into HeartBeat.
Okay, then I won't change it for now and not submit PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10506: [Improvement][Server] Refactor HeartBeatTask and HeartBeat
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10506:
URL: https://github.com/apache/dolphinscheduler/issues/10506#issuecomment-1159959694
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #10506: [Improvement][Server] Refactor HeartBeatTask and HeartBeat
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #10506:
URL: https://github.com/apache/dolphinscheduler/issues/10506#issuecomment-1159987296
I hope we can split the `HeartBeatTask` into `MasterHeartBeatTask` and `WorkerHeartBeatTask`, we may have more heart beat info will be added into HeartBeat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #10506: [Improvement][Server] Refactor HeartBeatTask and HeartBeat
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #10506:
URL: https://github.com/apache/dolphinscheduler/issues/10506#issuecomment-1160048664
> >
>
> > I hope we can split the `HeartBeatTask` into `MasterHeartBeatTask` and `WorkerHeartBeatTask`, we may have more heart beat info will be added into HeartBeat.
>
> Okay, then I won't change it for now and not submit PR.
You can submit PR to fix this, I just hope you can split the HeartBeatTask together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #10506: [Improvement][Server] Refactor HeartBeatTask and HeartBeat
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #10506:
URL: https://github.com/apache/dolphinscheduler/issues/10506#issuecomment-1160301314
> Hi @ruanwenjun ,I think add `MasterHeartBeat` and `WorkerHeartBeat` to extends `HeartBeat` is better, the `HeartBeatTask` is only responsible for executing different `HeartBeat`. what do you think?
Yes, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #10506: [Improvement][Server] Refactor HeartBeatTask and HeartBeat
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #10506:
URL: https://github.com/apache/dolphinscheduler/issues/10506#issuecomment-1160218012
Hi @ruanwenjun ,I think add `MasterHeartBeat` and `WorkerHeartBeat` to extends `HeartBeat` is better, the `HeartBeatTask` is only responsible for executing different `HeartBeat`. what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #10506: [Improvement][Server] Refactor HeartBeatTask and HeartBeat
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #10506:
URL: https://github.com/apache/dolphinscheduler/issues/10506#issuecomment-1160051456
got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org