You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/07/28 01:28:45 UTC
[GitHub] [drill] paul-rogers opened a new pull request #1830: DRILL-7333:
Set container record count where missing
paul-rogers opened a new pull request #1830: DRILL-7333: Set container record count where missing
URL: https://github.com/apache/drill/pull/1830
Many operators fail to set the container record count. See DRILL-7333
for details. This commit fixes a large number of operators. Replaces
blocks of copy/paste code to set the container vector value count with
a call to a single function that does the work. That function also
sets the count for the container as a whole, something that many
operators failed to do, causing hard-to-find errors downstream.
Tests: reran all unit tests. A new unit test, to verify that the
count is set, will come in a later commit once all fixes are made.
Also contains code cleanup for items noticed while finding the container count issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services