You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/11/08 15:44:04 UTC
[GitHub] [drill] dzamo opened a new pull request #2366: DRILL-8040: Add HTTP status codes for API errors
dzamo opened a new pull request #2366:
URL: https://github.com/apache/drill/pull/2366
# [DRILL-8040](https://issues.apache.org/jira/browse/DRILL-8040): Return an HTTP error code from failed REST API operations
(Please replace `PR Title` with actual PR Title)
## Description
Multiple REST API operations, notably affecting storage config operations, return an error message with an HTTP status code of 200 when an operation fails. The web UI depends on this behaviour in some places. REST clients should receive an HTTP error code instead.
There are some subtleties. Submitting a new query than later goes on to fail in execution still sees a 200 returned for the query submission. The storage plugin store does not raise an error if you try to delete something that it does not contain, so deleting something nonexistent is still a 200.
## Documentation
Add a note indicating that failed operations will generally result in an HTTP error code.
## Testing
- Existing test coverage.
- Send invalid requests to the REST API and check HTTP response code
- Use all pages of the web UI to test that normal functionality is still working, while monitoring XHR requests made from the browser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo merged pull request #2366: DRILL-8040: Add HTTP status codes for API errors
Posted by GitBox <gi...@apache.org>.
dzamo merged pull request #2366:
URL: https://github.com/apache/drill/pull/2366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] lgtm-com[bot] commented on pull request #2366: DRILL-8040: Add HTTP status codes for API errors
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #2366:
URL: https://github.com/apache/drill/pull/2366#issuecomment-963373743
This pull request **introduces 1 alert** when merging 9b5a0cc63503e140d2b36fa9e16b66c28667296c into 52838ef26e5e3e6b4461c2c656ffada0c64c9e88 - [view on LGTM.com](https://lgtm.com/projects/g/apache/drill/rev/pr-7458e6af2f7dcfa4289a1152701f63b63c4e7fed)
**new alerts:**
* 1 for Unused format argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org