You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/15 13:55:49 UTC
[GitHub] [superset] mdeshmu opened a new issue, #20724: Export full CSV downloads only first page with pagination enabled on table chart
mdeshmu opened a new issue, #20724:
URL: https://github.com/apache/superset/issues/20724
When multiple pages are present in a table chart and user clicks on Export full CSV, only the data from first page is getting exported in CSV.
#### How to reproduce the bug
1. Go to 'Dashboard'
2. Click on 'Export full CSV' on a table chart
3. A zip should be downloaded
4. Analyze csv file to see only first page of the table downloaded
### Expected results
CSV file with entries from all pages should get downloaded.
### Actual results
CSV file with entries of first page getting downloaded
#### Screenshots
### Environment
(please complete the following information):
- browser type and version: Chrome Version 103.0.5060.114 (Official Build) (64-bit)
- superset version: 1.5.1
- python version: 3.8.12
- node.js version:
- any feature flags active:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1415875274
@LahmerIlyas ping! cc: @rusackas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
Posted by GitBox <gi...@apache.org>.
mdeshmu commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1186502683
@LahmerIlyas can you please create a PR for this one just like we discussed in [17861](https://github.com/apache/superset/issues/17861)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Export full CSV downloads only first page with pagination enabled on table chart [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1959916110
Closing this one as stale. Related to #17861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Export full CSV downloads only first page with pagination enabled on table chart [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido closed issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
URL: https://github.com/apache/superset/issues/20724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hzdx943 commented on issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
Posted by "hzdx943 (via GitHub)" <gi...@apache.org>.
hzdx943 commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1573451944
> @mdeshmu sorry for taking too long on this. I created a PR for a fix for the issue. You can see it here: #23554
@LahmerIlyas hi,After applying this modification,I have encountered a new problem,The data refreshed after clicking on the page number will always be the data from the first page！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] LahmerIlyas commented on issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
Posted by "LahmerIlyas (via GitHub)" <gi...@apache.org>.
LahmerIlyas commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1493559369
@geido Can we get a review for my PR please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
Posted by GitBox <gi...@apache.org>.
mdeshmu commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1246152556
@LahmerIlyas did you get time to look into this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1509498252
I just came across this issue and PR again. Maybe I'm taking crazy pills, but I couldn't get reproduce this issue on current master. Is it still a problem on `master` or did some other PR resolve it in some other way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] LahmerIlyas commented on issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
Posted by "LahmerIlyas (via GitHub)" <gi...@apache.org>.
LahmerIlyas commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1493558646
@mdeshmu sorry for taking too long on this. I created a PR for a fix for the issue. You can see it here: https://github.com/apache/superset/pull/23554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hzdx943 commented on issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
Posted by "hzdx943 (via GitHub)" <gi...@apache.org>.
hzdx943 commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1569963054
> @mdeshmu sorry for taking too long on this. I created a PR for a fix for the issue. You can see it here: #23554
@LahmerIlyas hi，I hava same issues, I modified the local code according to #23554,and enable ALLOW_FULL_CSV_EXPORT flag,I exported all the data when I used Export FULL CSV and Export CSV,The value of variable formDataCopy.result_type is full.
Is this a normal result? Thanks you~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] LahmerIlyas commented on issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
Posted by GitBox <gi...@apache.org>.
LahmerIlyas commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1186512652
@mdeshmu I would be glad to help with a solution to this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] LahmerIlyas commented on issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
Posted by "LahmerIlyas (via GitHub)" <gi...@apache.org>.
LahmerIlyas commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1509546380
> I just came across this issue and PR again. Maybe I'm taking crazy pills, but I couldn't get reproduce this issue on the current master. Is it still a problem on `master` or did some other PR resolve it in some other way?
@rusackas Thanks for testing. I just managed to reproduce it on the master branch. Here is a recording:
[USA-Births-Names.webm](https://user-images.githubusercontent.com/31275446/232185651-dd10092d-51f1-4a39-b700-ff214b636b32.webm)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on issue #20724: Export full CSV downloads only first page with pagination enabled on table chart
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on issue #20724:
URL: https://github.com/apache/superset/issues/20724#issuecomment-1494795629
Thanks @LahmerIlyas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org