You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aurora.apache.org by zm...@apache.org on 2016/03/22 21:41:32 UTC
aurora git commit: Revert "Add support for storing and fetching
images as properties of task configs."
Repository: aurora
Updated Branches:
refs/heads/master d5d7ec0eb -> b5c9e1bc4
Revert "Add support for storing and fetching images as properties of task configs."
This reverts commit d5d7ec0eb5703d6bda8c43cd0586684a550a575a. As outlined in
`AURORA-1648` the schema changes here are not necessarily reflected in H2 after
a restore from backup.
Bugs closed: AURORA-1648
Reviewed at https://reviews.apache.org/r/45178/
Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/b5c9e1bc
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/b5c9e1bc
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/b5c9e1bc
Branch: refs/heads/master
Commit: b5c9e1bc46a623b5d898ec4dacbe132b79903dd7
Parents: d5d7ec0
Author: Zameer Manji <zm...@apache.org>
Authored: Tue Mar 22 13:41:07 2016 -0700
Committer: Zameer Manji <zm...@apache.org>
Committed: Tue Mar 22 13:41:07 2016 -0700
----------------------------------------------------------------------
.../thrift/org/apache/aurora/gen/api.thrift | 27 ------------
.../configuration/ConfigurationManager.java | 10 -----
.../scheduler/storage/db/TaskConfigManager.java | 27 +-----------
.../scheduler/storage/db/TaskConfigMapper.java | 24 -----------
.../scheduler/storage/db/views/DbImage.java | 38 -----------------
.../storage/db/views/DbTaskConfig.java | 2 -
.../scheduler/storage/db/TaskConfigMapper.xml | 44 --------------------
.../aurora/scheduler/storage/db/schema.sql | 18 --------
.../configuration/ConfigurationManagerTest.java | 27 ------------
.../storage/AbstractCronJobStoreTest.java | 3 +-
.../storage/AbstractTaskStoreTest.java | 34 +--------------
.../storage/db/DbJobUpdateStoreTest.java | 7 +---
12 files changed, 5 insertions(+), 256 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/api/src/main/thrift/org/apache/aurora/gen/api.thrift
----------------------------------------------------------------------
diff --git a/api/src/main/thrift/org/apache/aurora/gen/api.thrift b/api/src/main/thrift/org/apache/aurora/gen/api.thrift
index 98064bb..d4b8904 100644
--- a/api/src/main/thrift/org/apache/aurora/gen/api.thrift
+++ b/api/src/main/thrift/org/apache/aurora/gen/api.thrift
@@ -210,28 +210,6 @@ union Container {
2: DockerContainer docker
}
-/** Describes an image for use with the Mesos unified containerizer in the Docker format */
-struct DockerImage {
- /** The name of the image to run */
- 1: string name
- /** The Docker tag identifying the image */
- 2: string tag
-}
-
-/** Describes an image for use with the Mesos unified containerizer in the AppC format */
-struct AppcImage {
- /** The name of the image to run */
- 1: string name
- /** The appc image id identifying the image */
- 2: string imageId
-}
-
-/** Describes an image to be used with the Mesos unified containerizer */
-union Image {
- 1: DockerImage docker
- 2: AppcImage appc
-}
-
/** Description of the tasks contained within a job. */
struct TaskConfig {
/** Job task belongs to. */
@@ -249,11 +227,6 @@ struct TaskConfig {
18: optional bool production
/** Task tier type. */
30: optional string tier
- /**
- * If using the Mesos unified containerizer, the image to run (N.B. mutually exlusive with
- * specifying a container)
- */
- 31: optional Image image
20: set<Constraint> constraints
/** a list of named ports this task requests */
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
index c6785d0..b3b8ccf 100644
--- a/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
+++ b/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
@@ -186,10 +186,6 @@ public class ConfigurationManager {
static final String EXECUTOR_REQUIRED_WITH_DOCKER =
"This scheduler is configured to require an executor for Docker-based tasks.";
- @VisibleForTesting
- static final String CONTAINER_AND_IMAGE_ARE_MUTUALLY_EXCLUSIVE =
- "A task may not have both a Docker container and an image.";
-
/**
* Check validity of and populates defaults in a task configuration. This will return a deep copy
* of the provided task configuration with default configuration values applied, and configuration
@@ -277,21 +273,15 @@ public class ConfigurationManager {
// Default to mesos container type if unset.
containerType = Optional.of(Container._Fields.MESOS);
}
-
if (!containerType.isPresent()) {
throw new TaskDescriptionException("A job must have a container type.");
}
-
if (!allowedContainerTypes.contains(containerType.get())) {
throw new TaskDescriptionException(
"This scheduler is not configured to allow the container type "
+ containerType.get().toString());
}
- if (containerType.get() != Container._Fields.MESOS && config.isSetImage()) {
- throw new TaskDescriptionException(CONTAINER_AND_IMAGE_ARE_MUTUALLY_EXCLUSIVE);
- }
-
return ITaskConfig.build(builder);
}
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java b/src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java
index 25160df..364026a 100644
--- a/src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java
+++ b/src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java
@@ -22,11 +22,8 @@ import com.google.common.collect.Maps;
import org.apache.aurora.scheduler.storage.db.views.DbTaskConfig;
import org.apache.aurora.scheduler.storage.db.views.Pairs;
-import org.apache.aurora.scheduler.storage.entities.IAppcImage;
import org.apache.aurora.scheduler.storage.entities.IConstraint;
import org.apache.aurora.scheduler.storage.entities.IDockerContainer;
-import org.apache.aurora.scheduler.storage.entities.IDockerImage;
-import org.apache.aurora.scheduler.storage.entities.IImage;
import org.apache.aurora.scheduler.storage.entities.ITaskConfig;
import org.apache.aurora.scheduler.storage.entities.IValueConstraint;
@@ -110,6 +107,7 @@ class TaskConfigManager {
configMapper.insertMetadata(configInsert.getId(), config.getMetadata());
}
+ // TODO(wfarner): It would be nice if this generalized to different Container types.
if (config.getContainer().isSetDocker()) {
IDockerContainer container = config.getContainer().getDocker();
InsertResult containerInsert = new InsertResult();
@@ -119,29 +117,6 @@ class TaskConfigManager {
}
}
- if (config.isSetImage()) {
- IImage image = config.getImage();
-
- switch (image.getSetField()) {
- case DOCKER:
- IDockerImage dockerImage = image.getDocker();
- configMapper.insertDockerImage(
- configInsert.getId(),
- dockerImage.getName(),
- dockerImage.getTag());
- break;
- case APPC:
- IAppcImage appcImage = image.getAppc();
- configMapper.insertAppcImage(
- configInsert.getId(),
- appcImage.getName(),
- appcImage.getImageId());
- break;
- default:
- throw new IllegalStateException("Unexpected image type: " + image.getSetField());
- }
- }
-
return configInsert.getId();
}
}
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java b/src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java
index e778a39..12ca16b 100644
--- a/src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java
+++ b/src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java
@@ -152,28 +152,4 @@ interface TaskConfigMapper extends GarbageCollectedTableMapper {
* @param configIds Configs to delete.
*/
void delete(@Param("configIds") Set<Long> configIds);
-
- /**
- * Inserts an AppC image association with an {@link ITaskConfig}.
- *
- * @param configId Task config ID.
- * @param name The name of the image.
- * @param imageId The image's identifier.
- */
- void insertAppcImage(
- @Param("configId") long configId,
- @Param("name") String name,
- @Param("imageId") String imageId);
-
- /**
- * Inserts a Docker image association with an {@link ITaskConfig}.
- *
- * @param configId Task config ID.
- * @param name The name of the image.
- * @param tag The image's tag.
- */
- void insertDockerImage(
- @Param("configId") long configId,
- @Param("name") String name,
- @Param("tag") String tag);
}
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java b/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java
deleted file mode 100644
index 5964a2a..0000000
--- a/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java
+++ /dev/null
@@ -1,38 +0,0 @@
-/**
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.aurora.scheduler.storage.db.views;
-
-import org.apache.aurora.gen.AppcImage;
-import org.apache.aurora.gen.DockerImage;
-import org.apache.aurora.gen.Image;
-
-public final class DbImage {
- private AppcImage appc;
- private DockerImage docker;
-
- private DbImage() {
- }
-
- Image toThrift() {
- if (appc != null) {
- return Image.appc(appc);
- }
-
- if (docker != null) {
- return Image.docker(docker);
- }
-
- throw new IllegalStateException("Unknown image type.");
- }
-}
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java b/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java
index cdd1060..eb848ad 100644
--- a/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java
+++ b/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java
@@ -47,7 +47,6 @@ public final class DbTaskConfig {
private List<Metadata> metadata;
private DbContainer container;
private String tier;
- private DbImage image;
private DbTaskConfig() {
}
@@ -68,7 +67,6 @@ public final class DbTaskConfig {
.setMaxTaskFailures(maxTaskFailures)
.setProduction(production)
.setTier(tier)
- .setImage(image == null ? null : image.toThrift())
.setConstraints(constraints.stream()
.map(DbConstraint::toThrift)
.collect(GuavaUtils.toImmutableSet()))
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
----------------------------------------------------------------------
diff --git a/src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml b/src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
index cfeb69b..fd272cc 100644
--- a/src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
+++ b/src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
@@ -106,19 +106,6 @@
<association property="docker" resultMap="dockerContainerMap"/>
</resultMap>
- <resultMap id="dockerImageMap" type="org.apache.aurora.gen.DockerImage">
- <id column="id" />
- </resultMap>
-
- <resultMap id="appcImageMap" type="org.apache.aurora.gen.AppcImage">
- <id column="id" />
- </resultMap>
-
- <resultMap id="imageMap" type="org.apache.aurora.scheduler.storage.db.views.DbImage">
- <association property="appc" columnPrefix="appc_" resultMap="appcImageMap" />
- <association property="docker" columnPrefix="docker_" resultMap="dockerImageMap" />
- </resultMap>
-
<resultMap id="metadataMap" type="org.apache.aurora.gen.Metadata">
<id column="id" />
</resultMap>
@@ -133,7 +120,6 @@
resultMap="org.apache.aurora.scheduler.storage.db.JobKeyMapper.jobKeyMap"
columnPrefix="j_"/>
<association property="container" resultMap="containerMap" columnPrefix="c_"/>
- <association property="image" resultMap="imageMap" columnPrefix="image_" />
<collection
property="constraints"
columnPrefix="constraint_"
@@ -173,10 +159,6 @@
m.id AS m_id,
m.key AS m_key,
m.value AS m_value,
- di.name as image_docker_name,
- di.tag as image_docker_tag,
- ai.name as image_appc_name,
- ai.image_id as image_appc_image_id,
tc.id AS constraint_id,
tc.name AS constraint_name,
tlc.id AS constraint_l_id,
@@ -189,8 +171,6 @@
LEFT OUTER JOIN task_config_requested_ports AS p ON p.task_config_id = c.id
LEFT OUTER JOIN task_config_docker_containers AS d ON d.task_config_id = c.id
LEFT OUTER JOIN task_config_metadata AS m ON m.task_config_id = c.id
- LEFT OUTER JOIN task_config_docker_images AS di ON di.task_config_id = c.id
- LEFT OUTER JOIN task_config_appc_images AS ai ON ai.task_config_id = c.id
LEFT OUTER JOIN task_constraints AS tc ON tc.task_config_id = c.id
LEFT OUTER JOIN limit_constraints as tlc ON tlc.constraint_id = tc.id
LEFT OUTER JOIN value_constraints as tvc ON tvc.constraint_id = tc.id
@@ -317,30 +297,6 @@
)
</insert>
- <insert id="insertDockerImage">
- INSERT INTO task_config_docker_images (
- task_config_id,
- name,
- tag
- ) VALUES (
- #{configId},
- #{name},
- #{tag}
- )
- </insert>
-
- <insert id="insertAppcImage">
- INSERT INTO task_config_appc_images (
- task_config_id,
- name,
- image_id
- ) VALUES (
- #{configId},
- #{name},
- #{imageId}
- )
- </insert>
-
<insert id="insertMetadata">
INSERT INTO task_config_metadata (
task_config_id,
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
----------------------------------------------------------------------
diff --git a/src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql b/src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
index 92a0798..be60c3b 100644
--- a/src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
+++ b/src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
@@ -171,24 +171,6 @@ CREATE TABLE task_config_docker_container_parameters(
value VARCHAR NOT NULL
);
-CREATE TABLE task_config_docker_images(
- id IDENTITY,
- task_config_id BIGINT NOT NULL REFERENCES task_configs(id) ON DELETE CASCADE,
- name VARCHAR NOT NULL,
- tag VARCHAR NOT NULL,
-
- UNIQUE(task_config_id)
-);
-
-CREATE TABLE task_config_appc_images(
- id IDENTITY,
- task_config_id BIGINT NOT NULL REFERENCES task_configs(id) ON DELETE CASCADE,
- name VARCHAR NOT NULL,
- image_id VARCHAR NOT NULL,
-
- UNIQUE(task_config_id)
-);
-
CREATE TABLE task_states(
id INT PRIMARY KEY,
name VARCHAR NOT NULL,
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java b/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
index 52e9708..1a520b3 100644
--- a/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
+++ b/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
@@ -23,11 +23,9 @@ import com.google.common.collect.ImmutableSet;
import org.apache.aurora.gen.Constraint;
import org.apache.aurora.gen.Container;
import org.apache.aurora.gen.CronCollisionPolicy;
-import org.apache.aurora.gen.DockerImage;
import org.apache.aurora.gen.DockerParameter;
import org.apache.aurora.gen.ExecutorConfig;
import org.apache.aurora.gen.Identity;
-import org.apache.aurora.gen.Image;
import org.apache.aurora.gen.JobConfiguration;
import org.apache.aurora.gen.JobKey;
import org.apache.aurora.gen.LimitConstraint;
@@ -230,31 +228,6 @@ public class ConfigurationManagerTest {
CONFIGURATION_MANAGER.validateAndPopulate(ITaskConfig.build(builder));
}
- @Test
- public void testImageAndDockerContainerConfigurationAreMutuallyExclusive() throws Exception {
- TaskConfig builder = CONFIG_WITH_CONTAINER.newBuilder();
- builder.getContainer().getDocker().unsetParameters();
-
- Image image = new Image();
- image.setDocker(new DockerImage().setName("my-container").setTag("tag"));
- builder.setImage(image);
-
- expectTaskDescriptionException(ConfigurationManager.CONTAINER_AND_IMAGE_ARE_MUTUALLY_EXCLUSIVE);
- CONFIGURATION_MANAGER.validateAndPopulate(ITaskConfig.build(builder));
- }
-
- @Test
- public void testImageWithoutContainerIsAllowed() throws Exception {
- TaskConfig builder = UNSANITIZED_JOB_CONFIGURATION.deepCopy().getTaskConfig();
- builder.unsetConstraints();
-
- Image image = new Image();
- image.setDocker(new DockerImage().setName("my-container").setTag("tag"));
- builder.setImage(image);
-
- CONFIGURATION_MANAGER.validateAndPopulate(ITaskConfig.build(builder));
- }
-
private void expectTaskDescriptionException(String message) {
expectedException.expect(TaskDescriptionException.class);
expectedException.expectMessage(message);
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java b/src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java
index 2343394..c316e49 100644
--- a/src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java
+++ b/src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java
@@ -142,8 +142,7 @@ public abstract class AbstractCronJobStoreTest {
.setCronSchedule("schedule")
.setCronCollisionPolicy(CronCollisionPolicy.CANCEL_NEW)
.setTaskConfig(config.newBuilder())
- .setInstanceCount(5)),
- StorageEntityUtil.getField(ITaskConfig.class, "image"));
+ .setInstanceCount(5)));
}
private Set<IJobConfiguration> fetchJobs() {
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java b/src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java
index 8a87ff6..e56fed2 100644
--- a/src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java
+++ b/src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java
@@ -40,18 +40,14 @@ import com.google.inject.Injector;
import com.google.inject.Module;
import org.apache.aurora.common.testing.TearDownTestCase;
-import org.apache.aurora.gen.AppcImage;
import org.apache.aurora.gen.Attribute;
import org.apache.aurora.gen.Container;
-import org.apache.aurora.gen.DockerImage;
import org.apache.aurora.gen.ExecutorConfig;
import org.apache.aurora.gen.HostAttributes;
-import org.apache.aurora.gen.Image;
import org.apache.aurora.gen.MaintenanceMode;
import org.apache.aurora.gen.MesosContainer;
import org.apache.aurora.gen.Metadata;
import org.apache.aurora.gen.ScheduledTask;
-import org.apache.aurora.gen.TaskConfig;
import org.apache.aurora.gen.TaskQuery;
import org.apache.aurora.scheduler.base.JobKeys;
import org.apache.aurora.scheduler.base.Query;
@@ -153,9 +149,7 @@ public abstract class AbstractTaskStoreTest extends TearDownTestCase {
@Test
public void testSave() {
IScheduledTask aWithHost = setHost(TASK_A, HOST_A);
- StorageEntityUtil.assertFullyPopulated(
- aWithHost.newBuilder(),
- StorageEntityUtil.getField(TaskConfig.class, "image"));
+ StorageEntityUtil.assertFullyPopulated(aWithHost.newBuilder());
saveTasks(aWithHost, TASK_B);
assertStoreContents(aWithHost, TASK_B);
@@ -182,32 +176,6 @@ public abstract class AbstractTaskStoreTest extends TearDownTestCase {
}
@Test
- public void testSaveWithDockerImage() {
- ScheduledTask builder = TASK_A.newBuilder();
-
- Image image = new Image();
- image.setDocker(new DockerImage().setName("some-name").setTag("some-tag"));
- builder.getAssignedTask().getTask().setImage(image);
-
- IScheduledTask task = IScheduledTask.build(builder);
- saveTasks(task);
- assertStoreContents(task);
- }
-
- @Test
- public void testSaveWithAppcImage() {
- ScheduledTask builder = TASK_A.newBuilder();
-
- Image image = new Image();
- image.setAppc(new AppcImage().setName("some-name").setImageId("some-tag"));
- builder.getAssignedTask().getTask().setImage(image);
-
- IScheduledTask task = IScheduledTask.build(builder);
- saveTasks(task);
- assertStoreContents(task);
- }
-
- @Test
public void testQuery() {
assertStoreContents();
saveTasks(TASK_A, TASK_B, TASK_C, TASK_D);
http://git-wip-us.apache.org/repos/asf/aurora/blob/b5c9e1bc/src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java b/src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
index e43ec6c..0853039 100644
--- a/src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
+++ b/src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
@@ -60,7 +60,6 @@ import org.apache.aurora.scheduler.storage.entities.IJobUpdateKey;
import org.apache.aurora.scheduler.storage.entities.IJobUpdateQuery;
import org.apache.aurora.scheduler.storage.entities.IJobUpdateSummary;
import org.apache.aurora.scheduler.storage.entities.ILock;
-import org.apache.aurora.scheduler.storage.entities.ITaskConfig;
import org.apache.aurora.scheduler.storage.testing.StorageEntityUtil;
import org.apache.aurora.scheduler.testing.FakeStatsProvider;
import org.junit.After;
@@ -147,8 +146,7 @@ public class DbJobUpdateStoreTest {
StorageEntityUtil.getField(JobUpdateSummary.class, "state"),
StorageEntityUtil.getField(IJobUpdateSummary.class, "state"),
StorageEntityUtil.getField(Range.class, "first"),
- StorageEntityUtil.getField(Range.class, "last"),
- StorageEntityUtil.getField(ITaskConfig.class, "image"));
+ StorageEntityUtil.getField(Range.class, "last"));
saveUpdate(update1, Optional.of("lock1"));
assertUpdate(update1);
@@ -184,8 +182,7 @@ public class DbJobUpdateStoreTest {
StorageEntityUtil.getField(JobUpdateSummary.class, "state"),
StorageEntityUtil.getField(IJobUpdateSummary.class, "state"),
StorageEntityUtil.getField(Range.class, "first"),
- StorageEntityUtil.getField(Range.class, "last"),
- StorageEntityUtil.getField(ITaskConfig.class, "image"));
+ StorageEntityUtil.getField(Range.class, "last"));
saveUpdate(update, Optional.of("lock1"));
assertUpdate(update);
}