You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/13 00:24:53 UTC

[GitHub] [beam] pabloem commented on a change in pull request #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch

pabloem commented on a change in pull request #11109: [BEAM-8335] Final PR to merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109#discussion_r391971287
 
 

 ##########
 File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
 ##########
 @@ -314,6 +327,26 @@ def show(*pcolls, **configs):
   bcj.attempt_to_run_background_caching_job(
       runner, user_pipeline, user_pipeline.options)
 
+  pcolls = set(pcolls)
+  computed_pcolls = set()
+  for pcoll in pcolls:
+    if pcoll in ie.current_env().computed_pcollections:
 
 Review comment:
   @KevinGG @rohdesamuel 
   just for curiosity, how does a pcollection count as computed in streaming without source caching?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services