[GitHub] peterjohansen commented on a change in pull request #462: Httpsig

[GitBox <gi...@apache.org>]

peterjohansen commented on a change in pull request #462: Httpsig
URL: https://github.com/apache/cxf/pull/462#discussion_r231024707
 
 

 ##########
 File path: rt/rs/security/http-signature/src/main/java/org/apache/cxf/rs/security/httpsignature/AlgorithmProvider.java
 ##########
 @@ -0,0 +1,12 @@
+package org.apache.cxf.rs.security.httpsignature;
+
+@FunctionalInterface
+public interface AlgorithmProvider {
+
+    /**
+     *
+     * @param keyId
+     * @return the algorithm name (which is never {@code null})
+     */
+    String getAlgorithmName(String keyId);
 
 Review comment:
   > May be `Optional<String>` since `null` is not really useful?
   
   Optional even though it's never supposed to be `null`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services