You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/06/28 10:12:54 UTC

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #587: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

nit0906 commented on code in PR #587:
URL: https://github.com/apache/jackrabbit-oak/pull/587#discussion_r908301571


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandler.java:
##########
@@ -151,6 +152,7 @@ private BulkProcessor initBulkProcessor() {
         return BulkProcessor.builder(requestConsumer(),
                 new OakBulkProcessorListener(), this.indexName + "-bulk-processor")
                 .setBulkActions(indexDefinition.bulkActions)
+                .setConcurrentRequests(BULK_PROCESSOR_CONCURRENCY)

Review Comment:
   I am wondering if it's ok to set this concurrency to 4 as default here ? The intended change is only for OutOfBandIndexing via oak-run.
   If I am not wrong this change here would impact the async indexing as well. 
   @fabriziofortino  ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org