You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/08/16 11:08:29 UTC
[GitHub] [james-project] vttranlina opened a new pull request, #1131: [Draft] Split webadmin-http-client in a separate maven module than webadmin-cli
vttranlina opened a new pull request, #1131:
URL: https://github.com/apache/james-project/pull/1131
https://www.mail-archive.com/server-dev@james.apache.org/msg72269.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1131: JAMES-3807 Split webadmin-http-client in a separate maven module than webadmin-cli
Posted by GitBox <gi...@apache.org>.
chibenwa merged PR #1131:
URL: https://github.com/apache/james-project/pull/1131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on pull request #1131: Split webadmin-http-client in a separate maven module than webadmin-cli
Posted by GitBox <gi...@apache.org>.
quantranhong1999 commented on PR #1131:
URL: https://github.com/apache/james-project/pull/1131#issuecomment-1220358466
> Can we please open a JIRA ticket for this?
https://issues.apache.org/jira/browse/JAMES-3807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1131: Split webadmin-http-client in a separate maven module than webadmin-cli
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1131:
URL: https://github.com/apache/james-project/pull/1131#issuecomment-1220191059
Can we please open a JIRA ticket for this?
(I can add it to the commits when merging).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1131: Split webadmin-http-client in a separate maven module than webadmin-cli
Posted by GitBox <gi...@apache.org>.
quantranhong1999 commented on code in PR #1131:
URL: https://github.com/apache/james-project/pull/1131#discussion_r949926471
##########
pom.xml:
##########
@@ -2772,6 +2772,11 @@
<artifactId>mockito-core</artifactId>
<version>4.6.0</version>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-inline</artifactId>
+ <version>4.7.0</version>
+ </dependency>
Review Comment:
Should we parameterize both `mockito-core` and `mockito-inline` versions (should be the same also)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1131: [Draft] Split webadmin-http-client in a separate maven module than webadmin-cli
Posted by GitBox <gi...@apache.org>.
chibenwa commented on code in PR #1131:
URL: https://github.com/apache/james-project/pull/1131#discussion_r947415687
##########
server/pom.xml:
##########
@@ -49,6 +49,7 @@
<module>apps/scaling-pulsar-smtp</module>
<module>apps/spring-app</module>
<module>apps/webadmin-cli</module>
+ <module>apps/webadmin-http-client</module>
Review Comment:
I would prefer to have it in `server/protocols/webadmin/webadmin-http-client`. After all this is not an application (no Main)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org