You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "starocean999 (via GitHub)" <gi...@apache.org> on 2024/09/18 11:58:34 UTC
[PR] [enhancement](nereids)show user friendly error msg when window function contains order by expression [doris]
starocean999 opened a new pull request, #40937:
URL: https://github.com/apache/doris/pull/40937
…
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](nereids)show user friendly error msg when window function contains order by expression [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #40937:
URL: https://github.com/apache/doris/pull/40937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](nereids)show user friendly error msg when window function contains order by expression [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40937:
URL: https://github.com/apache/doris/pull/40937#issuecomment-2362641195
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](nereids)show user friendly error msg when window function contains order by expression [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40937:
URL: https://github.com/apache/doris/pull/40937#issuecomment-2359885050
<details>
<summary>ClickBench: <b>Total hot run time: 31.76 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ac8c1e96492c77de3a1f5e0a0c3048d519f734b2, data reload: false
query1 0.05 0.04 0.04
query2 0.06 0.03 0.03
query3 0.23 0.07 0.06
query4 1.65 0.10 0.10
query5 0.50 0.51 0.51
query6 1.14 0.72 0.73
query7 0.02 0.01 0.01
query8 0.05 0.03 0.04
query9 0.55 0.50 0.50
query10 0.57 0.57 0.56
query11 0.14 0.11 0.11
query12 0.13 0.10 0.10
query13 0.61 0.60 0.59
query14 2.99 2.95 2.95
query15 0.90 0.82 0.84
query16 0.39 0.40 0.39
query17 1.03 1.05 1.01
query18 0.19 0.19 0.19
query19 1.99 1.86 2.02
query20 0.01 0.01 0.01
query21 15.36 0.62 0.60
query22 2.65 3.21 1.21
query23 17.96 0.90 0.89
query24 3.60 0.31 1.14
query25 0.31 0.18 0.06
query26 0.33 0.14 0.14
query27 0.04 0.04 0.04
query28 11.62 1.10 1.08
query29 12.54 3.40 3.36
query30 0.24 0.06 0.05
query31 2.90 0.38 0.38
query32 3.27 0.46 0.47
query33 2.97 3.01 3.02
query34 16.43 4.41 4.38
query35 4.33 4.44 4.42
query36 0.67 0.50 0.49
query37 0.09 0.06 0.06
query38 0.04 0.03 0.04
query39 0.03 0.02 0.02
query40 0.15 0.12 0.13
query41 0.07 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.03 0.02
Total cold run time: 108.86 s
Total hot run time: 31.76 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](nereids)show user friendly error msg when window function contains order by expression [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40937:
URL: https://github.com/apache/doris/pull/40937#issuecomment-2359870084
<details>
<summary>TPC-H: <b>Total hot run time: 41075 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ac8c1e96492c77de3a1f5e0a0c3048d519f734b2, data reload: false
------ Round 1 ----------------------------------
q1 17582 7330 7222 7222
q2 2040 159 152 152
q3 10633 1060 1212 1060
q4 10564 739 723 723
q5 7754 3029 3046 3029
q6 232 152 145 145
q7 1002 633 601 601
q8 9439 2017 2022 2017
q9 6834 6395 6431 6395
q10 7009 2263 2280 2263
q11 437 239 248 239
q12 403 212 214 212
q13 17776 2989 2965 2965
q14 255 210 224 210
q15 578 517 528 517
q16 658 616 598 598
q17 959 817 787 787
q18 7226 6676 6614 6614
q19 1399 979 1029 979
q20 575 282 276 276
q21 4017 3237 3077 3077
q22 1099 1009 994 994
Total cold run time: 108471 ms
Total hot run time: 41075 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7265 7221 7235 7221
q2 320 236 232 232
q3 2926 2939 3023 2939
q4 2004 1758 1854 1758
q5 5617 5626 5564 5564
q6 230 140 139 139
q7 2253 1796 1837 1796
q8 3283 3456 3396 3396
q9 8774 8858 8771 8771
q10 3553 3445 3438 3438
q11 579 483 496 483
q12 828 580 618 580
q13 11601 3130 3171 3130
q14 299 277 275 275
q15 585 560 533 533
q16 724 668 672 668
q17 1810 1571 1573 1571
q18 8314 7894 7778 7778
q19 1786 1598 1554 1554
q20 2118 1874 1894 1874
q21 5419 5252 5339 5252
q22 1150 1039 1030 1030
Total cold run time: 71438 ms
Total hot run time: 59982 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](nereids)show user friendly error msg when window function contains order by expression [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40937:
URL: https://github.com/apache/doris/pull/40937#issuecomment-2359879673
<details>
<summary>TPC-DS: <b>Total hot run time: 199027 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ac8c1e96492c77de3a1f5e0a0c3048d519f734b2, data reload: false
query1 1298 893 873 873
query2 6383 2007 2069 2007
query3 10786 3926 3802 3802
query4 64522 29430 23469 23469
query5 5040 478 463 463
query6 400 163 172 163
query7 5455 304 291 291
query8 310 223 217 217
query9 8329 2617 2620 2617
query10 449 286 272 272
query11 17267 15229 15990 15229
query12 157 101 100 100
query13 1498 404 418 404
query14 10743 7541 7171 7171
query15 208 178 179 178
query16 6629 492 494 492
query17 1193 588 597 588
query18 1462 315 312 312
query19 211 151 152 151
query20 128 117 112 112
query21 206 111 104 104
query22 4943 4875 4707 4707
query23 34975 33912 33954 33912
query24 6056 2875 2820 2820
query25 495 413 400 400
query26 642 161 160 160
query27 1677 282 287 282
query28 4117 2457 2404 2404
query29 688 447 439 439
query30 235 154 159 154
query31 954 764 770 764
query32 70 56 55 55
query33 454 310 293 293
query34 904 472 483 472
query35 863 762 733 733
query36 1066 933 926 926
query37 145 91 84 84
query38 4012 3934 4009 3934
query39 1453 1438 1405 1405
query40 209 96 95 95
query41 49 46 50 46
query42 120 93 94 93
query43 537 494 491 491
query44 1132 793 781 781
query45 194 163 163 163
query46 1133 786 749 749
query47 1969 1840 1833 1833
query48 475 365 361 361
query49 707 419 414 414
query50 856 429 399 399
query51 7020 6964 6932 6932
query52 97 86 86 86
query53 249 183 178 178
query54 553 449 461 449
query55 80 76 75 75
query56 269 243 262 243
query57 1240 1115 1072 1072
query58 224 236 229 229
query59 3161 3311 3066 3066
query60 286 265 256 256
query61 109 131 104 104
query62 748 665 650 650
query63 219 185 188 185
query64 1391 652 630 630
query65 3271 3201 3160 3160
query66 621 302 301 301
query67 16074 15561 15560 15560
query68 1308 796 548 548
query69 444 280 296 280
query70 1196 1119 1123 1119
query71 314 263 270 263
query72 6135 3993 4003 3993
query73 759 321 336 321
query74 9302 8912 8956 8912
query75 3342 2680 2671 2671
query76 1484 890 896 890
query77 491 287 293 287
query78 9976 9339 9546 9339
query79 1171 891 862 862
query80 850 579 584 579
query81 489 251 251 251
query82 1281 237 227 227
query83 230 163 158 158
query84 289 103 103 103
query85 760 373 361 361
query86 340 323 323 323
query87 4438 4322 4434 4322
query88 4650 4030 4022 4022
query89 392 358 357 357
query90 1861 312 303 303
query91 160 165 168 165
query92 77 70 74 70
query93 964 898 896 896
query94 691 345 381 345
query95 445 406 403 403
query96 485 481 489 481
query97 3156 3123 3163 3123
query98 239 221 221 221
query99 1445 1290 1272 1272
Total cold run time: 308580 ms
Total hot run time: 199027 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](nereids)show user friendly error msg when window function contains order by expression [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40937:
URL: https://github.com/apache/doris/pull/40937#issuecomment-2358359555
<details>
<summary>TPC-H: <b>Total hot run time: 41591 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ac8c1e96492c77de3a1f5e0a0c3048d519f734b2, data reload: false
------ Round 1 ----------------------------------
q1 17582 7907 7229 7229
q2 2058 163 168 163
q3 10810 1093 1194 1093
q4 10575 766 771 766
q5 7748 3051 3030 3030
q6 238 147 147 147
q7 1004 608 588 588
q8 9432 2055 2048 2048
q9 6832 6379 6396 6379
q10 7014 2290 2294 2290
q11 439 259 258 258
q12 408 219 213 213
q13 17792 2997 3018 2997
q14 243 216 236 216
q15 576 522 538 522
q16 683 636 610 610
q17 981 827 820 820
q18 7353 6626 6756 6626
q19 1383 968 1016 968
q20 588 290 289 289
q21 4061 3320 3388 3320
q22 1112 1024 1019 1019
Total cold run time: 108912 ms
Total hot run time: 41591 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7238 7240 7201 7201
q2 327 230 236 230
q3 3049 3017 2969 2969
q4 1990 1861 1850 1850
q5 5595 5614 5673 5614
q6 237 153 144 144
q7 2211 1793 1810 1793
q8 3339 3441 3449 3441
q9 8855 9029 8806 8806
q10 3520 3469 3501 3469
q11 579 498 525 498
q12 832 582 655 582
q13 10375 3160 3234 3160
q14 290 279 278 278
q15 598 535 513 513
q16 722 685 697 685
q17 1830 1607 1575 1575
q18 8261 7874 7772 7772
q19 1735 1631 1582 1582
q20 2153 1909 1886 1886
q21 5594 5261 5358 5261
q22 1125 1072 1055 1055
Total cold run time: 70455 ms
Total hot run time: 60364 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](nereids)show user friendly error msg when window function contains order by expression [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40937:
URL: https://github.com/apache/doris/pull/40937#issuecomment-2358272484
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](nereids)show user friendly error msg when window function contains order by expression [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #40937:
URL: https://github.com/apache/doris/pull/40937#issuecomment-2358272668
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](nereids)show user friendly error msg when window function contains order by expression [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40937:
URL: https://github.com/apache/doris/pull/40937#issuecomment-2362641393
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org