You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ga...@apache.org on 2020/05/22 17:47:02 UTC
[flink] branch release-1.11 updated (828ba1d -> 3e18c10)
This is an automated email from the ASF dual-hosted git repository.
gary pushed a change to branch release-1.11
in repository https://gitbox.apache.org/repos/asf/flink.git.
from 828ba1d [FLINK-17801][tests] Increase timeout of TaskExecutorTest.testHeartbeatTimeoutWithResourceManager
new 1bf5b81 [hotfix][tests] Make ClientTest extend TestLogger
new 81c185b [hotfix][qs] Fix logging of exception in RequestWriteListener
new 7cbdd91 [FLINK-13553][qs] Add logging to AbstractServerHandler
new 3e18c10 [FLINK-13553][tests] Enable TRACE logging for org.apache.flink.queryablestate
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../apache/flink/queryablestate/network/AbstractServerHandler.java | 5 ++++-
.../java/org/apache/flink/queryablestate/network/ClientTest.java | 3 ++-
tools/log4j-travis.properties | 5 +++++
3 files changed, 11 insertions(+), 2 deletions(-)
[flink] 01/04: [hotfix][tests] Make ClientTest extend TestLogger
Posted by ga...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gary pushed a commit to branch release-1.11
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 1bf5b810eb73faa420bed5fdef92a2634f8b7f34
Author: Gary Yao <ga...@apache.org>
AuthorDate: Thu May 21 09:29:52 2020 +0200
[hotfix][tests] Make ClientTest extend TestLogger
---
.../test/java/org/apache/flink/queryablestate/network/ClientTest.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java b/flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
index b2ebdaf..e19a717 100644
--- a/flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
+++ b/flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
@@ -45,6 +45,7 @@ import org.apache.flink.runtime.state.memory.MemoryStateBackend;
import org.apache.flink.runtime.state.ttl.TtlTimeProvider;
import org.apache.flink.util.ExceptionUtils;
import org.apache.flink.util.NetUtils;
+import org.apache.flink.util.TestLogger;
import org.apache.flink.shaded.netty4.io.netty.bootstrap.ServerBootstrap;
import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf;
@@ -97,7 +98,7 @@ import static org.junit.Assert.fail;
/**
* Tests for {@link Client}.
*/
-public class ClientTest {
+public class ClientTest extends TestLogger {
private static final Logger LOG = LoggerFactory.getLogger(ClientTest.class);
[flink] 04/04: [FLINK-13553][tests] Enable TRACE logging for
org.apache.flink.queryablestate
Posted by ga...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gary pushed a commit to branch release-1.11
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 3e18c109051821176575a15a6b10aaa5cc2e3e12
Author: Gary Yao <ga...@apache.org>
AuthorDate: Thu May 21 10:05:05 2020 +0200
[FLINK-13553][tests] Enable TRACE logging for org.apache.flink.queryablestate
---
tools/log4j-travis.properties | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tools/log4j-travis.properties b/tools/log4j-travis.properties
index f5912d5..4550a98 100644
--- a/tools/log4j-travis.properties
+++ b/tools/log4j-travis.properties
@@ -68,3 +68,8 @@ logger.zkclient.level = INFO
logger.zkclient.appenderRef.out.ref = ConsoleAppender
logger.consumer.name = org.apache.flink.streaming.connectors.kafka.internals.SimpleConsumerThread
logger.consumer.level = OFF
+
+# Enable TRACE logging to debug FLINK-13553
+logger.queryablestate.name = org.apache.flink.queryablestate
+logger.queryablestate.level = TRACE
+logger.queryablestate.appenderRef.out.ref = ConsoleAppender
[flink] 02/04: [hotfix][qs] Fix logging of exception in
RequestWriteListener
Posted by ga...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gary pushed a commit to branch release-1.11
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 81c185bdeeccf9f10bf584defde740676d305646
Author: Gary Yao <ga...@apache.org>
AuthorDate: Thu May 21 09:30:14 2020 +0200
[hotfix][qs] Fix logging of exception in RequestWriteListener
Log stacktrace of exception instead of only the message.
---
.../org/apache/flink/queryablestate/network/AbstractServerHandler.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java b/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
index 7941131..4115fd9 100644
--- a/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
+++ b/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
@@ -308,7 +308,7 @@ public abstract class AbstractServerHandler<REQ extends MessageBody, RESP extend
LOG.debug("Request {} was successfully answered after {} ms.", request, durationMillis);
stats.reportSuccessfulRequest(durationMillis);
} else {
- LOG.debug("Request {} failed after {} ms due to: {}", request, durationMillis, future.cause());
+ LOG.debug("Request {} failed after {} ms", request, durationMillis, future.cause());
stats.reportFailedRequest();
}
}
[flink] 03/04: [FLINK-13553][qs] Add logging to
AbstractServerHandler
Posted by ga...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gary pushed a commit to branch release-1.11
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 7cbdd91413ee26d00d9015581ce2fa8538fd5963
Author: Gary Yao <ga...@apache.org>
AuthorDate: Thu May 21 09:44:33 2020 +0200
[FLINK-13553][qs] Add logging to AbstractServerHandler
Log every request on trace level.
Log caught exceptions in AsyncRequestTask.
---
.../org/apache/flink/queryablestate/network/AbstractServerHandler.java | 3 +++
1 file changed, 3 insertions(+)
diff --git a/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java b/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
index 4115fd9..9011bb2 100644
--- a/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
+++ b/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
@@ -110,6 +110,7 @@ public abstract class AbstractServerHandler<REQ extends MessageBody, RESP extend
final MessageType msgType = MessageSerializer.deserializeHeader(buf);
requestId = MessageSerializer.getRequestId(buf);
+ LOG.trace("Handling request with ID {}", requestId);
if (msgType == MessageType.REQUEST) {
@@ -263,6 +264,7 @@ public abstract class AbstractServerHandler<REQ extends MessageBody, RESP extend
write.addListener(new RequestWriteListener());
} catch (BadRequestException e) {
+ LOG.debug("Bad request (request ID = {})", requestId, e);
try {
stats.reportFailedRequest();
final ByteBuf err = MessageSerializer.serializeRequestFailure(ctx.alloc(), requestId, e);
@@ -271,6 +273,7 @@ public abstract class AbstractServerHandler<REQ extends MessageBody, RESP extend
LOG.error("Failed to respond with the error after failed request", io);
}
} catch (Throwable t) {
+ LOG.error("Error while handling request with ID {}", requestId, t);
try {
stats.reportFailedRequest();