You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Min Chen <mi...@citrix.com> on 2012/12/12 02:18:06 UTC
Review Request: Move id field from BaseViewVO to individual VO classes to
fix DAO layer search bug.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8538/
-----------------------------------------------------------
Review request for cloudstack and Rohit Yadav.
Description
-------
Move id field from BaseViewVO to individual VO classes to fix DAO layer search bug.
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527.
Diffs
-----
api/src/org/apache/cloudstack/api/view/vo/BaseViewVO.java ca7cacb
api/src/org/apache/cloudstack/api/view/vo/DomainRouterJoinVO.java d7d31b0
api/src/org/apache/cloudstack/api/view/vo/EventJoinVO.java e8619d6
api/src/org/apache/cloudstack/api/view/vo/InstanceGroupJoinVO.java 0919487
api/src/org/apache/cloudstack/api/view/vo/ProjectAccountJoinVO.java 3f253e8
api/src/org/apache/cloudstack/api/view/vo/ProjectJoinVO.java a3f28a1
api/src/org/apache/cloudstack/api/view/vo/ResourceTagJoinVO.java 052149b
api/src/org/apache/cloudstack/api/view/vo/SecurityGroupJoinVO.java 80cab11
api/src/org/apache/cloudstack/api/view/vo/UserAccountJoinVO.java 2cecd2c
api/src/org/apache/cloudstack/api/view/vo/UserVmJoinVO.java 0edf0be
server/src/com/cloud/api/ApiDBUtils.java 4b889d6
Diff: https://reviews.apache.org/r/8538/diff/
Testing
-------
Thanks,
Min Chen
Re: Review Request: Move id field from BaseViewVO to individual VO classes
to fix DAO layer search bug.
Posted by Rohit Yadav <ro...@citrix.com>.
> On Dec. 12, 2012, 1:38 a.m., Rohit Yadav wrote:
> > Applied in api_refactoring;
> >
> > commit 3661f7f99293838d18b53326b43cd486456ec60f
> > Author: Min Chen <mi...@citrix.com>
> > Date: Tue Dec 11 17:14:14 2012 -0800
> >
> > Fix several bugs of new refactored list apis.
Thanks for the fix Min! Verified no db exceptions, looking fwd to your uuid fix.
- Rohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8538/#review14344
-----------------------------------------------------------
On Dec. 12, 2012, 1:18 a.m., Min Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8538/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2012, 1:18 a.m.)
>
>
> Review request for cloudstack and Rohit Yadav.
>
>
> Description
> -------
>
> Move id field from BaseViewVO to individual VO classes to fix DAO layer search bug.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/view/vo/BaseViewVO.java ca7cacb
> api/src/org/apache/cloudstack/api/view/vo/DomainRouterJoinVO.java d7d31b0
> api/src/org/apache/cloudstack/api/view/vo/EventJoinVO.java e8619d6
> api/src/org/apache/cloudstack/api/view/vo/InstanceGroupJoinVO.java 0919487
> api/src/org/apache/cloudstack/api/view/vo/ProjectAccountJoinVO.java 3f253e8
> api/src/org/apache/cloudstack/api/view/vo/ProjectJoinVO.java a3f28a1
> api/src/org/apache/cloudstack/api/view/vo/ResourceTagJoinVO.java 052149b
> api/src/org/apache/cloudstack/api/view/vo/SecurityGroupJoinVO.java 80cab11
> api/src/org/apache/cloudstack/api/view/vo/UserAccountJoinVO.java 2cecd2c
> api/src/org/apache/cloudstack/api/view/vo/UserVmJoinVO.java 0edf0be
> server/src/com/cloud/api/ApiDBUtils.java 4b889d6
>
> Diff: https://reviews.apache.org/r/8538/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Min Chen
>
>
Re: Review Request: Move id field from BaseViewVO to individual VO classes
to fix DAO layer search bug.
Posted by Rohit Yadav <ro...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8538/#review14344
-----------------------------------------------------------
Ship it!
Applied in api_refactoring;
commit 3661f7f99293838d18b53326b43cd486456ec60f
Author: Min Chen <mi...@citrix.com>
Date: Tue Dec 11 17:14:14 2012 -0800
Fix several bugs of new refactored list apis.
- Rohit Yadav
On Dec. 12, 2012, 1:18 a.m., Min Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8538/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2012, 1:18 a.m.)
>
>
> Review request for cloudstack and Rohit Yadav.
>
>
> Description
> -------
>
> Move id field from BaseViewVO to individual VO classes to fix DAO layer search bug.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/view/vo/BaseViewVO.java ca7cacb
> api/src/org/apache/cloudstack/api/view/vo/DomainRouterJoinVO.java d7d31b0
> api/src/org/apache/cloudstack/api/view/vo/EventJoinVO.java e8619d6
> api/src/org/apache/cloudstack/api/view/vo/InstanceGroupJoinVO.java 0919487
> api/src/org/apache/cloudstack/api/view/vo/ProjectAccountJoinVO.java 3f253e8
> api/src/org/apache/cloudstack/api/view/vo/ProjectJoinVO.java a3f28a1
> api/src/org/apache/cloudstack/api/view/vo/ResourceTagJoinVO.java 052149b
> api/src/org/apache/cloudstack/api/view/vo/SecurityGroupJoinVO.java 80cab11
> api/src/org/apache/cloudstack/api/view/vo/UserAccountJoinVO.java 2cecd2c
> api/src/org/apache/cloudstack/api/view/vo/UserVmJoinVO.java 0edf0be
> server/src/com/cloud/api/ApiDBUtils.java 4b889d6
>
> Diff: https://reviews.apache.org/r/8538/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Min Chen
>
>