[GitHub] [superset] ktmud commented on pull request #16776: fix(dataset): retain is_dttm if set on metadata sync

[GitBox <gi...@apache.org>]

ktmud commented on pull request #16776:
URL: https://github.com/apache/superset/pull/16776#issuecomment-924638734


   > > LGTM. Thanks for the quick fix!
   > 
   > > 
   > 
   > > For the case when the original temporal flag was inferred from db type instead of user selection, this change seems will also retain the flag, but maybe that's OK?
   > 
   > 
   > 
   > Yeah, I didn't think that would be a common need, but I'm open to changing that, too, if this is a typical scenario. Do you think it's common to want to disable temporal flags for temporal type columns?
   > 
   > 
   > 
   > 
   
   I was more thinking of when some column changed from a datetime type to non datetime, the previously inferred is_dttm will be retained. But like I said, I think this case is also OK. It's much more likely to want to force a non-dttm to dttm than vice versa.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org