[GitHub] [druid] suneet-s commented on a change in pull request #11922: Support filtering data in Auto Compaction

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #11922:
URL: https://github.com/apache/druid/pull/11922#discussion_r752596131



##########
File path: core/src/test/java/org/apache/druid/timeline/DataSegmentTest.java
##########
@@ -145,7 +146,7 @@ public void testV1Serialization() throws Exception
     Assert.assertEquals(ImmutableMap.of("type", "numbered", "partitionNum", 3, "partitions", 0), objectMap.get("shardSpec"));
     Assert.assertEquals(TEST_VERSION, objectMap.get("binaryVersion"));
     Assert.assertEquals(1, objectMap.get("size"));
-    Assert.assertEquals(4, ((Map) objectMap.get("lastCompactionState")).size());
+    Assert.assertEquals(5, ((Map) objectMap.get("lastCompactionState")).size());

Review comment:
       this is a test for "V1" Shouldn't this test remain without the `filter` being part of the CompactionState?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org