You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "xumanbu (via GitHub)" <gi...@apache.org> on 2023/09/04 11:45:26 UTC
[GitHub] [incubator-uniffle] xumanbu commented on a diff in pull request #1186: [#1178] improvement: set `rss.coordinator.quota.default.app.num` default -1 to indicate no quota check
xumanbu commented on code in PR #1186:
URL: https://github.com/apache/incubator-uniffle/pull/1186#discussion_r1314842003
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/QuotaManagerTest.java:
##########
@@ -116,13 +116,15 @@ public void testCheckQuota() throws Exception {
final boolean icCheck =
applicationManager.getQuotaManager().checkQuota("user4", String.valueOf(i1));
registerThread.join();
- assertTrue(icCheck);
+ assertFalse(icCheck);
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org