You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/01/10 21:06:33 UTC
[kudu-CR] [master] cleanup on SysCatalogTable::SysWrite()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15009
Change subject: [master] cleanup on SysCatalogTable::SysWrite()
......................................................................
[master] cleanup on SysCatalogTable::SysWrite()
Don't pass useless WriteResponsePB parameter around while calling
SysCatalogTable::SysWrite().
Change-Id: Ide521860182f19cb6f0134bd1b92c2288a0ce64c
---
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
2 files changed, 18 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/15009/1
--
To view, visit http://gerrit.cloudera.org:8080/15009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide521860182f19cb6f0134bd1b92c2288a0ce64c
Gerrit-Change-Number: 15009
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [master] cleanup on SysCatalogTable::SysWrite()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15009 )
Change subject: [master] cleanup on SysCatalogTable::SysWrite()
......................................................................
[master] cleanup on SysCatalogTable::SysWrite()
Don't pass useless WriteResponsePB parameter around while calling
SysCatalogTable::SysWrite().
Change-Id: Ide521860182f19cb6f0134bd1b92c2288a0ce64c
Reviewed-on: http://gerrit.cloudera.org:8080/15009
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
2 files changed, 18 insertions(+), 25 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide521860182f19cb6f0134bd1b92c2288a0ce64c
Gerrit-Change-Number: 15009
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [master] cleanup on SysCatalogTable::SysWrite()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15009 )
Change subject: [master] cleanup on SysCatalogTable::SysWrite()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide521860182f19cb6f0134bd1b92c2288a0ce64c
Gerrit-Change-Number: 15009
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 10 Jan 2020 22:26:10 +0000
Gerrit-HasComments: No