You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Rohit Jain (JIRA)" <ji...@apache.org> on 2009/10/28 10:35:59 UTC
[jira] Created: (OFBIZ-3098) Improvement in input validation of 1st
step (shopping cart) on onePageCheckout page.
Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.
------------------------------------------------------------------------------------
Key: OFBIZ-3098
URL: https://issues.apache.org/jira/browse/OFBIZ-3098
Project: OFBiz
Issue Type: Improvement
Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Rohit Jain
Priority: Minor
Fix For: SVN trunk
On onePageCheckout page in Shopping Cart(step1), if we enter any character(not numeric value) in quantity text box, then this text box become empty and show 'required' validation message, It should show "Please enter a valid number in this field."
Step to reproduce:-
1) Add item in cart.
2) Move on onePageCheckout page.
3) Enter any character in item quantity text box.
4) Then it show validation message "required".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3098) Improvement in input validation of 1st
step (shopping cart) on onePageCheckout page.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-3098.
----------------------------------
Resolution: Fixed
Thanks guys,
Commited at r834527
> Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3098
> URL: https://issues.apache.org/jira/browse/OFBIZ-3098
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Rohit Jain
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3098.patch, OFBIZ-3098.patch, OFBIZ-3098.patch
>
>
> On onePageCheckout page in Shopping Cart(step1), if we enter any character(not numeric value) in quantity text box, then this text box become empty and show 'required' validation message, It should show "Please enter a valid number in this field."
> Step to reproduce:-
> 1) Add item in cart.
> 2) Move on onePageCheckout page.
> 3) Enter any character in item quantity text box.
> 4) Then it show validation message "required".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3098) Improvement in input validation of 1st
step (shopping cart) on onePageCheckout page.
Posted by "Rohit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohit Jain updated OFBIZ-3098:
------------------------------
Attachment: OFBIZ-3098.patch
Here is patch for this validation message.
added a ui label "Please enter a valid number in this field.".
> Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3098
> URL: https://issues.apache.org/jira/browse/OFBIZ-3098
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Rohit Jain
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3098.patch
>
>
> On onePageCheckout page in Shopping Cart(step1), if we enter any character(not numeric value) in quantity text box, then this text box become empty and show 'required' validation message, It should show "Please enter a valid number in this field."
> Step to reproduce:-
> 1) Add item in cart.
> 2) Move on onePageCheckout page.
> 3) Enter any character in item quantity text box.
> 4) Then it show validation message "required".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3098) Improvement in input validation of
1st step (shopping cart) on onePageCheckout page.
Posted by "Rohit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771851#action_12771851 ]
Rohit Jain commented on OFBIZ-3098:
-----------------------------------
On onePageCheckout page in Shopping Cart(step1), if we done empty quantity text box, then (Required) message shown but on console server generated following warning:-
2009-10-30 12:21:38,427 (http-0.0.0.0-28443-4) [ UtilProperties.java:917:INFO ] ResourceBundle OrderErrorUiLabels (en_US) created in 0.175s with 413 properties
2009-10-30 12:21:38,466 (http-0.0.0.0-28443-4) [ ShoppingCartHelper.java:819:WARN ]
---- exception report ----------------------------------------------------------
Exception: java.text.ParseException
Message: Unparseable number: ""
---- stack trace ---------------------------------------------------------------
java.text.ParseException: Unparseable number: ""
java.text.NumberFormat.parse(NumberFormat.java:333)
org.ofbiz.order.shoppingcart.ShoppingCartHelper.modifyCart(ShoppingCartHelper.java:729)
org.ofbiz.order.shoppingcart.ShoppingCartEvents.modifyCart(ShoppingCartEvents.java:781)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:597)
org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:92)
org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:78)
org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:628)
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:374)
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:216)
org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:82)
javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
Attached patch also remove this warning.
> Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3098
> URL: https://issues.apache.org/jira/browse/OFBIZ-3098
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Rohit Jain
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3098.patch
>
>
> On onePageCheckout page in Shopping Cart(step1), if we enter any character(not numeric value) in quantity text box, then this text box become empty and show 'required' validation message, It should show "Please enter a valid number in this field."
> Step to reproduce:-
> 1) Add item in cart.
> 2) Move on onePageCheckout page.
> 3) Enter any character in item quantity text box.
> 4) Then it show validation message "required".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3098) Improvement in input validation of
1st step (shopping cart) on onePageCheckout page.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776458#action_12776458 ]
Ashish Vijaywargiya commented on OFBIZ-3098:
--------------------------------------------
Thanks Jacques for quick pick.
--
Ashish
> Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3098
> URL: https://issues.apache.org/jira/browse/OFBIZ-3098
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Rohit Jain
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3098.patch, OFBIZ-3098.patch, OFBIZ-3098.patch
>
>
> On onePageCheckout page in Shopping Cart(step1), if we enter any character(not numeric value) in quantity text box, then this text box become empty and show 'required' validation message, It should show "Please enter a valid number in this field."
> Step to reproduce:-
> 1) Add item in cart.
> 2) Move on onePageCheckout page.
> 3) Enter any character in item quantity text box.
> 4) Then it show validation message "required".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3098) Improvement in input validation of 1st
step (shopping cart) on onePageCheckout page.
Posted by "Amit Sharma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amit Sharma updated OFBIZ-3098:
-------------------------------
Attachment: OFBIZ-3098.patch
Here is uploaded updated patch.
UiLabels key should be CommonPleaseEnterValidNumberInThisField instead of EcommerceValidNumber.
--
Regards
Amit Sharma
> Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3098
> URL: https://issues.apache.org/jira/browse/OFBIZ-3098
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Rohit Jain
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3098.patch, OFBIZ-3098.patch
>
>
> On onePageCheckout page in Shopping Cart(step1), if we enter any character(not numeric value) in quantity text box, then this text box become empty and show 'required' validation message, It should show "Please enter a valid number in this field."
> Step to reproduce:-
> 1) Add item in cart.
> 2) Move on onePageCheckout page.
> 3) Enter any character in item quantity text box.
> 4) Then it show validation message "required".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3098) Improvement in input validation of 1st
step (shopping cart) on onePageCheckout page.
Posted by "Amit Sharma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amit Sharma updated OFBIZ-3098:
-------------------------------
Attachment: OFBIZ-3098.patch
Here is the updated patch at revision 834421.
Thanks Arun.
Regards,
-Amit Sharma
> Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3098
> URL: https://issues.apache.org/jira/browse/OFBIZ-3098
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Rohit Jain
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3098.patch, OFBIZ-3098.patch, OFBIZ-3098.patch
>
>
> On onePageCheckout page in Shopping Cart(step1), if we enter any character(not numeric value) in quantity text box, then this text box become empty and show 'required' validation message, It should show "Please enter a valid number in this field."
> Step to reproduce:-
> 1) Add item in cart.
> 2) Move on onePageCheckout page.
> 3) Enter any character in item quantity text box.
> 4) Then it show validation message "required".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3098) Improvement in input validation of
1st step (shopping cart) on onePageCheckout page.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-3098:
------------------------------------------
Assignee: Ashish Vijaywargiya
> Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3098
> URL: https://issues.apache.org/jira/browse/OFBIZ-3098
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Rohit Jain
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3098.patch, OFBIZ-3098.patch, OFBIZ-3098.patch
>
>
> On onePageCheckout page in Shopping Cart(step1), if we enter any character(not numeric value) in quantity text box, then this text box become empty and show 'required' validation message, It should show "Please enter a valid number in this field."
> Step to reproduce:-
> 1) Add item in cart.
> 2) Move on onePageCheckout page.
> 3) Enter any character in item quantity text box.
> 4) Then it show validation message "required".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3098) Improvement in input validation of
1st step (shopping cart) on onePageCheckout page.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775444#action_12775444 ]
Ashish Vijaywargiya commented on OFBIZ-3098:
--------------------------------------------
Amit and Rohit thanks for the contribution.
I have applied changes of specialpurpose/ecommerce component.
Will wait for *framework* related changes to be committed to trunk.
Then we will close this issue.
Any taker - Jacques?
Thanks in Advance :-)
--
Ashish Vijaywargiya
> Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-3098
> URL: https://issues.apache.org/jira/browse/OFBIZ-3098
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Rohit Jain
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3098.patch, OFBIZ-3098.patch, OFBIZ-3098.patch
>
>
> On onePageCheckout page in Shopping Cart(step1), if we enter any character(not numeric value) in quantity text box, then this text box become empty and show 'required' validation message, It should show "Please enter a valid number in this field."
> Step to reproduce:-
> 1) Add item in cart.
> 2) Move on onePageCheckout page.
> 3) Enter any character in item quantity text box.
> 4) Then it show validation message "required".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.