You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/12 16:08:54 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11238: feat: Option to run npm dev-server (hot reload) while calling docker-compose up

codecov-io edited a comment on pull request #11238:
URL: https://github.com/apache/incubator-superset/pull/11238#issuecomment-707210969


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11238?src=pr&el=h1) Report
   > Merging [#11238](https://codecov.io/gh/apache/incubator-superset/pull/11238?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a10e86ab318786fd43833d401e374b5a75ae838e?el=desc) will **decrease** coverage by `9.80%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11238/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11238?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11238      +/-   ##
   ==========================================
   - Coverage   65.61%   55.81%   -9.81%     
   ==========================================
     Files         828      404     -424     
     Lines       39148    13405   -25743     
     Branches     3589     3390     -199     
   ==========================================
   - Hits        25687     7482   -18205     
   + Misses      13350     5741    -7609     
   - Partials      111      182      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.81% <ø> (-0.03%)` | :arrow_down: |
   | #javascript | `?` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11238?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/11238/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | | |
   | [...dashboard/components/ColorSchemeControlWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11238/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvQ29sb3JTY2hlbWVDb250cm9sV3JhcHBlci5qc3g=) | | |
   | [...tor-superset/superset-frontend/src/profile/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11238/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvcHJvZmlsZS9BcHAudHN4) | | |
   | [...ons/bebcf3fed1fe\_convert\_dashboard\_v1\_positions.py](https://codecov.io/gh/apache/incubator-superset/pull/11238/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iZWJjZjNmZWQxZmVfY29udmVydF9kYXNoYm9hcmRfdjFfcG9zaXRpb25zLnB5) | | |
   | [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11238/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | | |
   | [.../c2acd2cf3df2\_alter\_type\_of\_dbs\_encrypted\_extra.py](https://codecov.io/gh/apache/incubator-superset/pull/11238/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jMmFjZDJjZjNkZjJfYWx0ZXJfdHlwZV9vZl9kYnNfZW5jcnlwdGVkX2V4dHJhLnB5) | | |
   | [...hboard/components/filterscope/FilterScopeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11238/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvZmlsdGVyc2NvcGUvRmlsdGVyU2NvcGVNb2RhbC5qc3g=) | | |
   | [...tions/versions/1a48a5411020\_adding\_slug\_to\_dash.py](https://codecov.io/gh/apache/incubator-superset/pull/11238/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xYTQ4YTU0MTEwMjBfYWRkaW5nX3NsdWdfdG9fZGFzaC5weQ==) | | |
   | [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11238/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | | |
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/11238/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | | |
   | ... and [1222 more](https://codecov.io/gh/apache/incubator-superset/pull/11238/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11238?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11238?src=pr&el=footer). Last update [a10e86a...4b264ab](https://codecov.io/gh/apache/incubator-superset/pull/11238?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org