You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/06/14 14:50:10 UTC
[GitHub] [incubator-linkis] casionone opened a new pull request, #2282: [WIP][Improvement]Optimize of linkis assamble-combined-package module
casionone opened a new pull request, #2282:
URL: https://github.com/apache/incubator-linkis/pull/2282
### What is the purpose of the change
(For example: EngineConn-Core defines the the abstractions and interfaces of the EngineConn core functions.
The Engine Service in Linkis 0.x is refactored, EngineConn will handle the engine connection and session management.
Related issues: #590. )
### Brief change log
(for example:)
- Define the core abstraction and interfaces of the EngineConn Factory;
- Define the core abstraction and interfaces of Executor Manager.
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
- Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- Anything that affects deployment: (yes / no / don't know)
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (yes / no)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2282: [WIP][Improvement]Optimize of linkis assamble-combined-package module
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2282:
URL: https://github.com/apache/incubator-linkis/pull/2282#issuecomment-1155340871
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2282?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2282](https://codecov.io/gh/apache/incubator-linkis/pull/2282?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fbedc0d) into [dev-1.2.0](https://codecov.io/gh/apache/incubator-linkis/commit/b0f5008c06281ba00a2eaf4891215daa9aa4181f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0f5008) will **increase** coverage by `0.40%`.
> The diff coverage is `n/a`.
> :exclamation: Current head fbedc0d differs from pull request most recent head 082040a. Consider uploading reports for the commit 082040a to get more accurate results
```diff
@@ Coverage Diff @@
## dev-1.2.0 #2282 +/- ##
===============================================
+ Coverage 19.96% 20.36% +0.40%
- Complexity 1028 1040 +12
===============================================
Files 453 454 +1
Lines 13689 13797 +108
Branches 2149 2177 +28
===============================================
+ Hits 2733 2810 +77
- Misses 10592 10600 +8
- Partials 364 387 +23
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ngineplugin/jdbc/JDBCDataSourceConfigurations.java](https://codecov.io/gh/apache/incubator-linkis/pull/2282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9lbmdpbmVjb25uLXBsdWdpbnMvamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL21hbmFnZXIvZW5naW5lcGx1Z2luL2pkYmMvSkRCQ0RhdGFTb3VyY2VDb25maWd1cmF0aW9ucy5qYXZh) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...is/manager/engineplugin/jdbc/PropertiesParser.java](https://codecov.io/gh/apache/incubator-linkis/pull/2282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9lbmdpbmVjb25uLXBsdWdpbnMvamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL21hbmFnZXIvZW5naW5lcGx1Z2luL2pkYmMvUHJvcGVydGllc1BhcnNlci5qYXZh) | `62.50% <0.00%> (ø)` | |
| [...ugin/jdbc/executer/JDBCMultiDatasourceParser.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9lbmdpbmVjb25uLXBsdWdpbnMvamRiYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9qZGJjL2V4ZWN1dGVyL0pEQkNNdWx0aURhdGFzb3VyY2VQYXJzZXIuc2NhbGE=) | `48.88% <0.00%> (ø)` | |
| [...s/manager/engineplugin/jdbc/ConnectionManager.java](https://codecov.io/gh/apache/incubator-linkis/pull/2282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9lbmdpbmVjb25uLXBsdWdpbnMvamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL21hbmFnZXIvZW5naW5lcGx1Z2luL2pkYmMvQ29ubmVjdGlvbk1hbmFnZXIuamF2YQ==) | `43.12% <0.00%> (+1.89%)` | :arrow_up: |
| [...eplugin/jdbc/executer/JDBCEngineConnExecutor.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9lbmdpbmVjb25uLXBsdWdpbnMvamRiYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9qZGJjL2V4ZWN1dGVyL0pEQkNFbmdpbmVDb25uRXhlY3V0b3Iuc2NhbGE=) | `12.98% <0.00%> (+12.98%)` | :arrow_up: |
| [...ineplugin/jdbc/factory/JDBCEngineConnFactory.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9lbmdpbmVjb25uLXBsdWdpbnMvamRiYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9qZGJjL2ZhY3RvcnkvSkRCQ0VuZ2luZUNvbm5GYWN0b3J5LnNjYWxh) | `50.00% <0.00%> (+50.00%)` | :arrow_up: |
| [...ger/engineplugin/jdbc/conf/JDBCConfiguration.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9lbmdpbmVjb25uLXBsdWdpbnMvamRiYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9qZGJjL2NvbmYvSkRCQ0NvbmZpZ3VyYXRpb24uc2NhbGE=) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2282?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2282?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b0f5008...082040a](https://codecov.io/gh/apache/incubator-linkis/pull/2282?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone closed pull request #2282: [WIP][Improvement]Optimize of linkis assamble-combined-package module
Posted by GitBox <gi...@apache.org>.
casionone closed pull request #2282: [WIP][Improvement]Optimize of linkis assamble-combined-package module
URL: https://github.com/apache/incubator-linkis/pull/2282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org