You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/14 21:07:27 UTC

[GitHub] [trafficserver] cukiernik commented on a change in pull request #7821: Add method to write an IpAddr value to a sockaddr.

cukiernik commented on a change in pull request #7821:
URL: https://github.com/apache/trafficserver/pull/7821#discussion_r632807111



##########
File path: src/tscore/ink_inet.cc
##########
@@ -463,6 +463,27 @@ IpAddr::toString(char *dest, size_t len) const
   return dest;
 }
 
+sockaddr *
+IpAddr::toSockAddr(sockaddr *dest) const
+{
+  if (AF_INET == _family) {

Review comment:
       maybe use a **switch(_family)**?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org