You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2026/06/04 03:42:06 UTC

Re: [PR] Reject negative ln inputs [datafusion]

github-actions[bot] commented on PR #22276:
URL: https://github.com/apache/datafusion/pull/22276#issuecomment-4618735627

   <!-- semver-check-comment -->
   Thank you for opening this pull request!
   
   Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
   
   <details>
   <summary>Details</summary>
   
   ```
        Cloning apache/main
       Building datafusion-functions v53.1.0 (current)
          Built [  29.094s] (current)
        Parsing datafusion-functions v53.1.0 (current)
         Parsed [   0.084s] (current)
       Building datafusion-functions v53.1.0 (baseline)
          Built [  28.265s] (baseline)
        Parsing datafusion-functions v53.1.0 (baseline)
         Parsed [   0.084s] (baseline)
       Checking datafusion-functions v53.1.0 -> v53.1.0 (no change; assume patch)
        Checked [   0.534s] 222 checks: 222 pass, 30 skip
        Summary no semver update required
       Finished [  61.251s] datafusion-functions
       Building datafusion-sqllogictest v53.1.0 (current)
          Built [ 166.616s] (current)
        Parsing datafusion-sqllogictest v53.1.0 (current)
         Parsed [   0.024s] (current)
       Building datafusion-sqllogictest v53.1.0 (baseline)
          Built [ 168.783s] (baseline)
        Parsing datafusion-sqllogictest v53.1.0 (baseline)
         Parsed [   0.027s] (baseline)
       Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch)
        Checked [   0.110s] 222 checks: 218 pass, 4 fail, 0 warn, 30 skip
   
   --- failure feature_missing: package feature removed or renamed ---
   
   Description:
   A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
           ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
          impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/feature_missing.ron
   
   Failed in:
     feature memory-accounting in the package's Cargo.toml
   
   --- failure function_missing: pub fn removed or renamed ---
   
   Description:
   A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
           ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron
   
   Failed in:
     function datafusion_sqllogictest::local_balance, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:196
     function datafusion_sqllogictest::set_default_budget, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:147
     function datafusion_sqllogictest::account_balance, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:189
     function datafusion_sqllogictest::set_account_balance, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:168
     function datafusion_sqllogictest::current_context_id, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:127
     function datafusion_sqllogictest::memory_tracker_limit, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:184
     function datafusion_sqllogictest::default_budget, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:153
     function datafusion_sqllogictest::next_context_id, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:99
     function datafusion_sqllogictest::settle_thread_local, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:202
     function datafusion_sqllogictest::set_thread_context_id, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:105
     function datafusion_sqllogictest::set_memory_tracker_limit, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:179
     function datafusion_sqllogictest::reset_account_to_default, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:162
   
   --- failure pub_module_level_const_missing: pub module-level const is missing ---
   
   Description:
   A public const is missing or renamed
           ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/pub_module_level_const_missing.ron
   
   Failed in:
     SLT_TARGET_PARTITIONS in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/test_context.rs:74
   
   --- failure struct_missing: pub struct removed or renamed ---
   
   Description:
   A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
           ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/struct_missing.ron
   
   Failed in:
     struct datafusion_sqllogictest::OverdraftPanic, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:140
     struct datafusion_sqllogictest::AccountingAllocator, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting.rs:260
     struct datafusion_sqllogictest::AccountingMemoryPool, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/176a0136ab69b45357b9137038b732d8e332146a/datafusion/sqllogictest/src/accounting_pool.rs:45
   
        Summary semver requires new major version: 4 major and 0 minor checks failed
       Finished [ 339.463s] datafusion-sqllogictest
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org