You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Erwan de FERRIERES (JIRA)" <ji...@apache.org> on 2009/12/01 12:33:20 UTC

[jira] Created: (OFBIZ-3280) Add the images in docbook help

Add the images in docbook help
------------------------------

                 Key: OFBIZ-3280
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3280
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Erwan de FERRIERES
             Fix For: SVN trunk


this patch will allow to diplay images in the help system.

The help images will be located in framework/images/webapp/images/help (one is included in this issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3280) Add the images in docbook help

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3280:
--------------------------------------

    Attachment: ofbizSeleniumSetup1.png
                OFBIZ-3280.diff

> Add the images in docbook help
> ------------------------------
>
>                 Key: OFBIZ-3280
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3280
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3280.diff, ofbizSeleniumSetup1.png
>
>
> this patch will allow to diplay images in the help system.
> The help images will be located in framework/images/webapp/images/help (one is included in this issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3280) Add the images in docbook help

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784216#action_12784216 ] 

Erwan de FERRIERES commented on OFBIZ-3280:
-------------------------------------------

In docbook 5.0, graphic has been replaced with MediaObject, it's why there is this error...

http://www.docbook.org/tdg/en/html/mediaobject.html

http://www.docbook.org/tdg/en/html/graphic.html

> Add the images in docbook help
> ------------------------------
>
>                 Key: OFBIZ-3280
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3280
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3280.diff, ofbizSeleniumSetup1.png
>
>
> this patch will allow to diplay images in the help system.
> The help images will be located in framework/images/webapp/images/help (one is included in this issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3280) Add the images in docbook help

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784194#action_12784194 ] 

Jacques Le Roux commented on OFBIZ-3280:
----------------------------------------

Ha also: not a big deal as it works well but "Eclipse" (actually Xerces) complains about "element 'graphic'". 

[Xerces] cvc-complex-type.2.4.a: Invalid content was found
starting with element 'graphic'. One of '{"http://docbook
.org/ns/docbook":info, "http://docbook.org/ns/docbook
":inlinemediaobject, "http://docbook.org/ns/docbook":remark,
"http://docbook.org/ns/docbook":superscript, "http:/
/docbook.org/ns/docbook":subscript, "http://docbook.org/ns
/docbook":xref, "http://docbook.org/ns/docbook":link, "http:/
/docbook.org/ns/docbook":olink, "http://docbook.org/ns
/docbook":anchor, "http://docbook.org/ns/docbook":biblioref,
"http://docbook.org/ns/docbook":alt, "http://docbook.org/ns/
docbook":annotation, "http://docbook.org/ns/docbook
":indexterm, "http://docbook.org/ns/docbook":abbrev, "http://
docbook.org/ns/docbook":acronym, "http://docbook.org/ns
/docbook":date, "http://docbook.org/ns/docbook":emphasis, 
"http://docbook.org/ns/docbook":footnote, "http://docbook
.org/ns/docbook":footnoteref, "http://docbook.org/ns/docbook"
:foreignphrase, "http://docbook.org/ns/docbook":phrase, 
"http://docbook.org/ns/docbook":quote, "http://docbook.org
/ns/docbook":wordasword, "http://docbook.org/ns/docbook
":firstterm, "http://docbook.org/ns/docbook":glossterm, 
"http://docbook.org/ns/docbook":coref, "http://docbook.org
/ns/docbook":trademark, "http://docbook.org/ns/docbook
":productnumber, "http://docbook.org/ns/docbook":productname,
 "http://docbook.org/ns/docbook":database, "http://docbook
.org/ns/docbook":application, "http://docbook.org/ns/docbook"
:hardware, "http://docbook.org/ns/docbook":citation, "http:/
/docbook.org/ns/docbook":citerefentry, "http://docbook.org
/ns/docbook":citetitle, "http://docbook.org/ns/docbook
":citebiblioid, "http://docbook.org/ns/docbook":author, 
"http://docbook.org/ns/docbook":person, "http://docbook.org
/ns/docbook":personname, "http://docbook.org/ns/docbook":org,
 "http://docbook.org/ns/docbook":orgname, "http://docbook
.org/ns/docbook":editor, "http://docbook.org/ns/docbook
":jobtitle, "http://docbook.org/ns/docbook":replaceable, 
"http://docbook.org/ns/docbook":package, "http://docbook.org/
ns/docbook":parameter, "http://docbook.org/ns/docbook
":termdef, "http://docbook.org/ns/docbook":nonterminal, 
"http://docbook.org/ns/docbook":systemitem, "http://docbook
.org/ns/docbook":option, "http://docbook.org/ns/docbook
":optional, "http://docbook.org/ns/docbook":property, "http:/
/docbook.org/ns/docbook":inlineequation, "http://docbook
.org/ns/docbook":tag, "http://docbook.org/ns/docbook":markup,
 "http://docbook.org/ns/docbook":token, "http://docbook.org/
ns/docbook":symbol, "http://docbook.org/ns/docbook":literal,
 "http://docbook.org/ns/docbook":code, "http://docbook.org
/ns/docbook":constant, "http://docbook.org/ns/docbook":email,
 "http://docbook.org/ns/docbook":uri, "http://docbook.org
/ns/docbook":guiicon, "http://docbook.org/ns/docbook
":guibutton, "http://docbook.org/ns/docbook":guimenuitem, 
"http://docbook.org/ns/docbook":guimenu, "http://docbook.org/
ns/docbook":guisubmenu, "http://docbook.org/ns/docbook
":guilabel, "http://docbook.org/ns/docbook":menuchoice, 
"http://docbook.org/ns/docbook":mousebutton, "http://docbook.
org/ns/docbook":keycombo, "http://docbook.org/ns/docbook
":keycap, "http://docbook.org/ns/docbook":keycode, "http:/
/docbook.org/ns/docbook":keysym, "http://docbook.org/ns
/docbook":shortcut, "http://docbook.org/ns/docbook":accel, 
"http://docbook.org/ns/docbook":prompt, "http://docbook.org
/ns/docbook":envar, "http://docbook.org/ns/docbook":filename,
 "http://docbook.org/ns/docbook":command, "http://docbook
.org/ns/docbook":computeroutput, "http://docbook.org/ns
/docbook":userinput, "http://docbook.org/ns/docbook
":function, "http://docbook.org/ns/docbook":varname, "http://
docbook.org/ns/docbook":returnvalue, "http://docbook.org/ns/
docbook":type, "http://docbook.org/ns/docbook":classname, 
"http://docbook.org/ns/docbook":exceptionname, "http:/
/docbook.org/ns/docbook":interfacename, "http://docbook.org
/ns/docbook":methodname, "http://docbook.org/ns/docbook
":modifier, "http://docbook.org/ns/docbook":initializer, 
"http://docbook.org/ns/docbook":ooclass, "http://docbook.org/
ns/docbook":ooexception, "http://docbook.org/ns/docbook
":oointerface, "http://docbook.org/ns/docbook":errorcode, 
"http://docbook.org/ns/docbook":errortext, "http://docbook
.org/ns/docbook":errorname, "http://docbook.org/ns/docbook
":errortype, "http://docbook.org/ns/docbook":itemizedlist, 
"http://docbook.org/ns/docbook":orderedlist, "http://docbook.
org/ns/docbook":procedure, "http://docbook.org/ns/docbook
":simplelist, "http://docbook.org/ns/docbook":variablelist, "
http://docbook.org/ns/docbook":segmentedlist, "http:/
/docbook.org/ns/docbook":glosslist, "http://docbook.org/ns
/docbook":bibliolist, "http://docbook.org/ns/docbook
":calloutlist, "http://docbook.org/ns/docbook":qandaset, 
"http://docbook.org/ns/docbook":example, "http://docbook.org/
ns/docbook":figure, "http://docbook.org/ns/docbook":table, "
http://docbook.org/ns/docbook":equation, "http://docbook
.org/ns/docbook":informalexample, "http://docbook.org/ns
/docbook":informalfigure, "http://docbook.org/ns/docbook
":informaltable, "http://docbook.org/ns/docbook
":informalequation, "http://docbook.org/ns/docbook":sidebar,
"http://docbook.org/ns/docbook":blockquote, "http://docbook.
org/ns/docbook":address, "http://docbook.org/ns/docbook
":epigraph, "http://docbook.org/ns/docbook":mediaobject, 
"http://docbook.org/ns/docbook":screenshot, "http://docbook
.org/ns/docbook":task, "http://docbook.org/ns/docbook
":productionset, "http://docbook.org/ns/docbook
":constraintdef, "http://docbook.org/ns/docbook":msgset, 
"http://docbook.org/ns/docbook":screen, "http://docbook.org
/ns/docbook":literallayout, "http://docbook.org/ns/docbook
":programlistingco, "http://docbook.org/ns/docbook":screenco,
 "http://docbook.org/ns/docbook":programlisting, "http:/
/docbook.org/ns/docbook":synopsis, "http://docbook.org/ns
/docbook":bridgehead, "http://docbook.org/ns/docbook
":revhistory, "http://docbook.org/ns/docbook":funcsynopsis, "
http://docbook.org/ns/docbook":classsynopsis, "http:/
/docbook.org/ns/docbook":methodsynopsis, "http://docbook.org/
ns/docbook":constructorsynopsis, "http://docbook.org/ns
/docbook":destructorsynopsis, "http://docbook.org/ns/docbook"
:fieldsynopsis, "http://docbook.org/ns/docbook":cmdsynopsis,
 "http://docbook.org/ns/docbook":caution, "http://docbook
.org/ns/docbook":important, "http://docbook.org/ns/docbook
":note, "http://docbook.org/ns/docbook":tip, "http://docbook.
org/ns/docbook":warning}' is expected.
@see: http://www.w3.org/TR/xmlschema-1/#cvc-complex-type

> Add the images in docbook help
> ------------------------------
>
>                 Key: OFBIZ-3280
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3280
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3280.diff, ofbizSeleniumSetup1.png
>
>
> this patch will allow to diplay images in the help system.
> The help images will be located in framework/images/webapp/images/help (one is included in this issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3280) Add the images in docbook help

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784294#action_12784294 ] 

Jacques Le Roux commented on OFBIZ-3280:
----------------------------------------

Thanks Erwan,

>From the links above I see that DocBook 5.0 was introduced in August 2008 and from a [mail Hans sent me|http://markmail.org/message/t65ffomzlt6x7t22] it seems we use DocBook 5.0. But it's weird because I read in http://www.docbook.org/tdg/en/html/graphic.html

<<Future Changes
In DocBook V5.0, Graphic will be discarded. At that time, graphics will have to be incorporated using MediaObject or InlineMediaObject. >>

So we should not be able to render it correctly, isn'it ? But it works :/. 
Should we not comply to the xsd and use mediaobject/ImageObject ? Will it works ?




> Add the images in docbook help
> ------------------------------
>
>                 Key: OFBIZ-3280
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3280
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3280.diff, ofbizSeleniumSetup1.png
>
>
> this patch will allow to diplay images in the help system.
> The help images will be located in framework/images/webapp/images/help (one is included in this issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3280) Add the images in docbook help

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3280:
--------------------------------------

    Attachment: OFBIZ-3280.diff

In this new version, I :
* removed the graphic tag
* added the mediaobject tag
* updated the selenium help page

> Add the images in docbook help
> ------------------------------
>
>                 Key: OFBIZ-3280
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3280
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3280.diff, OFBIZ-3280.diff, ofbizSeleniumSetup1.png
>
>
> this patch will allow to diplay images in the help system.
> The help images will be located in framework/images/webapp/images/help (one is included in this issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (OFBIZ-3280) Add the images in docbook help

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-3280:
------------------------------------


Erwan,

Consider it as asked ;)

Thanks!

> Add the images in docbook help
> ------------------------------
>
>                 Key: OFBIZ-3280
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3280
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3280.diff, ofbizSeleniumSetup1.png
>
>
> this patch will allow to diplay images in the help system.
> The help images will be located in framework/images/webapp/images/help (one is included in this issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OFBIZ-3280) Add the images in docbook help

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3280:
--------------------------------------

    Assignee: Jacques Le Roux

> Add the images in docbook help
> ------------------------------
>
>                 Key: OFBIZ-3280
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3280
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3280.diff, ofbizSeleniumSetup1.png
>
>
> this patch will allow to diplay images in the help system.
> The help images will be located in framework/images/webapp/images/help (one is included in this issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3280) Add the images in docbook help

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784298#action_12784298 ] 

Erwan de FERRIERES commented on OFBIZ-3280:
-------------------------------------------

Hi Jacques,

for the rendering, there is no problem as it is a ftl macro which converts the docbook code.. we just have the word graphic underlined in ofbiz. The reason I made it this way is that Hans started this way in the help file, and it was easier than adding the mediaObject.

But implementing the mediaObject can be done if asked !

Cheers,

> Add the images in docbook help
> ------------------------------
>
>                 Key: OFBIZ-3280
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3280
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3280.diff, ofbizSeleniumSetup1.png
>
>
> this patch will allow to diplay images in the help system.
> The help images will be located in framework/images/webapp/images/help (one is included in this issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-3280) Add the images in docbook help

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3280.
----------------------------------

    Resolution: Fixed

Thanks Erwan,

Your (slightly modified) patch is in trunk at r885748.

I have simply resized the image to make it a bit more readable


> Add the images in docbook help
> ------------------------------
>
>                 Key: OFBIZ-3280
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3280
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3280.diff, ofbizSeleniumSetup1.png
>
>
> this patch will allow to diplay images in the help system.
> The help images will be located in framework/images/webapp/images/help (one is included in this issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-3280) Add the images in docbook help

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3280.
----------------------------------

    Resolution: Fixed

Thansk for the quick improvement Erwan,

Your patch is in trunk at r886157  


> Add the images in docbook help
> ------------------------------
>
>                 Key: OFBIZ-3280
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3280
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3280.diff, OFBIZ-3280.diff, ofbizSeleniumSetup1.png
>
>
> this patch will allow to diplay images in the help system.
> The help images will be located in framework/images/webapp/images/help (one is included in this issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.