You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/11/04 06:34:18 UTC

[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #217: [YUNIKORN-444] Add tracer implementation for scheduling process in the core

yangwwei commented on pull request #217:
URL: https://github.com/apache/incubator-yunikorn-core/pull/217#issuecomment-721540123


   Thank you @FrankinRUC  for the update, thank you @TaoYang526  for the review.
   I think this can work, and this is more efficient. The only concern I have is, the `ActiveSpan`, `FinishSpan` must be called in pairs, otherwise, it could cause really bad things (not sure how to avoid that though). Can we at least add some notes in the code to explicitly mention that? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org