You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2017/11/30 23:17:46 UTC
Review Request 64232: Add a temporary filter for overlay backend
related tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64232/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
This is a temporary filter to disable tests that use
overlay as backend on filesystems where `d_type` support is
missing. In particular, many XFS nodes are known to have this
issue.
Diffs
-----
src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
src/tests/environment.cpp 607ac6cf903c71bdf8e2f4e08581ef2a352db7cd
Diff: https://reviews.apache.org/r/64232/diff/1/
Testing
-------
Checked affected tests.
Thanks,
Meng Zhu
Re: Review Request 64232: Add a temporary filter for overlay backend
related tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64232/#review192533
-----------------------------------------------------------
FAIL: Mesos libprocess-tests failed to build
Reviews applied: `['64232']`
Failed command: `cmake.exe --build . --target libprocess-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64232
Relevant logs:
- [libprocess-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64232/logs/libprocess-tests-build-cmake-stdout.log):
```
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
"C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
96 Warning(s)
6 Error(s)
Time Elapsed 00:04:23.00
```
- [libprocess-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64232/logs/libprocess-tests-CMakeOutput.log):
```
Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_2cb96.dir\Debug\cmTC_2cb96.tlog\".
InitializeBuildStatus:
Creating "cmTC_2cb96.dir\Debug\cmTC_2cb96.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_2cb96.dir\Debug\" /Fd"cmTC_2cb96.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_2cb96.dir\Debug\" /Fd"cmTC_2cb96.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_2cb96.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_2cb96.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_2cb96.lib" /MACHINE:X64 /machine:x64 cmTC_2cb96.dir\Debug\src.obj
cmTC_2cb96.vcxproj -> C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_2cb96.exe
cmTC_2cb96.vcxproj -> C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_2cb96.pdb (Full PDB)
FinalizeBuildStatus:
Deleting file "cmTC_2cb96.dir\Debug\cmTC_2cb96.tlog\unsuccessfulbuild".
Touching "cmTC_2cb96.dir\Debug\cmTC_2cb96.tlog\cmTC_2cb96.lastbuildstate".
Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_2cb96.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.76
Source file was:
int main() { return 0; }
```
- [libprocess-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64232/logs/libprocess-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_d6738.dir\Debug\".
Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_d6738.dir\Debug\cmTC_d6738.tlog\".
InitializeBuildStatus:
Creating "cmTC_d6738.dir\Debug\cmTC_d6738.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_d6738.dir\Debug\" /Fd"cmTC_d6738.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_d6738.dir\Debug\" /Fd"cmTC_d6738.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d6738.vcxproj]
Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d6738.vcxproj" (default targets) -- FAILED.
Build FAILED.
"C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d6738.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d6738.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.10
```
- Mesos Reviewbot Windows
On Nov. 30, 2017, 11:17 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64232/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 11:17 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a temporary filter to disable tests that use
> overlay as backend on filesystems where `d_type` support is
> missing. In particular, many XFS nodes are known to have this
> issue.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
> src/tests/environment.cpp 607ac6cf903c71bdf8e2f4e08581ef2a352db7cd
>
>
> Diff: https://reviews.apache.org/r/64232/diff/1/
>
>
> Testing
> -------
>
> Checked affected tests.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 64232: Add a temporary filter for overlay backend
related tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64232/#review192527
-----------------------------------------------------------
src/tests/environment.cpp
Lines 599 (patched)
<https://reviews.apache.org/r/64232/#comment270727>
wrong location?
- Gilbert Song
On Nov. 30, 2017, 3:17 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64232/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 3:17 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a temporary filter to disable tests that use
> overlay as backend on filesystems where `d_type` support is
> missing. In particular, many XFS nodes are known to have this
> issue.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
> src/tests/environment.cpp 607ac6cf903c71bdf8e2f4e08581ef2a352db7cd
>
>
> Diff: https://reviews.apache.org/r/64232/diff/1/
>
>
> Testing
> -------
>
> Checked affected tests.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 64232: Add a temporary filter for overlay backend
related tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64232/#review192613
-----------------------------------------------------------
Fix it, then Ship it!
LGTM!
src/tests/environment.cpp
Lines 555-622 (patched)
<https://reviews.apache.org/r/64232/#comment270870>
ditto. please move the code above alphabetically.
src/tests/environment.cpp
Lines 558 (patched)
<https://reviews.apache.org/r/64232/#comment270866>
add:
It is due to .... Please see MESOS-xxxx for details.
src/tests/environment.cpp
Lines 561 (patched)
<https://reviews.apache.org/r/64232/#comment270865>
s/root directory/root directory of the agent's work dir/g
src/tests/environment.cpp
Lines 581 (patched)
<https://reviews.apache.org/r/64232/#comment270868>
Remember to add a period for your comments at the end.
```
// Clean up the temporary directory that is used for d_type detection.
```
src/tests/environment.cpp
Lines 600-601 (patched)
<https://reviews.apache.org/r/64232/#comment270867>
add to TODO: Avoid hard coding a specific directory for filtering. This is a temporary solution.
src/tests/environment.cpp
Lines 601 (patched)
<https://reviews.apache.org/r/64232/#comment270864>
instead of hard coding it. could we use `os::temp()`?
src/tests/environment.cpp
Lines 775 (patched)
<https://reviews.apache.org/r/64232/#comment270869>
I am assuming the filters are sorted alphabetically. Could you adjust it?
- Gilbert Song
On Dec. 1, 2017, 1:01 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64232/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 1:01 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a temporary filter to disable tests that use
> overlay as backend on filesystems where `d_type` support is
> missing. In particular, many XFS nodes are known to have this
> issue.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
> src/tests/environment.cpp 607ac6cf903c71bdf8e2f4e08581ef2a352db7cd
>
>
> Diff: https://reviews.apache.org/r/64232/diff/2/
>
>
> Testing
> -------
>
> Checked affected tests.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 64232: Add a temporary filter for overlay backend
related tests.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64232/
-----------------------------------------------------------
(Updated Dec. 1, 2017, 10:17 p.m.)
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
This is a temporary filter to disable tests that use
overlay as backend on filesystems where `d_type` support is
missing. In particular, many XFS nodes are known to have this
issue.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
src/tests/environment.cpp 607ac6cf903c71bdf8e2f4e08581ef2a352db7cd
Diff: https://reviews.apache.org/r/64232/diff/3/
Changes: https://reviews.apache.org/r/64232/diff/2-3/
Testing
-------
Checked affected tests.
Thanks,
Meng Zhu
Re: Review Request 64232: Add a temporary filter for overlay backend
related tests.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64232/
-----------------------------------------------------------
(Updated Dec. 1, 2017, 1:01 p.m.)
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
This is a temporary filter to disable tests that use
overlay as backend on filesystems where `d_type` support is
missing. In particular, many XFS nodes are known to have this
issue.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
src/tests/environment.cpp 607ac6cf903c71bdf8e2f4e08581ef2a352db7cd
Diff: https://reviews.apache.org/r/64232/diff/2/
Changes: https://reviews.apache.org/r/64232/diff/1-2/
Testing
-------
Checked affected tests.
Thanks,
Meng Zhu