You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/07/29 03:36:09 UTC
[PR] [Fix] Keep heartbeat alive when metadata lease is fenced [iotdb]
Caideyipi opened a new pull request, #18343:
URL: https://github.com/apache/iotdb/pull/18343
## Description
- catch MetadataLeaseFencedException while collecting schema usage in DataNode heartbeats so the heartbeat can still complete
- omit both region device and series usage maps after this failure, preventing ConfigNode from applying partial schema usage updates
- emit a localized warning and add regression coverage for the fenced-lease path
## Tests
- mvn -o -nsu test -pl iotdb-core/datanode -Dtest=DataNodeInternalRPCServiceImplTest#testHeartbeatSkipsSchemaUsageWhenMetadataLeaseIsFenced
- mvn -o -nsu test-compile -pl iotdb-core/datanode -P with-zh-locale -DskipTests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Keep heartbeat alive when metadata lease is fenced [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #18343:
URL: https://github.com/apache/iotdb/pull/18343#issuecomment-5129162627
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/18343?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `60.60606%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.43%. Comparing base ([`4861027`](https://app.codecov.io/gh/apache/iotdb/commit/486102749ddd57f2d2a769f6fa478875cbb21bd2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b5374`](https://app.codecov.io/gh/apache/iotdb/commit/48b537436d72351357c590390b2b8471a406e556?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/18343?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ol/thrift/impl/DataNodeInternalRPCServiceImpl.java](https://app.codecov.io/gh/apache/iotdb/pull/18343?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fprotocol%2Fthrift%2Fimpl%2FDataNodeInternalRPCServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcHJvdG9jb2wvdGhyaWZ0L2ltcGwvRGF0YU5vZGVJbnRlcm5hbFJQQ1NlcnZpY2VJbXBsLmphdmE=) | 47.05% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/iotdb/db/schemaengine/SchemaEngine.java](https://app.codecov.io/gh/apache/iotdb/pull/18343?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fschemaengine%2FSchemaEngine.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc2NoZW1hZW5naW5lL1NjaGVtYUVuZ2luZS5qYXZh) | 75.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18343 +/- ##
============================================
+ Coverage 43.14% 43.43% +0.29%
Complexity 374 374
============================================
Files 5364 5366 +2
Lines 382623 382978 +355
Branches 49749 49815 +66
============================================
+ Hits 165077 166347 +1270
+ Misses 217546 216631 -915
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/18343?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Keep heartbeat alive when metadata lease is fenced [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18343:
URL: https://github.com/apache/iotdb/pull/18343#issuecomment-5112565851
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18343) **Quality Gate failed**
Failed conditions
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18343) (required ≥ A)
<!-- sqra:qg_revision=577110d7bc77a435e0449fc4e6d30a3d001fb3a82ceef9d678d6be6fe75675d7 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18343)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Keep heartbeat alive when metadata lease is fenced [iotdb]
Posted by "alpass163gmail (via GitHub)" <gi...@apache.org>.
alpass163gmail commented on PR #18343:
URL: https://github.com/apache/iotdb/pull/18343#issuecomment-5164180063
looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Keep heartbeat alive when metadata lease is fenced [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18343:
URL: https://github.com/apache/iotdb/pull/18343#issuecomment-5128784790
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18343) **Quality Gate failed**
Failed conditions
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18343) (required ≥ A)
<!-- sqra:qg_revision=443ec8b9c25f2ec8d4f7dd57c10b7ba50fe651c4e06d9e5009a3ee3ef8149010 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18343)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Keep heartbeat alive when metadata lease is fenced [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18343:
URL: https://github.com/apache/iotdb/pull/18343#issuecomment-5112688856
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18343) **Quality Gate failed**
Failed conditions
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18343) (required ≥ A)
<!-- sqra:qg_revision=577110d7bc77a435e0449fc4e6d30a3d001fb3a82ceef9d678d6be6fe75675d7 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18343)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Keep heartbeat alive when metadata lease is fenced [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #18343:
URL: https://github.com/apache/iotdb/pull/18343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org