You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2015/05/15 16:44:07 UTC
[GitHub] activemq-artemis pull request: Initial commit of the hacking guide
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/263
Initial commit of the hacking guide
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis hacking_guide
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #263
----
commit 6083aa98a2bc8bf4fe9087185d8fb4141613a47d
Author: jbertram <jb...@apache.org>
Date: 2015-05-13T17:49:42Z
Initial commit of the hacking guide
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Initial commit of the hacking guide
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/263#issuecomment-102857388
this looks great to me...
I would leave this up to @mtaylor to merge it now or after the release
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Allow configurable size for client ...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/263#issuecomment-164823586
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Allow configurable size for client ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Allow configurable size for client ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/263#issuecomment-164807250
Why don't you do this. Instantiate the global pool on ActiveMQClient... and have the ServerLocator to get the instance from the ActiveMQClient when the pool changed.
you would create a method ActiveMQClient.setThreadPool(Executors....) and all the ServerLocator would do is to get it from there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Allow configurable size for client ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/263#issuecomment-164822717
I don't really mind about injecting the pool on Serverlocator if not the global. All we need it a global Thread pool.
It will be a non used feature IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Allow configurable size for client ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/263#issuecomment-164848635
This is broken, the pool is rejecting tasks beyond the max. We need to use a BlockingQueue, but that will also require coreSize==maxSize. it's basically a fixedCachePoolSize, which is what we need.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Allow configurable size for client ...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/263#issuecomment-164820671
OK I can add this as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Allow configurable size for client ...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/263#issuecomment-164811933
Injecting the globalPool is the same as injecting the local pool on each ServerLocator... I can also add the ability to inject a global pool on the ActiveMQClient to make it simpler? The current API manages thread pools at the server locator level. e.g. setThreadPoolMaxSize(final int threadPoolMaxSize), I've extended that to allow a local pool to be injected also. The next step for me was to use this pool injection in the RA. Changing the global pool imo adds more complexity... what happens when the globalThreadPool is changed after a client is already initialized?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Allow configurable size for client ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/263#issuecomment-164823116
also it will be hard to throw an error.. (how to do it on the testsuite?)
I would just reinit the pool. and let old clients keep the pool where they got it from.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Allow configurable size for client ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/263#issuecomment-164816758
>> what happens when the globalThreadPool is changed after a client is already initialized?
nothing.. or if you want to you could throw an exception after the pool has been utilized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Initial commit of the hacking guide
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram closed the pull request at:
https://github.com/apache/activemq-artemis/pull/263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Allow configurable size for client ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/263#issuecomment-164865448
@mtaylor This will have my proposed changes into this:
https://github.com/apache/activemq-artemis/commit/334cbebc13197d65b7f9acf65d62d0c5d6f6cbef
I don't know yet what to do with the core-pool-size.. it seems moot with the concept of letting runnables to be queued. this becomes simply a fixed-sized thread pool executors, but this is exactly what we need.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---