You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Thomas Neidhart <th...@gmail.com> on 2013/02/21 16:10:08 UTC
[logging] preparing for a 1.1.2 release
Hi all,
I think the logging component is almost ready for a (long awaited) 1.1.2
release. It fixes several bugs, especially a nasty deadlock in
WeakHashtable, which was requested by several people already.
There are two issues for which I would like to get more feedback before
starting a RC:
* LOGGING-135: Thread-safety improvements
For the Log4JLogger and the LogKitLogger, I did implement the double
checked locking idiom from Josh Bloch for the getLogger() method.
Now this only works safely for Java 5+, but I was hesitating to make
these methods synchronized as they are used everywhere in the
adapter.
* LOGGING-144: LogFactory ignores Throwable
There are several throw/catch(Throwable) in the code, where certain
exceptions like ThreadDeath are silently ignored. I provided a
patch, but would like some people to review it before applying it.
There are no reports about problems in the wild, so we could also
postpone this fix.
Thanks,
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [logging] preparing for a 1.1.2 release
Posted by Thomas Neidhart <th...@gmail.com>.
On 02/21/2013 04:20 PM, Gary Gregory wrote:
> Without going into details, I'd like to see a 1.1.2 as a conservative
> release that only fixes bugs (as you plan). The API and behavior should
> have no surprises (maybe adding synchronized will have unexpected
> side-effects in the behavior of clients). Then I would like to see a start
> on working with a 1.2/2.0 frame of mind that can be more aggressive. That
> or declare the component dead I suppose but we'd need to point to an
> alternative like Log4J 2.
btw. the release-notes are already up-to-date and ready to be reviewed.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [logging] preparing for a 1.1.2 release
Posted by Gary Gregory <ga...@gmail.com>.
Without going into details, I'd like to see a 1.1.2 as a conservative
release that only fixes bugs (as you plan). The API and behavior should
have no surprises (maybe adding synchronized will have unexpected
side-effects in the behavior of clients). Then I would like to see a start
on working with a 1.2/2.0 frame of mind that can be more aggressive. That
or declare the component dead I suppose but we'd need to point to an
alternative like Log4J 2.
Gary
On Thu, Feb 21, 2013 at 10:10 AM, Thomas Neidhart <thomas.neidhart@gmail.com
> wrote:
> Hi all,
>
> I think the logging component is almost ready for a (long awaited) 1.1.2
> release. It fixes several bugs, especially a nasty deadlock in
> WeakHashtable, which was requested by several people already.
>
> There are two issues for which I would like to get more feedback before
> starting a RC:
>
> * LOGGING-135: Thread-safety improvements
> For the Log4JLogger and the LogKitLogger, I did implement the double
> checked locking idiom from Josh Bloch for the getLogger() method.
> Now this only works safely for Java 5+, but I was hesitating to make
> these methods synchronized as they are used everywhere in the
> adapter.
>
> * LOGGING-144: LogFactory ignores Throwable
> There are several throw/catch(Throwable) in the code, where certain
> exceptions like ThreadDeath are silently ignored. I provided a
> patch, but would like some people to review it before applying it.
> There are no reports about problems in the wild, so we could also
> postpone this fix.
>
> Thanks,
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [logging] preparing for a 1.1.2 release
Posted by Jörg Schaible <Jo...@scalaris.com>.
Hi Thomas,
Thomas Neidhart wrote:
> Hi all,
>
> I think the logging component is almost ready for a (long awaited) 1.1.2
> release. It fixes several bugs, especially a nasty deadlock in
> WeakHashtable, which was requested by several people already.
>
> There are two issues for which I would like to get more feedback before
> starting a RC:
>
> * LOGGING-135: Thread-safety improvements
> For the Log4JLogger and the LogKitLogger, I did implement the double
> checked locking idiom from Josh Bloch for the getLogger() method.
> Now this only works safely for Java 5+, but I was hesitating to make
> these methods synchronized as they are used everywhere in the
> adapter.
>
> * LOGGING-144: LogFactory ignores Throwable
> There are several throw/catch(Throwable) in the code, where certain
> exceptions like ThreadDeath are silently ignored. I provided a
> patch, but would like some people to review it before applying it.
> There are no reports about problems in the wild, so we could also
> postpone this fix.
No, we should not again release something, that swallows stuff like
ThreadDeath. Sebb is definitely right here.
Cheers,
Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org