[jira] [Commented] (TEZ-4383) Upgrade to mockito 4.3

["Laszlo Attila Toth (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493180#comment-17493180 ] 

Laszlo Attila Toth commented on TEZ-4383:
-----------------------------------------

There are two major differences between mockito v1 and v4 (probably v2+) which can be missed:
 * any(Vertex.class), so any(Something.class) is different, it's now doesn't accept null pointer, only any(). So

 ** sometimes it's safe to use the any() "everywhere"
 ** sometimes the class has to be specified
 ** sometimes the any() form is required.
 * ArgumentCaptor<T>.getAllValues() returns a copy of the original arguments, so getAllValues().clear() doesn't work anymore.

> Upgrade to mockito 4.3
> ----------------------
>
>                 Key: TEZ-4383
>                 URL: https://issues.apache.org/jira/browse/TEZ-4383
>             Project: Apache Tez
>          Issue Type: Sub-task
>    Affects Versions: 0.10.1
>            Reporter: Laszlo Attila Toth
>            Priority: Major
>
> Currently mockito v1.10.8 is in use, which is very old and incompatible with Java 17.
> The goal is to upgrade to latest version (4.3.1 as of now)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)