You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2019/05/29 17:57:38 UTC
[spark] branch branch-2.3 updated: [SPARK-27869][CORE] Redact
sensitive information in System Properties from UI
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-2.3 by this push:
new 1d35fff [SPARK-27869][CORE] Redact sensitive information in System Properties from UI
1d35fff is described below
commit 1d35fffa54f1bf6d7a5820165ed02636758e2500
Author: Aaruna <aa...@gmail.com>
AuthorDate: Wed May 29 10:30:16 2019 -0700
[SPARK-27869][CORE] Redact sensitive information in System Properties from UI
Currently system properties are not redacted. This PR fixes that, so that any credentials passed as System properties are redacted as well.
Manual test. Run the following and see the UI.
```
bin/spark-shell --conf 'spark.driver.extraJavaOptions=-DMYSECRET=app'
```
Closes #24733 from aaruna/27869.
Authored-by: Aaruna <aa...@gmail.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
(cherry picked from commit bfa7f112e3258926befe9eaa9a489d3e0c4e2a0a)
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala b/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
index 43adab7a..5e53195 100644
--- a/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
@@ -42,8 +42,8 @@ private[ui] class EnvironmentPage(
propertyHeader, jvmRow, jvmInformation, fixedWidth = true)
val sparkPropertiesTable = UIUtils.listingTable(propertyHeader, propertyRow,
Utils.redact(conf, appEnv.sparkProperties.toSeq), fixedWidth = true)
- val systemPropertiesTable = UIUtils.listingTable(
- propertyHeader, propertyRow, appEnv.systemProperties, fixedWidth = true)
+ val systemPropertiesTable = UIUtils.listingTable(propertyHeader, propertyRow,
+ Utils.redact(conf, appEnv.systemProperties.sorted), fixedWidth = true)
val classpathEntriesTable = UIUtils.listingTable(
classPathHeaders, classPathRow, appEnv.classpathEntries, fixedWidth = true)
val content =
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org