You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2020/07/20 20:01:47 UTC
[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16218
Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
......................................................................
IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
The calls to get_num_in_flight_queries in TestFetchFirst are flaky
because they expect the number of in flight queries to drop to 0
immediately. This might not always be true, especially in ASAN builds
where Impala is generally slower.
This patch wraps to call to get_num_in_flight_queries in
ImpalaTestSuite.assert_eventually, which adds retries to the calls to
get_num_in_flight_queries.
Testing:
* Ran tests/hs2/test_fetch_first.py locally
Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
---
M tests/hs2/test_fetch_first.py
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/16218/1
--
To view, visit http://gerrit.cloudera.org:8080/16218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Gerrit-Change-Number: 16218
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16218 )
Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Gerrit-Change-Number: 16218
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Jul 2020 23:46:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16218 )
Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
......................................................................
IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
The calls to get_num_in_flight_queries in TestFetchFirst are flaky
because they expect the number of in flight queries to drop to 0
immediately. This might not always be true, especially in ASAN builds
where Impala is generally slower.
This patch wraps to call to get_num_in_flight_queries in
ImpalaTestSuite.assert_eventually, which adds retries to the calls to
get_num_in_flight_queries.
Testing:
* Ran tests/hs2/test_fetch_first.py locally
Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Reviewed-on: http://gerrit.cloudera.org:8080/16218
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/hs2/test_fetch_first.py
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Gerrit-Change-Number: 16218
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16218 )
Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6161/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Gerrit-Change-Number: 16218
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Jul 2020 23:46:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has removed a vote on this change.
Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/16218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Gerrit-Change-Number: 16218
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16218 )
Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6166/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Gerrit-Change-Number: 16218
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 18:20:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16218 )
Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Gerrit-Change-Number: 16218
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 23:28:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16218 )
Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Gerrit-Change-Number: 16218
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Jul 2020 23:45:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16218 )
Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6161/
--
To view, visit http://gerrit.cloudera.org:8080/16218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Gerrit-Change-Number: 16218
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 05:03:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16218 )
Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6660/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Gerrit-Change-Number: 16218
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Jul 2020 20:30:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16218 )
Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls
......................................................................
Patch Set 2:
Failed due to IMPALA-9991.
--
To view, visit http://gerrit.cloudera.org:8080/16218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I349f861e8219e62311e8d4e0bfbd8f3618f0fa46
Gerrit-Change-Number: 16218
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 18:19:45 +0000
Gerrit-HasComments: No