You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yew1eb <gi...@git.apache.org> on 2017/11/11 13:22:41 UTC
[GitHub] flink pull request #5001: [FLINK-7679][build[[java9] Upgrade maven enforcer ...
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5001
[FLINK-7679][build[[java9] Upgrade maven enforcer plugin to 3.0.0-M1
## What is the purpose of the change
Maven enforcer plugin fails after Java 9 build 175 [(MENFORCER-274)](https://issues.apache.org/jira/browse/MENFORCER-274) Let's upgrade the version to 3.0.0 when released.
## Brief change log
* Bump `maven-enforcer-plugin` version from 1.4.1 to 3.0.0-M1.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink FLINK-7679
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5001.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5001
----
commit fdfacfd4de50344d1f68609b4d1c84cb04c23f93
Author: yew1eb <ye...@gmail.com>
Date: 2017-11-08T16:46:03Z
[FLINK-7679][build[[java9] Upgrade maven enforcer plugin to 3.0.0-M1
----
---
[GitHub] flink pull request #5001: [FLINK-7679][build][java9] Upgrade maven enforcer ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5001
---
[GitHub] flink issue #5001: [FLINK-7679][build][java9] Upgrade maven enforcer plugin ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5001
The PR was messed up during a merge; the enforcer plugin is no correctly properly incremented in the root pom, but only in force-shading.
---
[GitHub] flink issue #5001: [FLINK-7679][build][java9] Upgrade maven enforcer plugin ...
Posted by yew1eb <gi...@git.apache.org>.
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5001
:wink: @zentol , Thank you for your careful review.
This PR has been updated.
---
[GitHub] flink issue #5001: [FLINK-7679][build][java9] Upgrade maven enforcer plugin ...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5001
+1 tests are passing and the 1.4 release has been forked so we're at the start of a new release cycle
---
[GitHub] flink issue #5001: [FLINK-7679][build][java9] Upgrade maven enforcer plugin ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5001
merging.
---