You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by so...@apache.org on 2022/07/20 11:39:06 UTC
[dolphinscheduler] branch dev updated: [Refactor][UI] Refactor rule manage using NSpace component. (#11069)
This is an automated email from the ASF dual-hosted git repository.
songjian pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 25ded1e81b [Refactor][UI] Refactor rule manage using NSpace component. (#11069)
25ded1e81b is described below
commit 25ded1e81b59a216275e6bbe26e0eb3e6f400f78
Author: songjianet <17...@qq.com>
AuthorDate: Wed Jul 20 19:39:00 2022 +0800
[Refactor][UI] Refactor rule manage using NSpace component. (#11069)
---
.../src/views/data-quality/rule/index.module.scss | 26 ---------
.../src/views/data-quality/rule/index.tsx | 62 ++++++++++------------
2 files changed, 28 insertions(+), 60 deletions(-)
diff --git a/dolphinscheduler-ui/src/views/data-quality/rule/index.module.scss b/dolphinscheduler-ui/src/views/data-quality/rule/index.module.scss
deleted file mode 100644
index e6b0dfe014..0000000000
--- a/dolphinscheduler-ui/src/views/data-quality/rule/index.module.scss
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-.table-card {
- margin-top: 8px;
-
- .pagination {
- margin-top: 20px;
- display: flex;
- justify-content: center;
- }
-}
diff --git a/dolphinscheduler-ui/src/views/data-quality/rule/index.tsx b/dolphinscheduler-ui/src/views/data-quality/rule/index.tsx
index bcb6fc0dc0..090d275669 100644
--- a/dolphinscheduler-ui/src/views/data-quality/rule/index.tsx
+++ b/dolphinscheduler-ui/src/views/data-quality/rule/index.tsx
@@ -22,22 +22,18 @@ import {
NButton,
NIcon,
NDataTable,
- NPagination,
- NCard
+ NPagination
} from 'naive-ui'
import { SearchOutlined } from '@vicons/antd'
import { useTable } from './use-table'
import Card from '@/components/card'
-import styles from './index.module.scss'
import RuleModal from './components/rule-modal'
const TaskResult = defineComponent({
name: 'rule',
setup() {
const { t, variables, getTableData } = useTable()
-
const showModalRef = ref(false)
-
const ruleEntryData = ref('')
const requestTableData = () => {
@@ -110,45 +106,43 @@ const TaskResult = defineComponent({
const { columns } = useTable(viewRuleEntry)
return (
- <div>
- <NCard>
+ <NSpace vertical>
+ <Card>
<NSpace justify='end'>
<NInput
- allowInput={this.trim}
+ allowInput={this.trim}
v-model={[this.searchVal, 'value']}
size='small'
placeholder={t('data_quality.rule.name')}
clearable
/>
<NButton size='small' type='primary' onClick={onSearch}>
- {{
- icon: () => (
- <NIcon>
- <SearchOutlined />
- </NIcon>
- )
- }}
+ <NIcon>
+ <SearchOutlined />
+ </NIcon>
</NButton>
</NSpace>
- </NCard>
- <Card class={styles['table-card']}>
- <NDataTable
- loading={loadingRef}
- columns={columns}
- data={this.tableData}
- />
- <div class={styles.pagination}>
- <NPagination
- v-model:page={this.page}
- v-model:page-size={this.pageSize}
- page-count={this.totalPage}
- show-size-picker
- page-sizes={[10, 30, 50]}
- show-quick-jumper
- onUpdatePage={requestTableData}
- onUpdatePageSize={onUpdatePageSize}
+ </Card>
+ <Card title={t('menu.rule')}>
+ <NSpace vertical>
+ <NDataTable
+ loading={loadingRef}
+ columns={columns}
+ data={this.tableData}
/>
- </div>
+ <NSpace justify='center'>
+ <NPagination
+ v-model:page={this.page}
+ v-model:page-size={this.pageSize}
+ page-count={this.totalPage}
+ show-size-picker
+ page-sizes={[10, 30, 50]}
+ show-quick-jumper
+ onUpdatePage={requestTableData}
+ onUpdatePageSize={onUpdatePageSize}
+ />
+ </NSpace>
+ </NSpace>
</Card>
{showModalRef && (
<RuleModal
@@ -158,7 +152,7 @@ const TaskResult = defineComponent({
data={ruleEntryData}
/>
)}
- </div>
+ </NSpace>
)
}
})